Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS for case study pages #10463

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 77eeeb0

https://deploy-preview-10463--kubernetes-io-master-staging.netlify.com

1 similar comment
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 77eeeb0

https://deploy-preview-10463--kubernetes-io-master-staging.netlify.com

@tnir
Copy link
Contributor Author

tnir commented Oct 2, 2018

@tnir
Copy link
Contributor Author

tnir commented Oct 2, 2018

/assign @Bradamant3
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 2, 2018
@kbhawkey
Copy link
Contributor

kbhawkey commented Oct 2, 2018

Hi. I think there are still a number of issues with the paragraph formatting (Challenge, Solution, Impact), and some white/gray horizontal space.
Still seeing some footer content on the right for other case studies, such as:
https://deploy-preview-10463--kubernetes-io-master-staging.netlify.com/case-studies/huawei/
https://deploy-preview-10463--kubernetes-io-master-staging.netlify.com/case-studies/box/

@Bradamant3 Bradamant3 removed their assignment Oct 2, 2018
@Bradamant3
Copy link
Contributor

/assign @zparnold

@tnir
Copy link
Contributor Author

tnir commented Oct 3, 2018

/kind design

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label Oct 3, 2018
@kbhawkey
Copy link
Contributor

kbhawkey commented Oct 3, 2018

@tnir, may be a sass-related change.

@lucperkins lucperkins removed their assignment Oct 3, 2018
@zparnold
Copy link
Member

zparnold commented Oct 4, 2018

/lgtm
/approve
@tnir A separate PR for those would be nice. Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit b45fd9c into kubernetes:master Oct 4, 2018
@tnir tnir deleted the 10462-fix-css-for-case-study branch October 4, 2018 01:22
@tnir
Copy link
Contributor Author

tnir commented Oct 4, 2018

@zparnold Thanks, I think so too. cc @kbhawkey

@tnir
Copy link
Contributor Author

tnir commented Oct 8, 2018

@tnir, may be a sass-related change.

@kbhawkey Ummm I don't think so. Anyway just created #10531, take a look if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/design Categorizes issue or PR as related to design. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout broken on Case Study detail
8 participants