Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix customized CSS for case study #10531

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Fix customized CSS for case study #10531

merged 1 commit into from
Nov 16, 2018

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 8, 2018

Closes #10486

Problem: Layout is broken on several case study detail pages with custom (not general) CSS.

Proposed Solution: Modernize and fix customized CSS.

Pages to Update:

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2018
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 8, 2018
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 8, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit cd342a5

https://deploy-preview-10531--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 8, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit afab833

https://deploy-preview-10531--kubernetes-io-master-staging.netlify.com

@tnir
Copy link
Contributor Author

tnir commented Oct 8, 2018

To reviewers, use the following links to the pages updated in this PR:

/assign @zparnold

@tnir tnir mentioned this pull request Oct 8, 2018
Merged
@tnir
Copy link
Contributor Author

tnir commented Oct 8, 2018

/kind bug
/kind design

/cc kbhawkey (via #10463 (comment))

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/design Categorizes issue or PR as related to design. labels Oct 8, 2018
@tnir
Copy link
Contributor Author

tnir commented Oct 9, 2018

(forgot to add at-mark in the previous command 😭 )

/cc @kbhawkey

@k8s-ci-robot
Copy link
Contributor

@tnir: GitHub didn't allow me to request PR reviews from the following users: kbhawkey.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

(forgot to add at-mark in the previous command 😭 )

/cc @kbhawkey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnir tnir mentioned this pull request Oct 9, 2018
Closed
2 tasks
@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2018

@tnir Please see if there are conflicts to be resolved...

@tnir
Fix customized CSS for case study
afab833 
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir force-pushed the 10486-fix-customized-css-for-case-study branch from cd342a5 to afab833 Compare October 9, 2018 08:05
@tnir
Copy link
Contributor Author

tnir commented Oct 9, 2018

Thanks for notifying me if there are conflicts. Just resolved it 😄

/cc @tengqm

@k8s-ci-robot k8s-ci-robot requested a review from tengqm October 9, 2018 08:07
@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@kbhawkey
Copy link
Contributor

kbhawkey commented Oct 9, 2018

@tnir, things look much better. I compared the changes against v1.11 and the first section of the case studies is the two column, multiple paragraph format. Is this columnar format supposed to be in v1.12? I am guessing this should be fixed in a generic way.
Also, what color is the footer supposed to be, black or dark gray?

@tnir
Copy link
Contributor Author

tnir commented Oct 16, 2018

/assign @zparnold

@Bradamant3
Copy link
Contributor

I might be missing something, but I don't see layout or color differences between this PR and the live site.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6260874 into kubernetes:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

@zparnold zparnold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/design Categorizes issue or PR as related to design. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout broken on several Case Study pages (with customized layout)
8 participants
@tnir @k8sio-netlify-preview-bot @k8s-ci-robot @tengqm @kbhawkey @Bradamant3 @zparnold @kubernetes-docs-i18n-bot