Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename blog entries as workaround for content types #10625

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Oct 16, 2018

As reported by issue #8953, we currently cannot properly handle dots in
the file name for blogs. These dots are causing problems in links for
many pages. This PR renames the blog entries to remove dots in file
names.

Closes: #8953

@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/en Issues or PRs related to English language label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4fb3d65

https://deploy-preview-10625--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Oct 16, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 652934f

https://deploy-preview-10625--kubernetes-io-master-staging.netlify.com

@steveperry-53 steveperry-53 self-assigned this Oct 25, 2018
@steveperry-53
Copy link
Contributor

/approve
/lgtm
@tengqm Looks like there's one merge conflict to resolve.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@tengqm tengqm changed the title Rename block entries as workaround for content types Rename blog entries as workaround for content types Nov 1, 2018
As reported by issue kubernetes#8953, we currently cannot properly handle dots in
the file name for blogs. These dots are causing problems in links for
many pages. This PR renames the blog entries to remove dots in file
names.

Closes: kubernetes#8953
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@Bradamant3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3, steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 9d5eae7 into kubernetes:master Nov 16, 2018
@tengqm tengqm deleted the fix-blog-names branch July 5, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants