Update RunAsUsername to beta #17460

PatrickLang · 2019-11-06T19:19:28Z

This updates the docs to promote RunAsUsername from alpha to beta. See kubernetes/enhancements#1043

/milestone v1.17

k8s-ci-robot · 2019-11-06T19:19:30Z

@PatrickLang: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

This updates the docs to promote RunAsUsername from alpha to beta. See kubernetes/enhancements#1043

/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8sio-netlify-preview-bot · 2019-11-06T19:19:36Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 9c64dde

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dcc96647e4791000b3df071

k8s-ci-robot · 2019-11-06T20:56:10Z

@makoscafee: The provided milestone is not valid for this repository. Milestones in this repository: [1.15-ja.1, 1.17]

Use /milestone clear to clear the milestone.

In response to this:

/milestone v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

makoscafee · 2019-11-06T20:56:29Z

/milestone 1.17

sftim · 2019-11-11T22:51:36Z

content/en/docs/tasks/configure-pod-container/configure-runasusername.md

@@ -23,7 +23,11 @@ You need to have a Kubernetes cluster and the kubectl command-line tool must be

 ### Enable the WindowsRunAsUserName feature gate


Does this heading still make sense?

I guess it's still there if you switch the view to 1.16, so no. Removing

sftim · 2019-11-11T22:54:17Z

content/en/docs/tasks/configure-pod-container/configure-runasusername.md


 This page shows how to enable and use the `RunAsUserName` feature for pods and containers that will run on Windows nodes. This feature is meant to be the Windows equivalent of the Linux-specific `runAsUser` feature, allowing users to run the container entrypoints with a different username that their default ones.

 {{< note >}}
-Currently this feature is in alpha state. The overall functionality of the feature will not change, but there may be some changes regarding the username validation. Please take this into consideration when testing or adopting this feature.
+Currently this feature is in beta state. The overall functionality of the feature will not change, but there may be some changes regarding the username validation. Please take this into consideration when testing or adopting this feature.


Suggested change

Currently this feature is in beta state. The overall functionality of the feature will not change, but there may be some changes regarding the username validation. Please take this into consideration when testing or adopting this feature.

This feature is in beta. The overall functionality for `RunAsUserName` will not change, but there may be some changes regarding the username validation.

Reworded as the feature gate is now enabled by default.

PatrickLang · 2019-11-13T23:48:19Z

The code merged kubernetes/kubernetes#84882, so this doc is ready for review/merge.

PatrickLang · 2019-11-13T23:48:58Z

Thanks @sftim - updated based on feedback

sftim

Looks OK to me from a style / valid MarkDown PoV

PatrickLang · 2019-11-15T00:27:00Z

This is ready for doc review, let me know if any changes are needed. Thanks!

michmike · 2019-11-19T15:33:08Z

/approve
/lgtm

daminisatya · 2019-11-20T09:39:29Z

/lgtm
/approve

k8s-ci-robot · 2019-11-20T09:39:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya, michmike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [daminisatya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback

* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove follow up placeholders Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update verbiage Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update to status.podIPs Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <khnidk@outlook.com> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <kiman@vmware.com> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <ddebroy@docker.com> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <jordan@liggitt.net> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)

Patrick Lang added 2 commits November 6, 2019 11:17

doc:Update RunAsUsername to beta

5f451c9

doc: update samples - kubernetes.io/os is no longer beta

d9c50c7

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2019

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 6, 2019

k8s-ci-robot requested review from Rajakavitha1 and sftim November 6, 2019 19:20

PatrickLang mentioned this pull request Nov 6, 2019

RunAsUserName for Windows kubernetes/enhancements#1043

Closed

4 tasks

k8s-ci-robot added this to the 1.17 milestone Nov 6, 2019

marosset mentioned this pull request Nov 6, 2019

Moving WindowsRunAsUserName to beta kubernetes/kubernetes#84882

Merged

sftim reviewed Nov 11, 2019

View reviewed changes

Updating based on review feedback

9c64dde

sftim approved these changes Nov 14, 2019

View reviewed changes

k8s-ci-robot assigned michmike Nov 19, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2019

k8s-ci-robot assigned daminisatya Nov 20, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019

k8s-ci-robot merged commit b57e73a into kubernetes:dev-1.17 Nov 20, 2019

mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019

Update RunAsUsername to beta (#17460)

7524f7d

* doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update RunAsUsername to beta #17460

Update RunAsUsername to beta #17460

PatrickLang commented Nov 6, 2019

k8s-ci-robot commented Nov 6, 2019

k8sio-netlify-preview-bot commented Nov 6, 2019 •

edited

Loading

k8s-ci-robot commented Nov 6, 2019

makoscafee commented Nov 6, 2019

sftim Nov 11, 2019

PatrickLang Nov 13, 2019

sftim Nov 11, 2019

PatrickLang Nov 13, 2019

PatrickLang commented Nov 13, 2019

PatrickLang commented Nov 13, 2019

sftim left a comment

PatrickLang commented Nov 15, 2019

michmike commented Nov 19, 2019

daminisatya commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

		@@ -23,7 +23,11 @@ You need to have a Kubernetes cluster and the kubectl command-line tool must be

		### Enable the WindowsRunAsUserName feature gate

	Currently this feature is in beta state. The overall functionality of the feature will not change, but there may be some changes regarding the username validation. Please take this into consideration when testing or adopting this feature.
	This feature is in beta. The overall functionality for `RunAsUserName` will not change, but there may be some changes regarding the username validation.

Update RunAsUsername to beta #17460

Update RunAsUsername to beta #17460

Conversation

PatrickLang commented Nov 6, 2019

k8s-ci-robot commented Nov 6, 2019

k8sio-netlify-preview-bot commented Nov 6, 2019 • edited Loading

k8s-ci-robot commented Nov 6, 2019

makoscafee commented Nov 6, 2019

sftim Nov 11, 2019

Choose a reason for hiding this comment

PatrickLang Nov 13, 2019

Choose a reason for hiding this comment

sftim Nov 11, 2019

Choose a reason for hiding this comment

PatrickLang Nov 13, 2019

Choose a reason for hiding this comment

PatrickLang commented Nov 13, 2019

PatrickLang commented Nov 13, 2019

sftim left a comment

Choose a reason for hiding this comment

PatrickLang commented Nov 15, 2019

michmike commented Nov 19, 2019

daminisatya commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

k8sio-netlify-preview-bot commented Nov 6, 2019 •

edited

Loading