Doc updates for CSIMigrationInTreeOff feature flag #17533

ddebroy · 2019-11-11T17:34:33Z

Doc update for CSIMigrationInTreeOff feature flag introduced in v1.17 part of CSI Migration.

/cc @davidz627 @leakingtapan

k8sio-netlify-preview-bot · 2019-11-11T17:34:43Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit c069144

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dddf06b7d812a000aa4c1d7

sftim · 2019-11-11T20:58:47Z

He @ddebroy. Is there a pull request to kubernetes/kubernetes that this matches against?

davidz627 · 2019-11-11T21:41:59Z

@sftim kubernetes/kubernetes#83098

davidz627 · 2019-11-12T00:28:30Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -312,6 +313,7 @@ Each feature gate is designed for enabling/disabling a specific feature:
 - `CSIDriverRegistry`: Enable all logic related to the CSIDriver API object in csi.storage.k8s.io.
 - `CSIInlineVolume`: Enable CSI Inline volumes support for pods.
 - `CSIMigration`: Enables shims and translation logic to route volume operations from in-tree plugins to corresponding pre-installed CSI plugins
+- `CSIMigrationInTreeOff` : Disables registration of in-tree storage plugins migrated to CSI


Could you explain a little bit more it's interaction with CSIMigrationX flags. (in that it only disables those ones)

tengqm · 2019-11-12T02:09:18Z

/hold
Please feel free to cancel the hold when the upstream change is in.

kbhawkey · 2019-11-17T21:07:48Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -63,6 +63,7 @@ different Kubernetes components.
 | `CSIInlineVolume` | `false` | Alpha | 1.15 | 1.15 |
 | `CSIInlineVolume` | `true` | Beta | 1.16 | - |
 | `CSIMigration` | `false` | Alpha | 1.14 | |
+| `CSIMigrationInTreeOff`  |  false  | Alpha | 1.17 | |


@ddebroy , do you think this entry should follow after CSIMigrationGCE

kbhawkey · 2019-11-17T21:08:39Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

@@ -312,6 +313,7 @@ Each feature gate is designed for enabling/disabling a specific feature:
 - `CSIDriverRegistry`: Enable all logic related to the CSIDriver API object in csi.storage.k8s.io.
 - `CSIInlineVolume`: Enable CSI Inline volumes support for pods.
 - `CSIMigration`: Enables shims and translation logic to route volume operations from in-tree plugins to corresponding pre-installed CSI plugins
+- `CSIMigrationInTreeOff` : Disables registration of in-tree storage plugins migrated to CSI


Possibly maintain alphabetical order?

davidz627 · 2019-11-18T22:30:33Z

These feature gates have been modified completely - @ddebroy could you update to current state? Thanks!

Signed-off-by: Deep Debroy <ddebroy@docker.com>

ddebroy · 2019-11-27T03:43:33Z

Updated with list of new feature flags and enhanced the descriptions. @davidz627 @leakingtapan @adisky @andyzhangx PTAL.

adisky · 2019-11-27T06:29:23Z

/lgtm

andyzhangx

/lgtm

daminisatya · 2019-11-27T16:44:41Z

/lgtm
/approve

k8s-ci-robot · 2019-11-27T16:45:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daminisatya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [daminisatya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

davidz627 · 2019-11-27T18:24:30Z

content/en/docs/reference/command-line-tools-reference/feature-gates.md

- `CSIMigrationAzureFile`: Enables shims and translation logic to route volume operations from the Azure-File in-tree plugin to Azure File CSI plugin
- `CSIMigrationGCE`: Enables shims and translation logic to route volume operations from the GCE-PD in-tree plugin to PD CSI plugin
- `CSIMigrationOpenStack`: Enables shims and translation logic to route volume operations from the Cinder in-tree plugin to Cinder CSI plugin
+- `CSIMigrationAWS`: Enables shims and translation logic to route volume operations from the AWS-EBS in-tree plugin to EBS CSI plugin. Supports falling back to in-tree EBS plugin if a node does not have EBS CSI plugin installed and configured. Requires CSIMigration feature flag enabled.


sorry I didn't see this earlier, I think we should make it clear that the fallback only happens if the node doesn't have the Feature Flags. It has nothing to do with the install status. Can you submit a follow-up PR to update @ddebroy ?

) Signed-off-by: Deep Debroy <ddebroy@docker.com>

* feat: graduate TaintNodesByCondition to GA (#17073) * Promote StartupProbe to beta (enabled by default). (#17164) * Watch bookmarks to GA (#17026) * feat: graduate ScheduleDaemonSetPods to GA (#17350) * Update Docker installation instructions (#17405) * Use exact version numbers for installing Docker in Ubuntu (#17428) * Move CSIMigration and CSIMigrationGCE to Beta in Kubernetes v1.17 (#17478) * Promote NodeLease feature to GA (#17189) * Update docs for csi topology ga (#17408) * Update RunAsUsername to beta (#17460) * doc:Update RunAsUsername to beta * doc: update samples - kubernetes.io/os is no longer beta * Updating based on review feedback * Promote Node-specific volume limits to GA (#17432) * Promote PodShareProcessNamespace to stable (#17192) * Promote PodShareProcessNamespace to stable * Add for_k8s_version to feature-state label Co-Authored-By: Tim Bannister <tim@scalefactory.com> * Readd version-check to shareProcessNamespace task * Update service load balancer finalizer doc for GA (#17438) * Update Topology Manager docs (#17451) * Added information on how device plugins can take advantage of Topology Manager * Updated the Topology Manager documentation to include additionalinformation and update some out of date sections * Fix broken Topology Manager link (#17746) Part of What's Next Device Plugin section * Update CRD defaulting docs for GA (#17450) * Add documentation for VolumeSnapshot Beta (#17233) * Updating EndpointSlice documentation for beta release in 1.17 (#17411) * (docs/dualstack): v1.17 updates (#17457) * Add placehold doc updates for dualstack in 1.17 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Add Downward API and /etc/hosts Pod IP validation Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove addressed known issue via k/k pr 85246 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Remove known issue and add flag as part of k/k 79993 Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * remove follow up placeholders Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update verbiage Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Make IP addressing consistent throughout the task Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update to status.podIPs Signed-off-by: Lachlan Evenson <lachlan.evenson@microsoft.com> * Update content/en/docs/tasks/network/validate-dual-stack.md Use set instead of env Co-Authored-By: Khaled Henidak (Kal) <khnidk@outlook.com> * add topology.kubernetes.io/zone, topology.kubernetes.io/region and node.kubernetes.io/instance-type labels to docs (#17498) Signed-off-by: Andrew Sy Kim <kiman@vmware.com> * Service topology alpha documentation (#17459) * Update list of feature flags for in-tree plugins migrated to CSI (#17533) Signed-off-by: Deep Debroy <ddebroy@docker.com> * Update Node concept for TaintNodesByCondition going GA (#17577) * feat: graduate ResourceQuotaScopeSelectors to GA in 1.17 (#17554) * kubeadm: update the upgrade documentation for 1.17 (#17587) * doc: Simplify Windows deployments with RuntimeClass (#16697) * doc: Simplify Windows deployments with RuntimeClass * Updating on review feedback * doc: Adding windows-build label from enhancement 1301 * update doc for kubelet option --reserved-cpus (#17648) * feat: update TaintNodesByCondition in feature gates table (#17377) * Update docs for v1 resource quota configuration (#17547) * AdmissionConfiguration v1 (#17548) * Update WebhookAdmissionConfiguration examples (#17549) * Update AWS EBS Migration Feature state (#16126) * Add resource version section to api-concepts documentation (#16910) * Add Resource Version semantics section to api concepts * Clarify risks of going back in time, add details about compaction and watch cache sizes * Apply suggestions from liggitt Co-Authored-By: Jordan Liggitt <jordan@liggitt.net> * remove pesudocode, apply feedback * Fix typo * Clarify equality rules * Cleanup kubectl generators docs (#17609) * Write ReplicationController without a space * Drop mentioning unsupported cluster versions * Fix capitalization for “API group” * Tweak wording * Avoid using deprecated generator in example * add Antrea description in dev-1.17 (#17919) * Promote VolumeSubpathEnvExpansion to GA * Reference Documentation for the Kubernetes API for 1.17 (#18019) * Update feature-gates.md (#18033) * Reference Documentation for kubectl Commands for 1.17 (#18017) * Update for v1.17 (#18034) * Update config.toml(release-1.17) for 1.17 (#18031)

k8s-ci-robot requested review from davidz627 and leakingtapan November 11, 2019 17:34

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 11, 2019

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 11, 2019

davidz627 mentioned this pull request Nov 12, 2019

In-tree storage plugin to CSI Driver Migration kubernetes/enhancements#625

Closed

1 task

davidz627 reviewed Nov 12, 2019

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2019

tengqm added this to the 1.17 milestone Nov 12, 2019

kbhawkey reviewed Nov 17, 2019

View reviewed changes

tengqm removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2019

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2019

Update list of feature flags for in-tree plugins migrated to CSI

c069144

Signed-off-by: Deep Debroy <ddebroy@docker.com>

k8s-ci-robot assigned adisky Nov 27, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2019

andyzhangx approved these changes Nov 27, 2019

View reviewed changes

k8s-ci-robot assigned andyzhangx Nov 27, 2019

k8s-ci-robot assigned daminisatya Nov 27, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019

k8s-ci-robot merged commit b8ecda5 into kubernetes:dev-1.17 Nov 27, 2019

davidz627 reviewed Nov 27, 2019

View reviewed changes

mrbobbytables pushed a commit that referenced this pull request Dec 6, 2019

Update list of feature flags for in-tree plugins migrated to CSI (#17533

fea3bf1

) Signed-off-by: Deep Debroy <ddebroy@docker.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc updates for CSIMigrationInTreeOff feature flag #17533

Doc updates for CSIMigrationInTreeOff feature flag #17533

ddebroy commented Nov 11, 2019

k8sio-netlify-preview-bot commented Nov 11, 2019 •

edited

Loading

sftim commented Nov 11, 2019

davidz627 commented Nov 11, 2019

davidz627 Nov 12, 2019

tengqm commented Nov 12, 2019

kbhawkey Nov 17, 2019

kbhawkey Nov 17, 2019

davidz627 commented Nov 18, 2019

ddebroy commented Nov 27, 2019

adisky commented Nov 27, 2019

andyzhangx left a comment

daminisatya commented Nov 27, 2019

k8s-ci-robot commented Nov 27, 2019

davidz627 Nov 27, 2019

Doc updates for CSIMigrationInTreeOff feature flag #17533

Doc updates for CSIMigrationInTreeOff feature flag #17533

Conversation

ddebroy commented Nov 11, 2019

k8sio-netlify-preview-bot commented Nov 11, 2019 • edited Loading

sftim commented Nov 11, 2019

davidz627 commented Nov 11, 2019

davidz627 Nov 12, 2019

Choose a reason for hiding this comment

tengqm commented Nov 12, 2019

kbhawkey Nov 17, 2019

Choose a reason for hiding this comment

kbhawkey Nov 17, 2019

Choose a reason for hiding this comment

davidz627 commented Nov 18, 2019

ddebroy commented Nov 27, 2019

adisky commented Nov 27, 2019

andyzhangx left a comment

Choose a reason for hiding this comment

daminisatya commented Nov 27, 2019

k8s-ci-robot commented Nov 27, 2019

davidz627 Nov 27, 2019

Choose a reason for hiding this comment

k8sio-netlify-preview-bot commented Nov 11, 2019 •

edited

Loading