Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: kubeadm: add usage of the v1beta3 type #17500

Closed
wants to merge 1 commit into from
Closed

WIP: kubeadm: add usage of the v1beta3 type #17500

wants to merge 1 commit into from

Conversation

neolit123
Copy link
Member

/sig cluster-lifecycle
/kind feature
/cc @rosti

xref
ttps://github.com/kubernetes/enhancements/issues/970
kubernetes/kubeadm#1796

@k8s-ci-robot k8s-ci-robot requested a review from rosti November 8, 2019 22:49
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2019
@neolit123 neolit123 mentioned this pull request Nov 8, 2019
Open
1 task
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 8, 2019
@neolit123 neolit123 changed the base branch from master to dev-1.17 November 8, 2019 22:51
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2019
@neolit123 neolit123 force-pushed the 1.17-kubeadm-add-v1beta3 branch from 4f3c024 to b55e994 Compare November 8, 2019 22:53
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit b55e994

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5dc5f1d6e4d9a5000731cb56

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2019
neolit123
neolit123 commented Nov 8, 2019
View reviewed changes
content/en/docs/reference/setup-tools/kubeadm/kubeadm-init-phase.md
type: "kube-dns"
addons:
- type: "kube-dns"
- type: "kube-proxy"
Copy link
Member Author

@neolit123 neolit123 Nov 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still under discussion. kubernetes/kubernetes#84991

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bradtopol
You can assign the PR to them by writing /assign @bradtopol in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Nov 8, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4f3c024

https://deploy-preview-17500--kubernetes-io-master-staging.netlify.com

@neolit123
Copy link
Member Author

/close
we decided to drop the v1beta3 incremented for 1.17.

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closed this PR.

In response to this:

/close
we decided to drop the v1beta3 incremented for 1.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosti rosti Awaiting requested review from rosti

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @k8sio-netlify-preview-bot @k8s-ci-robot