kubeadm: component config updates in 1.19 #21663

rosti · 2020-06-11T15:25:39Z

~~This is a placeholder for now.~~

/assign @neolit123 @fabriziopandini
/sig cluster-lifecycle

k8sio-netlify-preview-bot · 2020-06-11T15:25:43Z

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 65e914e

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f0f05a9fff5710008bbd0fe

savitharaghunathan · 2020-06-11T23:06:25Z

/milestone 1.19
/assign

rosti · 2020-07-03T16:48:33Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md

+{{< note >}}
+If `kubeadm upgrade plan` shows any component configs that require manual upgrade, users must provide
+a config file with replacement configs to `kubeadm upgrade apply` via the `--config` command line flag.
+Failing to do so will cause `kubeadm upgrade apply` to exit with an error and not perform an upgrade.


My idea here is for this note to also contain a link at the end to a different page describing in detail the workflow in that case. For that matter, however, we should have the alpha commands from the KEP merged as well (possibly in the next release cycle).

My idea here is for this note to also contain a link at the end to a different page describing in detail the workflow in that case.

if the new page is going to be at k/website it's fine because the k8s.io docs are branched.
if it links at k/kubeadm, the repo is not branched, so we better have SHAs in the link.

I am thinking more about using k/website for that. That's why I want the full set of command line additions to merge before doing the separate page.

neolit123 · 2020-07-03T21:52:36Z

@rosti i sent a placeholder for the generic "upgrade docs update" here:
#21860

but i think the PRs are going to conflict, do you think you can do the rest of the changes in this PR?
it's about showing the whole upgrade plan / apply output and search + replace for versions.

fabriziopandini · 2020-07-06T09:31:04Z

@rosti thanks!
Ready to lgtm as soon as @neolit123 commits are addressed

rosti · 2020-07-13T09:49:33Z

@rosti i sent a placeholder for the generic "upgrade docs update" here:
#21860

but i think the PRs are going to conflict, do you think you can do the rest of the changes in this PR?
it's about showing the whole upgrade plan / apply output and search + replace for versions.

It seems that it only requires version bumps here and there. I can do that in this PR (as a separate commit). Will update later today.

rosti · 2020-07-13T16:41:40Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md


 To see information about upgrading clusters created using older versions of kubeadm,
 please refer to following pages instead:

+- [Upgrading kubeadm cluster from 1.17 to 1.18](https://v1-18.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)
 - [Upgrading kubeadm cluster from 1.16 to 1.17](https://v1-17.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)
 - [Upgrading kubeadm cluster from 1.15 to 1.16](https://v1-16.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)
 - [Upgrading kubeadm cluster from 1.14 to 1.15](https://v1-15.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-15/)


@neolit123 should we drop the link "from 1.14 to 1.15"?

If v1.14 is still supported after the v1.19 release happens, I would expect to leave that link in.

rosti · 2020-07-13T16:42:12Z

Added the generic 1.19 updates to this PR too (as a separate commit).

sftim · 2020-07-14T18:04:39Z

@rosti the PR description reads

This is a placeholder for now.

Is that still accurate?

sftim

@rosti, please rebase this against dev-1.19 to incorporate changes from #21359

sftim · 2020-07-14T18:05:25Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md


 To see information about upgrading clusters created using older versions of kubeadm,
 please refer to following pages instead:

+- [Upgrading kubeadm cluster from 1.17 to 1.18](https://v1-18.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)
 - [Upgrading kubeadm cluster from 1.16 to 1.17](https://v1-17.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)
 - [Upgrading kubeadm cluster from 1.15 to 1.16](https://v1-16.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)
 - [Upgrading kubeadm cluster from 1.14 to 1.15](https://v1-15.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-15/)


If v1.14 is still supported after the v1.19 release happens, I would expect to leave that link in.

sftim · 2020-07-14T21:43:54Z

/hold
to make #21663 (review) more visible in PR listings

OK to unhold once this is rebased.

This briefly adds a description for some side steps in the upgrade process. Most notably, it mentions the existance of the component config state table at the end of the `kubeadm upgrade plan` output and the need to specify a file with upgraded configs to `kubeadm upgrade apply` if the config state table says so. Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>

rosti · 2020-07-15T13:34:12Z

@sftim rebased it.
/hold cancel

@fabriziopandini PTAL

fabriziopandini

@rosti thanks for taking care of this work!
/approve
/lgtm

kbhawkey · 2020-07-15T15:37:37Z

Page preview:
https://deploy-preview-21663--kubernetes-io-vnext-staging.netlify.app/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/

kbhawkey · 2020-07-15T15:43:32Z

content/en/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md


 To see information about upgrading clusters created using older versions of kubeadm,
 please refer to following pages instead:

+- [Upgrading kubeadm cluster from 1.17 to 1.18](https://v1-18.docs.kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/)


@rosti , Would you check the last two links. Are both links required? The links point to the 1.15 snapshot version of the docs.
1.18-1.19
1.17-1.18
1.16-1.17
1.15-1.1.6
1.14-1.15 ?

The idea there is to keep as much as possible from the older upgrade docs to allow folks with older clusters to incrementally upgrade to modern Kubernetes versions.
These are good to be kept as long as the 1.15 snapshot is still present. If not, I can send a PR to remove the link.

kbhawkey · 2020-07-15T15:46:04Z

Hi @rosti . Besides checking on the links to previous upgrade instructions, the page looks good.

Superseded

kbhawkey · 2020-07-16T00:39:29Z

Besides the link question,
/lgtm

kbhawkey · 2020-07-16T00:42:44Z

/approve

k8s-ci-robot · 2020-07-16T00:43:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot assigned fabriziopandini and neolit123 Jun 11, 2020

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2020

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2020

k8s-ci-robot requested review from rajeshdeshpande02 and tengqm June 11, 2020 15:26

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 11, 2020

rosti mentioned this pull request Jun 11, 2020

New kubeadm component config scheme kubernetes/enhancements#1381

Open

k8s-ci-robot assigned savitharaghunathan Jun 11, 2020

k8s-ci-robot added this to the 1.19 milestone Jun 11, 2020

rosti force-pushed the kubeadm-cc-updates-1.19 branch from 93ded8c to d18fa51 Compare July 3, 2020 16:30

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2020

rosti commented Jul 3, 2020

View reviewed changes

rosti changed the title ~~[WIP] kubeadm: component config updates in 1.19~~ kubeadm: component config updates in 1.19 Jul 3, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2020

neolit123 mentioned this pull request Jul 3, 2020

1.19: Housekeeping tasks kubernetes/kubeadm#2076

Closed

9 tasks

neolit123 mentioned this pull request Jul 11, 2020

Remove SCL reviewers/approvers from OWNERS_ALIASES #22474

Merged

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2020

rosti commented Jul 13, 2020

View reviewed changes

rosti requested a review from neolit123 July 13, 2020 16:42

sftim previously requested changes Jul 14, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2020

rosti added 2 commits July 15, 2020 16:32

Update the kubeadm upgrade page for 1.19

65e914e

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>

rosti force-pushed the kubeadm-cc-updates-1.19 branch from 1367ba3 to 65e914e Compare July 15, 2020 13:33

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2020

fabriziopandini approved these changes Jul 15, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2020

kbhawkey reviewed Jul 15, 2020

View reviewed changes

neolit123 mentioned this pull request Jul 15, 2020

WIP: kubeadm: update the upgrade documentation for 1.19 #21860

Closed

k8s-ci-robot assigned kbhawkey Jul 16, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020

k8s-ci-robot merged commit eb6b1f8 into kubernetes:dev-1.19 Jul 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kubeadm: component config updates in 1.19 #21663

kubeadm: component config updates in 1.19 #21663

rosti commented Jun 11, 2020 •

edited by sftim

Loading

k8sio-netlify-preview-bot commented Jun 11, 2020 •

edited

Loading

savitharaghunathan commented Jun 11, 2020

rosti Jul 3, 2020

neolit123 Jul 3, 2020

rosti Jul 13, 2020

neolit123 commented Jul 3, 2020 •

edited

Loading

fabriziopandini commented Jul 6, 2020

rosti commented Jul 13, 2020

rosti Jul 13, 2020

sftim Jul 14, 2020

rosti commented Jul 13, 2020

sftim commented Jul 14, 2020

sftim left a comment

sftim Jul 14, 2020

sftim commented Jul 14, 2020

rosti commented Jul 15, 2020

fabriziopandini left a comment

kbhawkey commented Jul 15, 2020

kbhawkey Jul 15, 2020

rosti Jul 16, 2020

kbhawkey Jul 16, 2020

kbhawkey commented Jul 15, 2020

kbhawkey commented Jul 16, 2020

kbhawkey commented Jul 16, 2020

k8s-ci-robot commented Jul 16, 2020

kubeadm: component config updates in 1.19 #21663

kubeadm: component config updates in 1.19 #21663

Conversation

rosti commented Jun 11, 2020 • edited by sftim Loading

k8sio-netlify-preview-bot commented Jun 11, 2020 • edited Loading

savitharaghunathan commented Jun 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

neolit123 commented Jul 3, 2020 • edited Loading

fabriziopandini commented Jul 6, 2020

rosti commented Jul 13, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rosti commented Jul 13, 2020

sftim commented Jul 14, 2020

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sftim commented Jul 14, 2020

rosti commented Jul 15, 2020

fabriziopandini left a comment

Choose a reason for hiding this comment

kbhawkey commented Jul 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kbhawkey commented Jul 15, 2020

kbhawkey commented Jul 16, 2020

kbhawkey commented Jul 16, 2020

k8s-ci-robot commented Jul 16, 2020

rosti commented Jun 11, 2020 •

edited by sftim

Loading

k8sio-netlify-preview-bot commented Jun 11, 2020 •

edited

Loading

neolit123 commented Jul 3, 2020 •

edited

Loading