Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SCL reviewers/approvers from OWNERS_ALIASES #22474

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jul 11, 2020

For kubernetes/org#2013

To adequately leverage the SCL reviewers/approvers list in OWNERS_ALIASES,
we would need to add multiple OWNERS files in various directories.
Otherwise, the bot ends up suggesting reviewers and approvers from
other parent directories.

To avoid this complexity, remove the list of SCL reviewers/approvers
from OWNERS_ALIASES.

Original commit message below.


As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes lukemarsden from
the SIG Cluster reviewers/approvers list.

/assign @neolit123
SCL lead

cc @mrbobbytables @lukemarsden

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2020
@k8s-ci-robot k8s-ci-robot requested review from jimangel and sftim July 11, 2020 14:55
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 11, 2020
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think these owner aliases are serving their purpose properly at k/website.

the approver list is not something that is used because the only approvers in this repo are sig-docs owners.
none of the listed reviewers of SIG CL are active in reviewing PRs in this repository.

my vote goes for removing these owner aliases.

@neolit123
Copy link
Member

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 11, 2020
@netlify
Copy link

netlify bot commented Jul 11, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 4e3cf9f

https://deploy-preview-22474--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jul 11, 2020

Would SIG Cluster Lifecycle like to nominate a new set of reviewers for the relevant sections?

I'm also fine with removal.

@neolit123
Copy link
Member

i don't think the bots will pick people from the SIG CL list, unless we add OWNERS files in the appropriate locations.

as seen in some PRs against SIG CL maintained docs:
#22150
#21663
#22083
#22070

the bots pick different reviewers from a potentially parent OWNERS file.
which creates a question mark for the existing of the SIG CL owner alias in its current state.

also looking at https://github.com/kubernetes/website/blob/9e87d15493c2606feba44fa322a3baa0e51c327e/OWNERS_ALIASES
SIG CL is the only non-sig-docs alias, so +1 for removal.

To adequately leverage the SCL reviewers/approvers list in OWNERS_ALIASES,
we would need to add multiple OWNERS files in various directories.
Otherwise, the bot ends up suggesting reviewers and approvers from
other parent directories.

To avoid this complexity, simply remove the list of SCL reviewers/approvers
from OWNERS_ALIASES.
@nikhita nikhita force-pushed the cleanup-owners-scl branch from 9e87d15 to 4e3cf9f Compare July 12, 2020 03:16
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2020
@nikhita nikhita changed the title Remove inactive members from SCL reviewers/approvers Remove SCL reviewers/approvers from OWNERS_ALIASES Jul 12, 2020
@nikhita
Copy link
Member Author

nikhita commented Jul 12, 2020

Done ✔️

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks @nikhita

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2020
@nikhita
Copy link
Member Author

nikhita commented Jul 14, 2020

/assign @sftim
for approval

@nikhita
Copy link
Member Author

nikhita commented Jul 16, 2020

@sftim / @zacharysarah -- can any of you approve? 🙏

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit c1de6aa into kubernetes:master Jul 16, 2020
@nikhita nikhita deleted the cleanup-owners-scl branch July 16, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants