-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SCL reviewers/approvers from OWNERS_ALIASES #22474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think these owner aliases are serving their purpose properly at k/website.
the approver list is not something that is used because the only approvers in this repo are sig-docs owners.
none of the listed reviewers of SIG CL are active in reviewing PRs in this repository.
my vote goes for removing these owner aliases.
/sig cluster-lifecycle |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 4e3cf9f https://deploy-preview-22474--kubernetes-io-master-staging.netlify.app |
Would SIG Cluster Lifecycle like to nominate a new set of reviewers for the relevant sections? I'm also fine with removal. |
i don't think the bots will pick people from the SIG CL list, unless we add OWNERS files in the appropriate locations. as seen in some PRs against SIG CL maintained docs: the bots pick different reviewers from a potentially parent OWNERS file. also looking at https://github.com/kubernetes/website/blob/9e87d15493c2606feba44fa322a3baa0e51c327e/OWNERS_ALIASES |
To adequately leverage the SCL reviewers/approvers list in OWNERS_ALIASES, we would need to add multiple OWNERS files in various directories. Otherwise, the bot ends up suggesting reviewers and approvers from other parent directories. To avoid this complexity, simply remove the list of SCL reviewers/approvers from OWNERS_ALIASES.
9e87d15
to
4e3cf9f
Compare
Done ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @nikhita
/assign @sftim |
@sftim / @zacharysarah -- can any of you approve? 🙏 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For kubernetes/org#2013
To adequately leverage the SCL reviewers/approvers list in OWNERS_ALIASES,
we would need to add multiple OWNERS files in various directories.
Otherwise, the bot ends up suggesting reviewers and approvers from
other parent directories.
To avoid this complexity, remove the list of SCL reviewers/approvers
from OWNERS_ALIASES.
Original commit message below.
As a part of cleaning up inactive members (who haven't been active since
the release of v1.11) from OWNERS, this commit removes lukemarsden from
the SIG Cluster reviewers/approvers list.
/assign @neolit123
SCL lead
cc @mrbobbytables @lukemarsden