Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of broken links to translated docs #22105

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jun 27, 2020

Closes #22102

This PR contains the following translated docs which has the broken links.

  • content/ko/docs/concepts/architecture/nodes.md
  • content/ko/docs/concepts/cluster-administration/addons.md
  • content/ko/docs/concepts/cluster-administration/cluster-administration-overview.md
  • content/ko/docs/concepts/configuration/overview.md
  • content/ko/docs/concepts/containers/images.md
  • content/ko/docs/concepts/containers/runtime-class.md
  • content/ko/docs/concepts/extend-kubernetes/api-extension/custom-resources.md
  • content/ko/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
  • content/ko/docs/concepts/extend-kubernetes/extend-cluster.md
  • content/ko/docs/concepts/overview/components.md
  • content/ko/docs/concepts/overview/working-with-objects/field-selectors.md
  • content/ko/docs/concepts/policy/limit-range.md
  • content/ko/docs/concepts/policy/pod-security-policy.md
  • content/ko/docs/concepts/policy/resource-quotas.md
  • content/ko/docs/concepts/services-networking/connect-applications-service.md
  • content/ko/docs/concepts/services-networking/endpoint-slices.md
  • content/ko/docs/concepts/services-networking/ingress.md
  • content/ko/docs/concepts/services-networking/service.md
  • content/ko/docs/concepts/storage/persistent-volumes.md
  • content/ko/docs/concepts/storage/storage-classes.md
  • content/ko/docs/concepts/storage/volume-snapshots.md
  • content/ko/docs/concepts/storage/volumes.md
  • content/ko/docs/concepts/workloads/controllers/daemonset.md
  • content/ko/docs/concepts/workloads/controllers/deployment.md
  • content/ko/docs/concepts/workloads/controllers/replicaset.md
  • content/ko/docs/concepts/workloads/controllers/replicationcontroller.md
  • content/ko/docs/contribute/_index.md
  • content/ko/docs/contribute/new-content/open-a-pr.md
  • content/ko/docs/contribute/participating.md
  • content/ko/docs/contribute/review/reviewing-prs.md
  • content/ko/docs/contribute/style/write-new-topic.md
  • content/ko/docs/reference/glossary/cni.md
  • content/ko/docs/reference/glossary/device-plugin.md
  • content/ko/docs/reference/glossary/minikube.md
  • content/ko/docs/reference/kubectl/cheatsheet.md
  • content/ko/docs/reference/tools.md
  • content/ko/docs/reference/using-api/api-overview.md
  • content/ko/docs/setup/_index.md
  • content/ko/docs/setup/best-practices/multiple-zones.md
  • content/ko/docs/setup/production-environment/tools/kops.md
  • content/ko/docs/tasks/_index.md
  • content/ko/docs/tasks/access-application-cluster/communicate-containers-same-pod-shared-volume.md
  • content/ko/docs/tasks/access-application-cluster/web-ui-dashboard.md
  • content/ko/docs/tasks/administer-cluster/change-default-storage-class.md
  • content/ko/docs/tasks/administer-cluster/cluster-management.md
  • content/ko/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md
  • content/ko/docs/tasks/administer-cluster/manage-resources/cpu-constraint-namespace.md
  • content/ko/docs/tasks/administer-cluster/manage-resources/cpu-default-namespace.md
  • content/ko/docs/tasks/administer-cluster/manage-resources/memory-constraint-namespace.md
  • content/ko/docs/tasks/administer-cluster/manage-resources/memory-default-namespace.md
  • content/ko/docs/tasks/administer-cluster/manage-resources/quota-memory-cpu-namespace.md
  • content/ko/docs/tasks/administer-cluster/manage-resources/quota-pod-namespace.md
  • content/ko/docs/tasks/administer-cluster/network-policy-provider/romana-network-policy.md
  • content/ko/docs/tasks/configure-pod-container/assign-memory-resource.md
  • content/ko/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity.md
  • content/ko/docs/tasks/configure-pod-container/configure-pod-initialization.md
  • content/ko/docs/tasks/configure-pod-container/static-pod.md
  • content/ko/docs/tasks/debug-application-cluster/determine-reason-pod-failure.md
  • content/ko/docs/tasks/debug-application-cluster/resource-metrics-pipeline.md
  • content/ko/docs/tasks/inject-data-application/define-command-argument-container.md
  • content/ko/docs/tasks/manage-gpus/scheduling-gpus.md
  • content/ko/docs/tasks/manage-kubernetes-objects/declarative-config.md
  • content/ko/docs/tasks/manage-kubernetes-objects/imperative-command.md
  • content/ko/docs/tasks/manage-kubernetes-objects/imperative-config.md
  • content/ko/docs/tasks/manage-kubernetes-objects/kustomization.md
  • content/ko/docs/tasks/network/validate-dual-stack.md
  • content/ko/docs/tasks/run-application/delete-stateful-set.md
  • content/ko/docs/tasks/run-application/horizontal-pod-autoscale.md
  • content/ko/docs/tasks/tools/install-minikube.md
  • content/ko/docs/tutorials/stateful-application/zookeeper.md
  • content/ko/docs/tutorials/stateless-application/expose-external-ip-address.md
  • content/ko/docs/tutorials/stateless-application/guestbook-logs-metrics-with-elk.md
  • content/ko/docs/tutorials/stateless-application/guestbook.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 27, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 27, 2020
@netlify
Copy link

netlify bot commented Jun 27, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d6cf45e

https://deploy-preview-22105--kubernetes-io-master-staging.netlify.app

@gochist
Copy link
Member

gochist commented Jun 29, 2020

/assign

@gochist
Copy link
Member

gochist commented Jun 30, 2020

@pjhwa 감사합니다! 혹시 작업을 위한 자동화 툴이나 스크립트를 사용하셨나요?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2020
@gochist
Copy link
Member

gochist commented Jun 30, 2020

제가 저자와 같은 회사 소속이라 다른 승인자께서 승인해주시면 좋겠습니다.

/unassign
/assign @ianychoi

@k8s-ci-robot k8s-ci-robot assigned ianychoi and unassigned gochist Jun 30, 2020
@pjhwa
Copy link
Contributor Author

pjhwa commented Jun 30, 2020

@pjhwa 감사합니다! 혹시 작업을 위한 자동화 툴이나 스크립트를 사용하셨나요?

그냥 다 뒤지는 허접한 스크립트로 돌렸습니다. ^^; 뭐 수작업이 반이지만요. 찾아주는게 어딘가 하고 돌렸습니다. ㅎㅎ

@gochist
Copy link
Member

gochist commented Jul 3, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@gochist
Copy link
Member

gochist commented Jul 3, 2020

Held for the same reason with #22270 (comment)

@pjhwa pjhwa changed the base branch from master to dev-1.18-ko.7 July 3, 2020 09:36
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 3, 2020

링크 수정은 Bug fix라 생각하여 master를 타겟으로 했었습니다. 브랜치를 현재 작업 브랜치로 변경하겠습니다.

@netlify
Copy link

netlify bot commented Jul 3, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit 3e36871

https://deploy-preview-22105--k8s-dev-ko.netlify.app

@gochist
Copy link
Member

gochist commented Jul 3, 2020

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@gochist
Copy link
Member

gochist commented Jul 3, 2020

/unassign

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 6, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2020
@gochist
Copy link
Member

gochist commented Jul 7, 2020

@pjhwa 감사합니다. 내용은 LGTM입니다. 하나의 커밋으로 squash 가능하실까요?

@gochist
Copy link
Member

gochist commented Jul 7, 2020

git remote의 origin이 pjhwa님의 fork, upstream이 kubernetes 조직의 저장소로 설정되어 있다면(git remote -v로 확인),

$ git remote -v
origin	git@github.com:pjhwa/website (fetch)
origin	git@github.com:pjhwa/website (push)
upstream	git@github.com:kubernetes/website (fetch)
upstream	git@github.com:kubernetes/website (push)

다음과 같이 하나의 커밋으로 squash 하실 수 있습니다.

git fetch upstream dev-1.18-ko.7
git fetch origin fix-22102
git checkout upstream/dev-1.18-ko.7 -b fix-22102-squash
git merge --squash origin/fix-22102
git commit
git push --force origin fix-22102-squash:fix-22102

commit 3415fb0
Merge: 92d9a08 8dd8eb0
Author: Jerry Park <jaehwa@gmail.com>
Date:   Tue Jul 7 05:30:53 2020 +0900

    Merge branch 'dev-1.18-ko.7' into fix-22102

commit 92d9a08
Merge: 19e72c0 8ba2941
Author: Jerry Park <jaehwa@gmail.com>
Date:   Fri Jul 3 20:51:26 2020 +0900

    Merge branch 'dev-1.18-ko.7' into fix-22102

commit 19e72c0
Merge: d6cf45e dfbde8c
Author: Jerry Park <jaehwa@gmail.com>
Date:   Fri Jul 3 18:46:15 2020 +0900

    Merge branch 'dev-1.18-ko.7' into fix-22102

commit d6cf45e
Author: Jerry Park <jaehwa@gmail.com>
Date:   Sat Jun 27 19:16:39 2020 +0900

    Fix issue of broken links to translated docs
@pjhwa
Copy link
Contributor Author

pjhwa commented Jul 7, 2020

@gochist 자세한 설명 감사합니다! 스쿼시 작업 완료했습니다.

@gochist
Copy link
Member

gochist commented Jul 7, 2020

/lgtm
@ianychoi PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@gochist
Copy link
Member

gochist commented Jul 7, 2020

/unassign

@ianychoi
Copy link
Contributor

ianychoi commented Jul 7, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ianychoi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit a5a61b0 into kubernetes:dev-1.18-ko.7 Jul 7, 2020
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)

Co-authored-by: Jerry Park <jaehwa@gmail.com>
Co-authored-by: woopyoung <ywp041@gmail.com>
Co-authored-by: coolguyhong <podolsmith@naver.com>
Co-authored-by: PyungHo Yoon <learder@gmail.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: jmyung <jesang.myung@gmail.com>
Co-authored-by: Ian Y. Choi <ianyrchoi@gmail.com>
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <jaehwa@gmail.com>
Co-authored-by: woopyoung <ywp041@gmail.com>
Co-authored-by: coolguyhong <podolsmith@naver.com>
Co-authored-by: PyungHo Yoon <learder@gmail.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: jmyung <jesang.myung@gmail.com>
Co-authored-by: Ian Y. Choi <ianyrchoi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue of broken links to translated docs
4 participants