Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with 'Linux' and 'Windows' notation in Korean docs #22362

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

pjhwa
Copy link
Contributor

@pjhwa pjhwa commented Jul 5, 2020

Closes #22360

This PR replaces 'Linux' and 'Windows' with '리눅스' and '윈도우' in the following pages:

  1. 'Linux':
  • concepts/configuration/organize-cluster-access-kubeconfig.md
  • concepts/services-networking/service.md
  • concepts/workloads/pods/pod.md
  • concepts/workloads/pods/init-containers.md
  • concepts/policy/pod-security-policy.md
  • concepts/cluster-administration/networking.md
  • reference/glossary/docker.md
  • setup/production-environment/tools/kops.md
  • setup/production-environment/container-runtimes.md
  • setup/learning-environment/minikube.md
  • tasks/tools/install-minikube.md
  • tasks/tools/install-kubectl.md
  • tasks/access-application-cluster/configure-access-multiple-clusters.md
  1. 'Windows':
  • concepts/configuration/organize-cluster-access-kubeconfig.md
  • concepts/services-networking/service.md
  • setup/production-environment/windows/user-guide-windows-containers.md
  • setup/learning-environment/minikube.md
  • tasks/tools/install-minikube.md
  • tasks/tools/install-kubectl.md
  • tasks/administer-cluster/kubeadm/adding-windows-nodes.md
  • tasks/administer-cluster/kubeadm/upgrading-windows-nodes.md
  • tasks/access-application-cluster/configure-access-multiple-clusters.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 5, 2020
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 5, 2020
@netlify
Copy link

netlify bot commented Jul 5, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit dbf48ae

https://deploy-preview-22362--k8s-dev-ko.netlify.app

@netlify
Copy link

netlify bot commented Jul 5, 2020

Deploy preview for k8s-dev-ko ready!

Built with commit b0bb48b

https://deploy-preview-22362--k8s-dev-ko.netlify.app

@gochist
Copy link
Member

gochist commented Jul 6, 2020

@pjhwa 감사합니다!
/kind bug
/lgtm

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2020
@gochist
Copy link
Member

gochist commented Jul 6, 2020

저자과 제가 같은 회사 소속이므로 되도록이면 다른 승인자께서 승인해주셨으면 합니다.
/unassign
/assign @seokho-son

@k8s-ci-robot k8s-ci-robot assigned seokho-son and unassigned gochist Jul 6, 2020
@seokho-son
Copy link
Member

감사합니다.. ^^
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8dd8eb0 into kubernetes:dev-1.18-ko.7 Jul 6, 2020
* Windows 컨테이너를 호스팅하는 Windows 노드를 구성하려면
[Windows Server 2019 라이선스](https://www.microsoft.com/en-us/cloud-platform/windows-server-pricing) 이상이 필요하다.
* 윈도우 컨테이너를 호스팅하는 윈도우 노드를 구성하려면
[윈도우 서버 2019 라이선스](https://www.microsoft.com/en-us/cloud-platform/windows-server-pricing) 이상이 필요하다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The product name is Windows Server 2019, according to the page linked to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim I agree. And I think it should be link to Korean page. I'll update on the next branch.

gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)

Co-authored-by: Jerry Park <jaehwa@gmail.com>
Co-authored-by: woopyoung <ywp041@gmail.com>
Co-authored-by: coolguyhong <podolsmith@naver.com>
Co-authored-by: PyungHo Yoon <learder@gmail.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: jmyung <jesang.myung@gmail.com>
Co-authored-by: Ian Y. Choi <ianyrchoi@gmail.com>
gochist added a commit that referenced this pull request Jul 10, 2020
- Translate reference/command-line-tools-reference/feature-gates.md int… (#22240)
- Fix issue of broken links to translated docs (#22105)
- Fix issue of document link in some ko documents (#22379)
- Translate tasks/administer-cluster/access-cluster-services.md into Ko… (#21776)
- Fix issue with 'Linux' and 'Windows' notation in Korean docs (#22362)
- Fix issue of broken links to translated docs #2 (#22270)
- Fix issue with k8s.io/ko/docs/concepts/overview/kubernetes-api.md (#22261)
- Fix issue with k8s.io/ko/docs/concepts/overview/working-with-objects/ (#22263)
- Fix incorrect notation of 'directory' into Korean (#22155)
- Fix issue with k8s.io/ko/docs/concepts/overview/components.md (#22232)
- Update outdated files in dev-1.18-ko.7 (#22128)
- Modify spacing term ReplicaSet in Korean (#22148)
- Translate tasks/administer-cluster/extended-resource-node.md into Korean (#21849)
- Translate tasks/administer-cluster/access-cluster-api.md into Korean (#21730)

Co-authored-by: Jerry Park <jaehwa@gmail.com>
Co-authored-by: woopyoung <ywp041@gmail.com>
Co-authored-by: coolguyhong <podolsmith@naver.com>
Co-authored-by: PyungHo Yoon <learder@gmail.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: jmyung <jesang.myung@gmail.com>
Co-authored-by: Ian Y. Choi <ianyrchoi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants