Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID translation for static pod #22344

Merged
merged 2 commits into from
Aug 14, 2020
Merged

ID translation for static pod #22344

merged 2 commits into from
Aug 14, 2020

Conversation

wahyuoi
Copy link
Contributor

@wahyuoi wahyuoi commented Jul 4, 2020

address #22296

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from irvifa and phanama July 4, 2020 16:16
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 4, 2020
@netlify
Copy link

netlify bot commented Jul 4, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d1a1db5

https://deploy-preview-22344--kubernetes-io-master-staging.netlify.app

@girikuncoro girikuncoro mentioned this pull request Jul 7, 2020
Closed
51 tasks
ariscahyadi
ariscahyadi reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@ariscahyadi ariscahyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wahyuoi ... I just make a few comments about this.
Please feel free to address it or wait for other reviewers to comment!

content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
girikuncoro
girikuncoro requested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for localizing this @wahyuoi hope you learn how static Pod works in kubernetes. I have left few comments, let me know what you think!

content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
ariscahyadi
ariscahyadi reviewed Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ariscahyadi ariscahyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wahyuoi ... it looks good!
Only two nits:

  • Halaman --> Laman
  • /docs/tasks/administer-cluster/kubelet-config-file --> link to ID docs.

@wahyuoi
Copy link
Contributor Author

wahyuoi commented Jul 10, 2020

thanks @ariscahyadi
https://kubernetes.io/id/docs/tasks/administer-cluster/kubelet-config-file is not available, so I'll use the EN page for now

Halaman -> Laman done

phanama
phanama reviewed Jul 18, 2020
View reviewed changes
Copy link
Contributor

@phanama phanama left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some additional reviews for clarity of wordings, including "kontainer" referring to the non-api-object. @wahyuoi

content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things you might want to change, and one comment.

content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Show resolved Hide resolved
content/id/docs/tasks/configure-pod-container/static-pod.md Outdated Show resolved Hide resolved
@wahyuoi @phanama @sftim
Apply suggestions from code review
d1a1db5 
Co-authored-by: Yudi A Phanama <11147376+phanama@users.noreply.github.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@wahyuoi wahyuoi requested a review from phanama August 7, 2020 08:21
ariscahyadi
ariscahyadi reviewed Aug 14, 2020
View reviewed changes
Copy link
Contributor

@ariscahyadi ariscahyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to go!

@ariscahyadi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2020
@irvifa
Copy link
Member

irvifa commented Aug 14, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit fb6364d into kubernetes:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@ariscahyadi ariscahyadi ariscahyadi left review comments

@irvifa irvifa Awaiting requested review from irvifa

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

@phanama phanama Awaiting requested review from phanama

Assignees

@ariscahyadi ariscahyadi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wahyuoi @ariscahyadi @irvifa @k8s-ci-robot @girikuncoro @phanama @sftim