Field Validation API Concepts #32357

kevindelgado · 2022-03-18T20:48:37Z

netlify · 2022-03-18T20:48:59Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`2dc5f25`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62e61a099c8ac10008e9eca1

mehabhalodiya · 2022-03-19T04:21:28Z

/assign

sftim · 2022-03-21T17:55:25Z

/retitle [WIP] placeholder for field validation beta docs

tengqm · 2022-03-30T13:39:19Z

@kevindelgado I have proposed something in #32592, for the same topic. Would you like review #32592 and see if that covers all changes needed?

kevindelgado · 2022-03-30T16:58:00Z

@kevindelgado I have proposed something in #32592, for the same topic. Would you like review #32592 and see if that covers all changes needed?

Thanks for the PR. We can can go ahead and merge that. I think the one other piece of documentation we want, is something for the api-concepts page similar to what we have for --dry-run. I will use this PR to do that, and should have something up for review EOD today.

kevindelgado · 2022-03-30T20:09:06Z

/assign @apelisse

content/en/docs/reference/using-api/api-concepts.md

apelisse · 2022-04-01T15:57:35Z

Technical LGTM

content/en/docs/reference/using-api/api-concepts.md

sftim

Remember to remove placeholder.md from this PR.

kevindelgado · 2022-07-24T06:44:47Z

/lgtm

k8s-ci-robot · 2022-07-24T06:44:48Z

@kevindelgado: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevindelgado · 2022-07-24T06:45:29Z

feedback/nits addressed, please tag it again @sftim

sftim

One more thought. Assume that some folk don't read the “Setting the field validation level” text because they know it's not enabled for their cluster.

When someone supplies duplicate values and these are eventually accepted, it would be nice to clearly explain which value wins. For JSON, it's the last duplicate - right?

sftim · 2022-07-25T09:29:36Z

content/en/docs/reference/using-api/api-concepts.md

@@ -661,6 +661,76 @@ of single-resource API requests, then aggregates the responses if needed.
 By contrast, the Kubernetes API verbs **list** and **watch** allow getting multiple
 resources, and **deletecollection** allows deleting multiple resources.

+## Field validation
+
+  {{< feature-state for_k8s_version="v1.25" state="beta" >}}


On reflection, I think this should be for the heading “Setting the field validation level” and not for the 2nd-level field validation heading. Even with the feature gate off, there's some (actually quite a lot) of field validation going on.

content/en/docs/reference/using-api/api-concepts.md

sftim · 2022-07-25T09:36:57Z

content/en/docs/reference/using-api/api-concepts.md

+  {{< feature-state for_k8s_version="v1.25" state="beta" >}}
+
+By default, the API server drops fields that it does not recognize
+from an object it receives.


Suggested change

from an object it receives.

from an input that it receives (for example, the JSON body of a `PUT` request).

sftim · 2022-07-25T09:38:16Z

content/en/docs/reference/using-api/api-concepts.md

+By default, the API server drops fields that it does not recognize
+from an object it receives.
+
+The two situations where this will occur are:


(nit)

Suggested change

The two situations where this will occur are:

There are two situations where the API server drops fields that you supplied in an HTTP request.

These situations are:

content/en/docs/reference/using-api/api-concepts.md

kevindelgado

all feedback addressed, ptal @sftim

content/en/docs/reference/using-api/api-concepts.md

kevindelgado · 2022-07-28T05:18:48Z

content/en/docs/reference/using-api/api-concepts.md

@@ -661,6 +661,76 @@ of single-resource API requests, then aggregates the responses if needed.
 By contrast, the Kubernetes API verbs **list** and **watch** allow getting multiple
 resources, and **deletecollection** allows deleting multiple resources.

+## Field validation
+
+  {{< feature-state for_k8s_version="v1.25" state="beta" >}}


kevindelgado · 2022-07-28T05:19:46Z

content/en/docs/reference/using-api/api-concepts.md

+  {{< feature-state for_k8s_version="v1.25" state="beta" >}}
+
+By default, the API server drops fields that it does not recognize
+from an object it receives.


kevindelgado · 2022-07-28T05:21:03Z

content/en/docs/reference/using-api/api-concepts.md

+By default, the API server drops fields that it does not recognize
+from an object it receives.
+
+The two situations where this will occur are:


content/en/docs/reference/using-api/api-concepts.md

kevindelgado · 2022-08-01T04:40:32Z

Build passes now, ptal @sftim

reylejano · 2022-08-04T00:09:14Z

/assign @didicodes
/cc @kcmartin

sftim · 2022-08-08T17:14:17Z

@kevindelgado you set a hold on this PR in #32357 (comment)
Is that still needed?

apelisse · 2022-08-08T17:25:15Z

/unhold

Not needed anymore. Kevin is out for a while.

reylejano · 2022-08-16T02:22:55Z

/lgtm

k8s-ci-robot · 2022-08-16T02:23:13Z

LGTM label has been added.

Git tree hash: b3400bdc27af9d47c37a3535e782c650249c0e63

k8s-ci-robot added this to the 1.24 milestone Mar 18, 2022

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2022

kevindelgado mentioned this pull request Mar 18, 2022

Server Side Unknown Field Validation kubernetes/enhancements#2885

Closed

26 tasks

k8s-ci-robot requested review from rajeshdeshpande02 and tengqm March 18, 2022 20:49

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 18, 2022

k8s-ci-robot assigned mehabhalodiya Mar 19, 2022

k8s-ci-robot changed the title ~~placeholder for field validation beta docs~~ [WIP] placeholder for field validation beta docs Mar 21, 2022

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022

mehabhalodiya mentioned this pull request Mar 29, 2022

Graduate ServerSideFieldValidation to Beta #32592

Closed

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2022

k8s-ci-robot assigned apelisse Mar 30, 2022

k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 30, 2022

kevindelgado changed the title ~~[WIP] placeholder for field validation beta docs~~ Field Validation API Concepts Mar 30, 2022

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022

tengqm reviewed Mar 31, 2022

View reviewed changes

sftim reviewed Apr 1, 2022

View reviewed changes

content/en/docs/reference/using-api/api-concepts.md Outdated Show resolved Hide resolved

sftim reviewed Apr 1, 2022

View reviewed changes

content/en/docs/reference/using-api/api-concepts.md Outdated Show resolved Hide resolved

sftim previously requested changes Apr 1, 2022

View reviewed changes

kevindelgado force-pushed the ss-field-validation-beta branch from 55d2b63 to a760f33 Compare April 1, 2022 18:40

kevindelgado requested a review from apelisse April 1, 2022 18:41

k8s-ci-robot requested review from mehabhalodiya and sftim July 24, 2022 06:18

kevindelgado force-pushed the ss-field-validation-beta branch from 2fec366 to 1d4accf Compare July 24, 2022 06:41

sftim reviewed Jul 25, 2022

View reviewed changes

kevindelgado force-pushed the ss-field-validation-beta branch from 1d4accf to 4584fd5 Compare July 28, 2022 05:24

kevindelgado commented Jul 28, 2022

View reviewed changes

kevindelgado requested a review from sftim July 28, 2022 05:24

Add Server Side Field Validation to API Concepts

2dc5f25

kevindelgado force-pushed the ss-field-validation-beta branch from 4584fd5 to 2dc5f25 Compare July 31, 2022 05:58

divya-mohan0209 added this to the 1.25 milestone Jul 31, 2022

k8s-ci-robot assigned didicodes Aug 4, 2022

k8s-ci-robot requested a review from kcmartin August 4, 2022 00:09

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2022

k8s-ci-robot assigned reylejano Aug 16, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022

k8s-ci-robot merged commit fc237ad into kubernetes:dev-1.25 Aug 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Field Validation API Concepts #32357

Field Validation API Concepts #32357

kevindelgado commented Mar 18, 2022

netlify bot commented Mar 18, 2022 •

edited

Loading

mehabhalodiya commented Mar 19, 2022

sftim commented Mar 21, 2022

tengqm commented Mar 30, 2022

kevindelgado commented Mar 30, 2022 •

edited

Loading

kevindelgado commented Mar 30, 2022

apelisse commented Apr 1, 2022

sftim left a comment

kevindelgado commented Jul 24, 2022

k8s-ci-robot commented Jul 24, 2022

kevindelgado commented Jul 24, 2022

sftim left a comment

sftim Jul 25, 2022

kevindelgado Jul 28, 2022

sftim Jul 25, 2022

kevindelgado Jul 28, 2022

sftim Jul 25, 2022

kevindelgado Jul 28, 2022

kevindelgado left a comment

kevindelgado Jul 28, 2022

kevindelgado Jul 28, 2022

kevindelgado Jul 28, 2022

kevindelgado commented Aug 1, 2022

reylejano commented Aug 4, 2022

sftim commented Aug 8, 2022

apelisse commented Aug 8, 2022

reylejano commented Aug 16, 2022

k8s-ci-robot commented Aug 16, 2022

	from an object it receives.
	from an input that it receives (for example, the JSON body of a `PUT` request).

	The two situations where this will occur are:
	There are two situations where the API server drops fields that you supplied in an HTTP request.
	These situations are:

Field Validation API Concepts #32357

Field Validation API Concepts #32357

Conversation

kevindelgado commented Mar 18, 2022

netlify bot commented Mar 18, 2022 • edited Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

mehabhalodiya commented Mar 19, 2022

sftim commented Mar 21, 2022

tengqm commented Mar 30, 2022

kevindelgado commented Mar 30, 2022 • edited Loading

kevindelgado commented Mar 30, 2022

apelisse commented Apr 1, 2022

sftim left a comment

Choose a reason for hiding this comment

kevindelgado commented Jul 24, 2022

k8s-ci-robot commented Jul 24, 2022

kevindelgado commented Jul 24, 2022

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevindelgado left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevindelgado commented Aug 1, 2022

reylejano commented Aug 4, 2022

sftim commented Aug 8, 2022

apelisse commented Aug 8, 2022

reylejano commented Aug 16, 2022

k8s-ci-robot commented Aug 16, 2022

netlify bot commented Mar 18, 2022 •

edited

Loading

kevindelgado commented Mar 30, 2022 •

edited

Loading