Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate ServerSideFieldValidation to Beta #32592

Closed
wants to merge 1 commit into from
Closed

Graduate ServerSideFieldValidation to Beta #32592

wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 29, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 58bec2d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624c16fc8f54270008a38def

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from tengqm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 29, 2022
@mehabhalodiya
Copy link
Contributor

mehabhalodiya commented Mar 29, 2022 •
edited
Loading

@tengqm I see #32357 is also opened up for the same purpose but @kevindelgado hasn't made any changes there.

Also, you have made #32593 with almost the same changes.
This PR has more changes as compared to any other.

So, I would like to keep this PR open and consider closing #32357 and #32593. Please correct me if I am wrong, thanks!

@tengqm
Copy link
Contributor Author

tengqm commented Mar 30, 2022

@mehabhalodiya

@mehabhalodiya
Copy link
Contributor

Thanks for clearing. I missed noticing that! Apologize!
@tengqm But what about closing #32357?

@tengqm tengqm mentioned this pull request Mar 30, 2022
Merged
@kevindelgado
Copy link
Contributor

/lgtm

See note on #32357, we can merge this one and I'll use that one to add an update to the api-concepts page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 481543eaa375c0a259761433ad2d7a153f7fbc78

@tengqm tengqm force-pushed the server-side-field-validation branch from 08946eb to 8276768 Compare March 31, 2022 00:15
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2022
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@tengqm
Copy link
Contributor Author

tengqm commented Mar 31, 2022

/hold
I'd like the feature gate page pointing to the docs to be added by @kevindelgado
Waiting for #32357 to be merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 31, 2022
@tengqm tengqm force-pushed the server-side-field-validation branch from 8276768 to 58bec2d Compare April 5, 2022 10:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2022
@reylejano
Copy link
Member

Looks like ServerSideFieldValidation to Beta will not be in v1.24 and will target v1.25
See #32357 (comment)
/close

@k8s-ci-robot
Copy link
Contributor

@reylejano: Closed this PR.

In response to this:

Looks like ServerSideFieldValidation to Beta will not be in v1.24 and will target v1.25
See #32357 (comment)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm tengqm deleted the server-side-field-validation branch April 6, 2022 00:54
@mehabhalodiya
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.24 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daminisatya daminisatya Awaiting requested review from daminisatya

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@kevindelgado kevindelgado Awaiting requested review from kevindelgado

Assignees

@kevindelgado kevindelgado

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tengqm @k8s-ci-robot @mehabhalodiya @kevindelgado @reylejano