-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promoting feature CustomResourceValidationExpressions to beta #35029
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
/retitle [WIP] Placeholder pr for promoting feature CustomResourceValidationExpressions to beta This is a placeholder and is not ready for review. |
This PR is for enhancement kubernetes/enhancements#2876 which is being tracked for the 1.25 release |
10abf5b
to
44ab7f2
Compare
/cc @jpbetz Would you have time to take a look? Thank you |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @cici37
For graduation to beta, we'd really like to see documentation that follows the usual docs layout.
Please propose an update so that https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/ includes a clear mention of validation rules, along with brief details of how to disable them.
You could adapt the existing task content. I also recommend adding a task page that explains how to define validation and transition rules for a custom API - but it's OK for that to land in main any time before the v1.26 release.
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
Thank you for reviewing! I have added the info on how to turn off the feature. Would you mind to take a look when have time? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'd prefer a couple more tweaks (see inline feedback).
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions.md
Outdated
Show resolved
Hide resolved
LGTM label has been added. Git tree hash: f9c27b5c4ac059fa2c7fbaab1a4f77576cc57aa2
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reapplying lgtm from this comment |
LGTM label has been added. Git tree hash: 14fe02c1cd3a60b940c55bc7743e7db6bc3b487f
|
Relevant to #35991 Ideally: we'd have got the docs sorted ahead of the beta; we should definitely instead get those updated on main well ahead of this feature being proposed for stabilization. |
The feature has been promoted to beta in Kubernetes 1.25. Here is the doc update.
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/2876-crd-validation-expression-language/README.md