Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting feature CustomResourceValidationExpressions to beta #35029

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Jul 14, 2022

@netlify
Copy link

netlify bot commented Jul 14, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit d6201fd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62fbba1c4510430008c2a7a3

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2022
@k8s-ci-robot k8s-ci-robot requested a review from deads2k July 14, 2022 20:29
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sttts July 14, 2022 20:29
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 14, 2022
@sftim
Copy link
Contributor

sftim commented Jul 14, 2022

/retitle [WIP] Placeholder pr for promoting feature CustomResourceValidationExpressions to beta

This is a placeholder and is not ready for review.

@k8s-ci-robot k8s-ci-robot changed the title Placeholder pr for promoting feature CustomResourceValidationExpressions to beta [WIP] Placeholder pr for promoting feature CustomResourceValidationExpressions to beta Jul 14, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2022
@reylejano
Copy link
Member

This PR is for enhancement kubernetes/enhancements#2876 which is being tracked for the 1.25 release
@cici37 , when this PR is ready for review, please remove [WIP] from the title
/milestone 1.25
/assign @didicodes
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kcmartin August 4, 2022 05:12
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2022
@cici37 cici37 changed the title [WIP] Placeholder pr for promoting feature CustomResourceValidationExpressions to beta Promoting feature CustomResourceValidationExpressions to beta Aug 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@cici37 cici37 force-pushed the celBeta branch 3 times, most recently from 10abf5b to 44ab7f2 Compare August 10, 2022 22:54
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2022
@cici37
Copy link
Contributor Author

cici37 commented Aug 10, 2022

/cc @jpbetz Would you have time to take a look? Thank you

@cici37
Copy link
Contributor Author

cici37 commented Aug 10, 2022

/retest

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @cici37

For graduation to beta, we'd really like to see documentation that follows the usual docs layout.

Please propose an update so that https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/ includes a clear mention of validation rules, along with brief details of how to disable them.

You could adapt the existing task content. I also recommend adding a task page that explains how to define validation and transition rules for a custom API - but it's OK for that to land in main any time before the v1.26 release.

@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 15, 2022
@cici37
Copy link
Contributor Author

cici37 commented Aug 15, 2022

Thanks for this PR Cici Huang

For graduation to beta, we'd really like to see documentation that follows the usual docs layout.

Please propose an update so that https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/ includes a clear mention of validation rules, along with brief details of how to disable them.

You could adapt the existing task content. I also recommend adding a task page that explains how to define validation and transition rules for a custom API - but it's OK for that to land in main any time before the v1.26 release.

Thank you for reviewing! I have added the info on how to turn off the feature. Would you mind to take a look when have time? Thank you

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'd prefer a couple more tweaks (see inline feedback).

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f9c27b5c4ac059fa2c7fbaab1a4f77576cc57aa2

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2022
@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@reylejano
Copy link
Member

Reapplying lgtm from this comment
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14fe02c1cd3a60b940c55bc7743e7db6bc3b487f

@k8s-ci-robot k8s-ci-robot merged commit 4b1b3ac into kubernetes:dev-1.25 Aug 16, 2022
@cici37 cici37 deleted the celBeta branch August 16, 2022 20:26
@sftim
Copy link
Contributor

sftim commented Aug 19, 2022

Relevant to #35991

Ideally: we'd have got the docs sorted ahead of the beta; we should definitely instead get those updated on main well ahead of this feature being proposed for stabilization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants