CRD Validation Expression Language

[jpbetz]

Enhancement Description

• One-line enhancement description (can be used as a release note): Expression language can be used to validate custom resources
• Kubernetes Enhancement Proposal: KEP-2876: CRD Validation Expression Language #2877
• Discussion Link: SIG API Machinery Agenda Item
• Primary contact (assignee): cici37, jpbetz
• Responsible SIGs: sig-api-machinery
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23, 1.24
  • Beta release target (x.y): 1.25
  • Stable release target (x.y): 1.29
• Alpha
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
    • Add wired off code for Validation rules for Custom Resource Definitions using the CEL expression language kubernetes#106234
    • Feature implementation: Validation rules for Custom Resource Definitions using the CEL expression language kubernetes#106051
  • Docs (k/website) update PR(s):
    • Add documentation for Validation Rules feature to Custom Resource Definitions task docs website#30626
• Beta
  • KEP (k/enhancements) update PR(s): KEP-2876: Promote CRD Validation Expression Language to Beta #3266
  • Code (k/k) update PR(s):
    • Promote feature CustomResourceValidationExpressions to beta kubernetes#111524
    • Add messageExpression field for CRD validation kubernetes#115969
  • Docs (k/website) update PR(s):
    • Promoting feature CustomResourceValidationExpressions to beta website#35029
    • Documentation for messageExpression update to KEP-2876 website#40019
• Bate in 1.28
  • KEP (k/enhancements) update PR(s): KEP-2876: Clear Graduation Criteria for CRD validation rules to stable #3948
  • Code (k/k) update PR(s): [KEP-2876]Add reason and fieldPath into CRD validation rules kubernetes#118041
  • Docs (k/website) update(s):
    • [KEP-2876] Placeholder doc PR for kep 2876 website#42043
    • Update doc for KEP 2876 website#42120
• Stable
  • KEP (k/enhancements) update PR(s): [KEP-2876]Promote CRD validation rule to stable #4159
  • Code (k/k) update PR(s): [KEP-2876] Promote CRD validation rule to GA kubernetes#121373
  • Docs (k/website) update(s): [KEP-2876] Document (GA) CEL validation for custom resources website#43441

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[mysunshine92]

/sig api-machinery

[kevindelgado]

Hi @jpbetz and @cici37! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo (PR Open).
• KEP status is marked as implementable
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria (Only has criteria for beta).
• KEP has a production readiness review that has been completed and merged into k/enhancements.

If you can, please add a test plan and alpha graduation criteria to the KEP and be sure the KEP PR merges by enhancements freeze :)

Thanks!

[kevindelgado]

/milestone 1.23
/stage alpha

[k8s-ci-robot]

@kevindelgado: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.23
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kevindelgado]

/milestone v1.23

[kevindelgado]

Hi @cici37

Ping! As a reminder your PR (#2877) needs to merge by EOD PST tomorrow September 9th to be included in the 1.23 Release. After that time you will need to request an exception.

Lmk if you need anything,
Kevin

[cici37]

@kevindelgado PR has been merged. Updated the checkbox. Thanks^^

[mehabhalodiya]

Hi @jpbetz 👋 1.23 Docs shadow here.

This enhancement is marked as 'Needs Docs' for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[kevindelgado]

Hi @cici37 and @jpbetz 👋

Checking in once more as we approach 1.23 code freeze at 6:00 pm PST on Tuesday, November 16.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
• Have a documentation placeholder PR open by Thursday, November 18.

As always, we are here to help should questions come up.

Thanks!!

[kikisdeliveryservice]

Related: #3039

[cici37]

@kevindelgado @mehabhalodiya
Thanks for the reminder. All PRs to k/k related with this enhancement have been merged and we have a documentation placeholder PR here. Updated the description.

[cici37]

I have updated the documentation PR to kubernetes/website#30626. Sorry for any inconvenient.

[deads2k]

related enhancement #3160

[hosseinsalahi]

Hello @jpbetz

v1.24 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd, 2022. This enhancement is targeting beta for v1.24, is this correct?

Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for this release
• KEP has a test plan section filled out.
• KEP has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

In the kep.yaml latest-milestone should point to the correct release.

The status of this enhancement is marked as at risk. Please update the merged kep.yaml to reflect the stage as current release cycle 1.24.
Thanks!

[apelisse]

cc @alexzielenski

[salehsedghpour]

Hello @cici37 & @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implemented for latest-milestone: 1.29.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to add/update the following:

• KEP readme using the latest template has been merged into the k/enhancements repo. Please check the graduation criteria and and production readiness review questionnaire.
• The kep.yaml file based on the recent changes

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[liggitt]

We don't mark KEPs as implemented until they actually land in the release

[cici37]

@salehsedghpour Thanks for the reply. It is tricky for the long existing KEP to adopt the latest template. I have raised the PR to adopt the latest PRR section. Please feel free to let me know if I missed anything else.
For KEP status, I currently have it marked as implementable which should be better reflecting the status.
And I have up-to-date graduation criteria in current KEP readme.

Thank you

[salehsedghpour]

@liggitt and @cici37, I'm sorry for the confusion. Yes, the status should be marked as implemented after the code PRs are merged.

And thank you for updating the PR. The only thing that is left, is the updated graduation criteria.

[liggitt]

The only thing that is left, is the updated graduation criteria.

can you clarify what you are looking for here? the merged KEP has GA graduation criteria

[salehsedghpour]

You're right it has. My main concern was that it has been added in 1.27, I thought that it should be updated at this point. If there is no need to update it, then this KEP can be considered as tracked for the enhancement freeze.

[cici37]

@salehsedghpour The graduation criteria has been updated before this release cycle begins so it is up to date. Thanks!

[taniaduggal]

Hey there @jpbetz ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

[jpbetz]

^ @cici37

I don't know exactly what's missing, but we've added some new fields recently and some CEL features are newly enabled by default in this release.

[cici37]

I will open a placeholder PR later. The newly added fields have already been added into the doc. We mainly have to update the feature status and cel changes.

[salehsedghpour]

Hey again @cici37 and @jpbetz 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• [KEP-2876] Promote CRD validation rule to GA kubernetes#121373

Please make sure to update the status in kep.yaml to implemented after all PRs are merged.

With this, the status of this KEP is at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[a-mccarthy]

Hi @cici37 @jpbetz, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

[salehsedghpour]

Hi @cici37 and @jpbetz,
As the following PR is now merged the status of this PR can now be marked with tracked for the code freeze.
kubernetes/kubernetes#121373

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP

[salehsedghpour]

Hi @cici37 , 👋 1.30 Enhancements lead here,
As it has graduated to Stable and the KEP status is still implementable, may you please update the status to implemented and close this issue once the update PR has merged?

[salehsedghpour]

/remove-label lead-opted-in

[salehsedghpour]

As this issue is GA now, it can be closed.