Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2876] Document (GA) CEL validation for custom resources #43441

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[KEP-2876] Document (GA) CEL validation for custom resources #43441

merged 1 commit into from
Nov 16, 2023

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Oct 11, 2023 •
edited
Loading

Document (GA) CEL validation for custom resources

@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Oct 11, 2023
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 16fb2e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6555522e5f648e0008e4bee5

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@cici37
Copy link
Contributor Author

cici37 commented Oct 11, 2023

/milestone 1.29
/sig api-machinery

@k8s-ci-robot
Copy link
Contributor

@cici37: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.29
/sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from roycaihw October 11, 2023 17:53
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sttts October 11, 2023 17:53
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 11, 2023
@cici37 cici37 mentioned this pull request Oct 11, 2023
Closed
21 tasks
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@sftim
Copy link
Contributor

sftim commented Oct 12, 2023

/retitle [WIP] [KEP-2876] Document (GA) CEL validation for custom resources

@k8s-ci-robot k8s-ci-robot changed the title [KEP-2876]Placeholder PR [WIP] [KEP-2876] Document (GA) CEL validation for custom resources Oct 12, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@katcosgrove
Copy link
Contributor

Hi, @cici37! Just dropping by to remind you that the deadline for docs PRs to be ready for review is tomorrow, November 14. Is there anything we can help you with to get this PR ready?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2023
@cici37 cici37 changed the title [WIP] [KEP-2876] Document (GA) CEL validation for custom resources [KEP-2876] Document (GA) CEL validation for custom resources Nov 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2023
@cici37
Copy link
Contributor Author

cici37 commented Nov 14, 2023

/unhold
It is ready to review. Thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@cici37
Copy link
Contributor Author

cici37 commented Nov 15, 2023

I have updated the changes according to the suggested format. Please feel free to take a look when have time. Thanks

@tengqm
Copy link
Contributor

tengqm commented Nov 16, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2023
@Shubham82
Copy link
Contributor

Thanks @cici37
It looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 95aceaefe19f819f860976c5b10640b6303a1f57

@k8s-ci-robot k8s-ci-robot merged commit cfbe80d into kubernetes:dev-1.29 Nov 16, 2023
6 checks passed
@cici37 cici37 deleted the 2876-1.29 branch November 16, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shubham82 Shubham82 Shubham82 requested changes

@roycaihw roycaihw Awaiting requested review from roycaihw

@sttts sttts Awaiting requested review from sttts

Assignees

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@cici37 @k8s-ci-robot @sftim @katcosgrove @tengqm @Shubham82