-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote PodOS field to GA #35590
Promote PodOS field to GA #35590
Conversation
/sig windows |
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
/cc |
Please include an update to https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/security/pod-security-standards.md with the changes from kubernetes/kubernetes#105919 (make sure to update the FAQ question in addition to the restrictions table). /assign |
/assign @cathchu |
@tallclair : docs PR for pod security standards update: |
…-gates.md Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
5898b66
to
c8bedc8
Compare
Should we move the information about the api field at https://kubernetes.io/docs/concepts/windows/user-guide/ to https://kubernetes.io/docs/concepts/workloads/pods/? |
I don't have a strong opinion on this. We started working on this field so that it'll be more useful to the windows users but it hasn't reached a stage where it is more useful to other OSes except for the pod security standards restricted mode. If you feel that this can move to a more neutral place, I don't have any issues with it. |
/unassign I'll review #35772 instead. |
I don't have a strong opinion. |
We should definitely update https://kubernetes.io/docs/concepts/workloads/pods/ to explaing the Pod OS details. Linux users aren't very likely to read Guide for scheduling Windows containers in Kubernetes. |
Sure, as mentioned in this comment, I'll open PR once k/k opens. |
@sftim - Any other concerns before we merge this PR? |
I was asking for an update to the Pod concept guide. I also want an update to the OpenAPI docs for the Pod API (which then ends up updating Pod), but those concept docs changes are needed ahead of the 1.25 release. With only rare exceptions, we expect to have GA features graduate to stable with documentation already in place. |
To be clear, you want this entire description of this field to be moved to pod concepts doc? |
You can do either a:
The outcome must be that when someone reads https://kubernetes.io/docs/concepts/workloads/pods/, they are aware that you can specify the name of the OS that this Pod is expected to run on. |
Opened another PR: #35985 |
LGTM (from sig-windows) |
@sftim - Any other concerns before we merge this PR? |
applying lgtm from marosett in this comment /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 8d7162f02948aabd15f92584bdeaa1ce2ed29577
|
xref: kubernetes/enhancements#2802