Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PodOS field to GA #35590

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

ravisantoshgudimetla
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 31, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 31, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jul 31, 2022
@ravisantoshgudimetla
Copy link
Contributor Author

cc @marosset @jsturtevant

@netlify
Copy link

netlify bot commented Jul 31, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c8bedc8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62f03aa2d7dc2900099618c7

@marosset
Copy link
Contributor

marosset commented Aug 1, 2022

/cc
I'll review after code freeze

@k8s-ci-robot k8s-ci-robot requested a review from marosset August 1, 2022 15:54
@tallclair
Copy link
Member

Please include an update to https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/security/pod-security-standards.md with the changes from kubernetes/kubernetes#105919 (make sure to update the FAQ question in addition to the restrictions table).

/assign

@reylejano
Copy link
Member

/milestone 1.25
/assign @krol3
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot added this to the 1.25 milestone Aug 3, 2022
@k8s-ci-robot k8s-ci-robot requested a review from kcmartin August 3, 2022 04:14
@reylejano
Copy link
Member

/assign @cathchu

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Aug 7, 2022

Sure @tallclair, will open docs PR this week.

@tallclair : docs PR for pod security standards update:

#35772

ravisantoshgudimetla and others added 2 commits August 7, 2022 18:19
…-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@marosset
Copy link
Contributor

marosset commented Aug 8, 2022

Should we move the information about the api field at https://kubernetes.io/docs/concepts/windows/user-guide/ to https://kubernetes.io/docs/concepts/workloads/pods/?

@ravisantoshgudimetla
Copy link
Contributor Author

Should we move the information about the api field at https://kubernetes.io/docs/concepts/windows/user-guide/ to https://kubernetes.io/docs/concepts/workloads/pods/?

I don't have a strong opinion on this. We started working on this field so that it'll be more useful to the windows users but it hasn't reached a stage where it is more useful to other OSes except for the pod security standards restricted mode. If you feel that this can move to a more neutral place, I don't have any issues with it.

@tallclair
Copy link
Member

/unassign

I'll review #35772 instead.

@marosset
Copy link
Contributor

Should we move the information about the api field at https://kubernetes.io/docs/concepts/windows/user-guide/ to https://kubernetes.io/docs/concepts/workloads/pods/?

I don't have a strong opinion on this. We started working on this field so that it'll be more useful to the windows users but it hasn't reached a stage where it is more useful to other OSes except for the pod security standards restricted mode. If you feel that this can move to a more neutral place, I don't have any issues with it.

I don't have a strong opinion.

@sftim
Copy link
Contributor

sftim commented Aug 14, 2022

Should we move the information about the api field at https://kubernetes.io/docs/concepts/windows/user-guide/ to https://kubernetes.io/docs/concepts/workloads/pods/?

We should definitely update https://kubernetes.io/docs/concepts/workloads/pods/ to explaing the Pod OS details. Linux users aren't very likely to read Guide for scheduling Windows containers in Kubernetes.

@ravisantoshgudimetla
Copy link
Contributor Author

Should we move the information about the api field at https://kubernetes.io/docs/concepts/windows/user-guide/ to https://kubernetes.io/docs/concepts/workloads/pods/?

We should definitely update https://kubernetes.io/docs/concepts/workloads/pods/ to explaing the Pod OS details. Linux users aren't very likely to read Guide for scheduling Windows containers in Kubernetes.

Sure, as mentioned in this comment, I'll open PR once k/k opens.

@ravisantoshgudimetla
Copy link
Contributor Author

@sftim - Any other concerns before we merge this PR?

@sftim
Copy link
Contributor

sftim commented Aug 15, 2022

Sure, as mentioned in this comment, I'll open PR once k/k opens.

I was asking for an update to the Pod concept guide. I also want an update to the OpenAPI docs for the Pod API (which then ends up updating Pod), but those concept docs changes are needed ahead of the 1.25 release.

With only rare exceptions, we expect to have GA features graduate to stable with documentation already in place.

@ravisantoshgudimetla
Copy link
Contributor Author

I was asking for an update to the Pod concept guide. I also want an update to the OpenAPI docs for the Pod API (which then ends up updating Pod), but those concept docs changes are needed ahead of the 1.25 release.

To be clear, you want this entire description of this field to be moved to pod concepts doc?

@sftim
Copy link
Contributor

sftim commented Aug 15, 2022

To be clear, you want this entire description of this field to be moved to pod concepts doc?

You can do either a:

  • move
  • copy

The outcome must be that when someone reads https://kubernetes.io/docs/concepts/workloads/pods/, they are aware that you can specify the name of the OS that this Pod is expected to run on.

@ravisantoshgudimetla
Copy link
Contributor Author

To be clear, you want this entire description of this field to be moved to pod concepts doc?

You can do either a:

  • move
  • copy

The outcome must be that when someone reads https://kubernetes.io/docs/concepts/workloads/pods/, they are aware that you can specify the name of the OS that this Pod is expected to run on.

Opened another PR: #35985

@marosset
Copy link
Contributor

LGTM (from sig-windows)
We can keep the Windows specific behaviors documented at https://kubernetes.io/docs/concepts/windows/user-guide/ and the more general behavior documented at https://kubernetes.io/docs/concepts/workloads/pods/ (which is added in a #35985 )

@ravisantoshgudimetla
Copy link
Contributor Author

@sftim - Any other concerns before we merge this PR?

@reylejano
Copy link
Member

applying lgtm from marosett in this comment
/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d7162f02948aabd15f92584bdeaa1ce2ed29577

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6b23f69 into kubernetes:dev-1.25 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants