Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PodOS field to GA #35590

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Promote PodOS field to GA #35590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7536335
Promote PodOS field to GA
ravisantoshgudimetla Jul 31, 2022
c465853
Update content/en/docs/reference/command-line-tools-reference/feature…
ravisantoshgudimetla Aug 7, 2022
c8bedc8
Update content/en/docs/concepts/windows/user-guide.md
ravisantoshgudimetla Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions content/en/docs/concepts/windows/intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,12 @@ section refers to several key workload abstractions and how they map to Windows.
* OS field:

The `.spec.os.name` field should be set to `windows` to indicate that the current Pod uses Windows containers.
The `IdentifyPodOS` feature gate needs to be enabled for this field to be recognized.

{{< note >}}
Starting from 1.24, the `IdentifyPodOS` feature gate is in Beta stage and defaults to be enabled.
Starting from 1.25, the `IdentifyPodOS` feature gate is in GA stage and defaults to be enabled.
{{< /note >}}

If the `IdentifyPodOS` feature gate is enabled and you set the `.spec.os.name` field to `windows`,
If you set the `.spec.os.name` field to `windows`,
you must not set the following fields in the `.spec` of that Pod:

* `spec.hostPID`
Expand Down
7 changes: 3 additions & 4 deletions content/en/docs/concepts/windows/user-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,14 +158,13 @@ schedule Linux and Windows workloads to their respective OS-specific nodes.
The recommended approach is outlined below,
with one of its main goals being that this approach should not break compatibility for existing Linux workloads.

If the `IdentifyPodOS` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) is
enabled, you can (and should) set `.spec.os.name` for a Pod to indicate the operating system
Starting from 1.25, please set `.spec.os.name` for a Pod to indicate the operating system
ravisantoshgudimetla marked this conversation as resolved.
Show resolved Hide resolved
that the containers in that Pod are designed for. For Pods that run Linux containers, set
`.spec.os.name` to `linux`. For Pods that run Windows containers, set `.spec.os.name`
to Windows.
to `windows`.

{{< note >}}
Starting from 1.24, the `IdentifyPodOS` feature is in Beta stage and defaults to be enabled.
Starting from 1.25, the `IdentifyPodOS` feature is in GA stage and defaults to be enabled.
{{< /note >}}

The scheduler does not use the value of `.spec.os.name` when assigning Pods to nodes. You should
Expand Down
1 change: 1 addition & 0 deletions content/en/docs/reference/command-line-tools-reference/feature-gates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ different Kubernetes components.
| `HPAScaleToZero` | `false` | Alpha | 1.16 | |
| `IdentifyPodOS` | `false` | Alpha | 1.23 | 1.23 |
| `IdentifyPodOS` | `true` | Beta | 1.24 | |
| `IdentifyPodOS` | `true` | GA | 1.25 | |
ravisantoshgudimetla marked this conversation as resolved.
Show resolved Hide resolved
| `InTreePluginAWSUnregister` | `false` | Alpha | 1.21 | |
| `InTreePluginAzureDiskUnregister` | `false` | Alpha | 1.21 | |
| `InTreePluginAzureFileUnregister` | `false` | Alpha | 1.21 | |
Expand Down