Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo #38873

Closed
wants to merge 1 commit into from
Closed

Fixed typo #38873

wants to merge 1 commit into from

Conversation

prrajput1199
Copy link

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Fixes the documentation

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Minor changes in documentation for "addon"" to "add-on"

Does this PR introduce a user-facing change?

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bradtopol for approval by writing /assign @bradtopol in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 10, 2023
@netlify
Copy link

netlify bot commented Jan 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d0e0384
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63bd97fd5faa210008480322
😎 Deploy Preview https://deploy-preview-38873--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

divya-mohan0209
divya-mohan0209 reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prrajput1199 These are a bunch of trivial edits and changes that aren't valid. We understand that you're enthusiastic about contributing to Kubernetes and open source, however this is the fourth PR that I'm seeing with a similar pattern of edits. Please read the contributing guide and our trivial edits policy before submitting a PR.

content/en/docs/tutorials/services/connect-applications-service.md
@@ -233,7 +233,7 @@ Till now we have only accessed the nginx server from within the cluster. Before
* An nginx server configured to use the certificates
* A [secret](/docs/concepts/configuration/secret/) that makes the certificates accessible to pods

You can acquire all these from the [nginx https example](https://github.com/kubernetes/examples/tree/master/staging/https-nginx/). This requires having go and make tools installed. If you don't want to install those, then follow the manual steps later. In short:
You can acquire all these from the [nginx https example](https://github.com/kubernetes/examples/tree/master/staging/https-nginx/). This requires having to go and make tools installed. If you don't want to install those, then follow the manual steps later. In short:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prrajput1199 this is not a valid change.

content/en/docs/tutorials/services/connect-applications-service.md
@@ -193,7 +193,7 @@ KUBERNETES_SERVICE_PORT_HTTPS=443

### DNS

Kubernetes offers a DNS cluster addon Service that automatically assigns dns names to other Services. You can check if it's running on your cluster:
Kubernetes offers a DNS cluster add-on Service that automatically assigns dns names to other Services. You can check if it's running on your cluster:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial edit.

@amolmote
Copy link
Member

Hi @prrajput1199 , you can start from this issue #35600.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@reylejano
Copy link
Member

Hi @prrajput1199 ,
I'm closing this PR because a reviewer disagrees with the changes proposed in this PR and I agree the changes proposed are not correct and this PR needs rebase -- otherwise there is a merge conflict.
If you feel otherwise feel free to reopen the PR, rebase, and we can continue the discussion
/close

@k8s-ci-robot
Copy link
Contributor

@reylejano: Closed this PR.

In response to this:

Hi @prrajput1199 ,
I'm closing this PR because a reviewer disagrees with the changes proposed in this PR and I agree the changes proposed are not correct and this PR needs rebase -- otherwise there is a merge conflict.
If you feel otherwise feel free to reopen the PR, rebase, and we can continue the discussion
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prrajput1199 @k8s-ci-robot @amolmote @reylejano @divya-mohan0209