-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for PodDisruptionBudget unhealthy pod eviction policy promotion to Beta #40017
Update docs for PodDisruptionBudget unhealthy pod eviction policy promotion to Beta #40017
Conversation
/assign @soltysh @ravisantoshgudimetla |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
db845b2
to
8bba005
Compare
/retitle Update docs for PodDisruptionBudget unhealthy pod eviction policy promotion to Beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. @atiratree who can provide a tech review on this change / confirm that there are no relevant technical changes?
^ @soltysh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but lgtm from tech pov
|
||
{{< note >}} | ||
In order to use this behavior, you must enable the `PDBUnhealthyPodEvictionPolicy` | ||
This feature is enabled by default. You can disable it by disabling the `PDBUnhealthyPodEvictionPolicy` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is enabled by default. You can disable it by disabling the `PDBUnhealthyPodEvictionPolicy` | |
This feature is enabled by default. You can disable it by setting the `PDBUnhealthyPodEvictionPolicy=false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, “disabling the PDBUnhealthyPodEvictionPolicy
feature gate” is idiomatic. I don't recommend making this change.
For example, if we one day allow managing API server feature gates with a configuration file, disabling a gate is actually more likely to look like:
…
- PDBUnhealthyPodEvictionPolicy: false # colon, not equality symbol
…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's even better suggestion 👍
8bba005
to
24b259f
Compare
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
@sftim is anything missing here, or can we merge this one? |
/lgtm |
LGTM label has been added. Git tree hash: 6835d258946e20ec40882ba8d4c8088eb3dbd84d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add documentation for the beta promotion: