Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for PodDisruptionBudget unhealthy pod eviction policy promotion to Beta #40017

Conversation

atiratree
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot requested a review from foxish March 15, 2023 12:32
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kow3ns March 15, 2023 12:32
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2023
@atiratree
Copy link
Member Author

/assign @soltysh @ravisantoshgudimetla

@netlify
Copy link

netlify bot commented Mar 15, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit db845b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6411baf5a3bdfe00079cb9a6
😎 Deploy Preview https://deploy-preview-40017--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atiratree atiratree changed the base branch from main to dev-1.27 March 15, 2023 13:04
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2023
@atiratree atiratree force-pushed the unhealthy-pod-eviction-policy-beta branch from db845b2 to 8bba005 Compare March 15, 2023 13:05
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 15, 2023
@sftim
Copy link
Contributor

sftim commented Mar 15, 2023

/retitle Update docs for PodDisruptionBudget unhealthy pod eviction policy promotion to Beta

@k8s-ci-robot k8s-ci-robot changed the title Promote PodDisruptionBudget UnhealthyPodEvictionPolicy to Beta Update docs for PodDisruptionBudget unhealthy pod eviction policy promotion to Beta Mar 15, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. @atiratree who can provide a tech review on this change / confirm that there are no relevant technical changes?

@atiratree
Copy link
Member Author

^ @soltysh

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but lgtm from tech pov


{{< note >}}
In order to use this behavior, you must enable the `PDBUnhealthyPodEvictionPolicy`
This feature is enabled by default. You can disable it by disabling the `PDBUnhealthyPodEvictionPolicy`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This feature is enabled by default. You can disable it by disabling the `PDBUnhealthyPodEvictionPolicy`
This feature is enabled by default. You can disable it by setting the `PDBUnhealthyPodEvictionPolicy=false`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, “disabling the PDBUnhealthyPodEvictionPolicy feature gate” is idiomatic. I don't recommend making this change.

For example, if we one day allow managing API server feature gates with a configuration file, disabling a gate is actually more likely to look like:

   
   - PDBUnhealthyPodEvictionPolicy: false # colon, not equality symbol
   

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's even better suggestion 👍

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2023
@atiratree atiratree force-pushed the unhealthy-pod-eviction-policy-beta branch from 8bba005 to 24b259f Compare April 3, 2023 09:28
@netlify
Copy link

netlify bot commented Apr 3, 2023

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 24b259f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/642a9c517254e00008998b86

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2023
@atiratree
Copy link
Member Author

@sftim is anything missing here, or can we merge this one?

@mickeyboxell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6835d258946e20ec40882ba8d4c8088eb3dbd84d

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 32e9c35 into kubernetes:dev-1.27 Apr 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants