Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-5336: Adding PDBUnhealthyPodEvictionPolicy as tech preview fea… #57505

Merged
merged 1 commit into from
Apr 13, 2023
Merged

OSDOCS-5336: Adding PDBUnhealthyPodEvictionPolicy as tech preview fea… #57505

merged 1 commit into from
Apr 13, 2023

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 21, 2023 •
edited
Loading

@bergerhoffer bergerhoffer added this to the Planned for 4.13 GA milestone Mar 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2023 •
edited by openshift-ci bot
Loading

@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue.

In response to this:

…ture

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2023
@bergerhoffer bergerhoffer force-pushed the OSDOCS-5336 branch 3 times, most recently from 400e78f to 4efd165 Compare March 21, 2023 19:15
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://57505--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12416

@bergerhoffer bergerhoffer mentioned this pull request Mar 21, 2023
Merged
1 task
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2023 •
edited by openshift-ci bot
Loading

@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue.

In response to this:

…ture

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:
https://57505--docspreview.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-configuring.html#pod-disruption-evic[…]des-pods-configuring
https://57505--docspreview.netlify.app/openshift-enterprise/latest/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster[…]ster-enabling

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 21, 2023
@bergerhoffer
Copy link
Contributor Author

@atiratree Can you please review?

Previews:

@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 21, 2023
GroceryBoyJr
GroceryBoyJr reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 21, 2023
atiratree
atiratree reviewed Mar 23, 2023
View reviewed changes
modules/nodes-cluster-enabling-features-about.adoc Outdated Show resolved Hide resolved
modules/pod-disruption-eviction-policy.adoc Outdated Show resolved Hide resolved
modules/pod-disruption-eviction-policy.adoc Outdated Show resolved Hide resolved
modules/pod-disruption-eviction-policy.adoc Show resolved Hide resolved
@bergerhoffer
Copy link
Contributor Author

@atiratree Made a few updates, let me know what you think.

Diff of changes is here: https://github.com/openshift/openshift-docs/compare/4efd1651eb5b477dcad58f58a3d40592260bba6d..cb454d234f1932bfda34f2d7c1216f4263544d19

Preview: https://57505--docspreview.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-configuring.html#pod-disruption-evic[…]des-pods-configuring

@bergerhoffer
Copy link
Contributor Author

@kasturinarra Can you please review?

Previews:

@kasturinarra
Copy link

Just one comment, rest looks good to me.

@kasturinarra
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 13, 2023 •
edited by openshift-ci bot
Loading

@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue.

In response to this:

…ture

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:
https://57505--docspreview.netlify.app/openshift-enterprise/latest/nodes/pods/nodes-pods-configuring.html#pod-disruption-evic[…]des-pods-configuring
https://57505--docspreview.netlify.app/openshift-enterprise/latest/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster[…]ster-enabling

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer merged commit 8d002e1 into openshift:main Apr 13, 2023
@bergerhoffer
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link

@bergerhoffer: #57505 failed to apply on top of branch "enterprise-4.13":

Applying: OSDOCS-5336: Adding PDBUnhealthyPodEvictionPolicy as tech preview feature
Using index info to reconstruct a base tree...
M	nodes/pods/nodes-pods-configuring.adoc
M	post_installation_configuration/cluster-tasks.adoc
Falling back to patching base and 3-way merge...
Auto-merging post_installation_configuration/cluster-tasks.adoc
Auto-merging nodes/pods/nodes-pods-configuring.adoc
CONFLICT (content): Merge conflict in nodes/pods/nodes-pods-configuring.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-5336: Adding PDBUnhealthyPodEvictionPolicy as tech preview feature
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@kasturinarra kasturinarra kasturinarra left review comments

@atiratree atiratree atiratree left review comments

Assignees

@kasturinarra kasturinarra

Labels
branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
4.13 GA
Development

Successfully merging this pull request may close these issues.
7 participants
@bergerhoffer @openshift-ci-robot @ocpdocs-previewbot @GroceryBoyJr @kasturinarra @openshift-cherrypick-robot @atiratree