-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSDOCS-5336: Release notes for PDB unhealthy eviction policy #57512
OSDOCS-5336: Release notes for PDB unhealthy eviction policy #57512
Conversation
@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14014 |
@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label peer-review-needed |
@atiratree Can you please review this release notes PR as well? |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one question please.
/label peer-review-done |
596ad55
to
832cf36
Compare
832cf36
to
408fd82
Compare
@atiratree Updated, PTAL again |
/lgtm |
@kasturinarra Can you please review? Note that the link at the end of the section won't jump to the right module until #57505 is merged. |
/lgtm |
@bergerhoffer looks like pr needs to be rebased, could you please help check ? thanks !! |
408fd82
to
5a74ee5
Compare
@kasturinarra Yeah, since this is updating the release notes file, we'll likely keep running into conflicts until we merge, since that's a very active file. But this PR is just waiting on a review of #57505 before it can be merged. Can you PTAL at that one when you get a chance? In the meantime, I've resolved the current conflict! |
New changes are detected. LGTM label has been removed. |
5a74ee5
to
bf84fd0
Compare
@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.13
Issue:
https://issues.redhat.com/browse/OSDOCS-5336
Link to docs preview:
https://57512--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-13-release-notes.html#ocp-4-13-pdb-eviction-policy
QE review:
Additional information:
The link at the end of the section won't jump to the right module yet, because it depends on #57505 being merged first.