Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-5336: Release notes for PDB unhealthy eviction policy #57512

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Mar 21, 2023

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:
https://57512--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-13-release-notes.html#ocp-4-13-pdb-eviction-policy

QE review:

  • QE has approved this change.

Additional information:
The link at the end of the section won't jump to the right module yet, because it depends on #57505 being merged first.

@bergerhoffer bergerhoffer added this to the Planned for 4.13 GA milestone Mar 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2023

@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue.

In response to this:

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 21, 2023

🤖 Updated build preview is available at:
https://57512--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/14014

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 21, 2023

@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue.

In response to this:

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:
https://57512--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-13-release-notes.html#ocp-4-13-pdb-eviction-policy

QE review:

  • QE has approved this change.

Additional information:
The link at the end of the section won't jump to the right module yet, because it depends on #57505 being merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 21, 2023
@bergerhoffer
Copy link
Contributor Author

@GroceryBoyJr
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 21, 2023
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one question please.

release_notes/ocp-4-13-release-notes.adoc Show resolved Hide resolved
@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 21, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 23, 2023
@atiratree
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2023
@bergerhoffer
Copy link
Contributor Author

@kasturinarra Can you please review? Note that the link at the end of the section won't jump to the right module until #57505 is merged.

Preview: https://57512--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-13-release-notes.html#ocp-4-13-pdb-eviction-policy

@kasturinarra
Copy link

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@kasturinarra
Copy link

@bergerhoffer looks like pr needs to be rebased, could you please help check ? thanks !!

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2023
@bergerhoffer
Copy link
Contributor Author

@kasturinarra Yeah, since this is updating the release notes file, we'll likely keep running into conflicts until we merge, since that's a very active file. But this PR is just waiting on a review of #57505 before it can be merged. Can you PTAL at that one when you get a chance?

In the meantime, I've resolved the current conflict!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 13, 2023

@bergerhoffer: This pull request references OSDOCS-5336 which is a valid jira issue.

In response to this:

Version(s):
4.13

Issue:
https://issues.redhat.com/browse/OSDOCS-5336

Link to docs preview:
https://57512--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-13-release-notes.html#ocp-4-13-pdb-eviction-policy

QE review:

  • QE has approved this change.

Additional information:
The link at the end of the section won't jump to the right module yet, because it depends on #57505 being merged first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer merged commit 3e220bd into openshift:enterprise-4.13 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants