Skip to content

cloud-controller-manager and kubelet glossary file updated with corresponding links #40822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tamilselvan1102 wants to merge 3 commits into from
Closed

cloud-controller-manager and kubelet glossary file updated with corresponding links #40822

tamilselvan1102 wants to merge 3 commits into from

Conversation

@tamilselvan1102
Copy link
Contributor

@tamilselvan1102 tamilselvan1102 commented Apr 24, 2023

cloud-controller-manager and kubelet glossary files has been updated with corresponding links
PR #40820

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 24, 2023 10:58
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 24, 2023
@netlify
Copy link

netlify bot commented Apr 24, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit feb8f27
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64511760c890ef0008d6f3ad
😎 Deploy Preview https://deploy-preview-40822--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mengjiao-liu
mengjiao-liu reviewed Apr 25, 2023
View reviewed changes
content/en/docs/reference/glossary/cloud-controller-manager.md Outdated

By decoupling the interoperability logic between Kubernetes and the underlying cloud
infrastructure, the cloud-controller-manager component enables cloud providers to release
infrastructure, the [cloud-controller-manager](/docs/concepts/architecture/cloud-controller/) component enables cloud providers to release
Copy link
Member

@mengjiao-liu mengjiao-liu Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not update the link at line 15?

It's more noticeable in the front, isn't it?

Copy link
Contributor Author

@tamilselvan1102 tamilselvan1102 Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Till line 17 is using for glossary tooltip messages and hence created a link in the more (line 19) section.

Copy link
Member

@dipesh-rawat dipesh-rawat Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamilselvan1102 The tooltip on Line 14 pertains only to the term 'control plane'. As previously suggested in a review comment, Line 15 may accommodate the inclusion of a link for 'cloud-controller-manager'.

Copy link
Contributor Author

@tamilselvan1102 tamilselvan1102 May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipesh-rawat
I have investigated, [cloud-controller-manager] is not used anywhere as tooltip but used as [glossary_definition term_id] in the following pages. So accepted the suggestion and will update the PR.

https://kubernetes.io/docs/concepts/architecture/cloud-controller/
https://kubernetes.io/docs/concepts/overview/components/
https://kubernetes.io/docs/tasks/administer-cluster/controller-manager-leader-migration/
https://kubernetes.io/docs/tasks/administer-cluster/developing-cloud-controller-manager/

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Apr 25, 2023

Preview pages:
Cloud Controller Manager: https://deploy-preview-40822--kubernetes-io-main-staging.netlify.app/docs/reference/glossary/?all=true#term-cloud-controller-manager

Kubelet: https://deploy-preview-40822--kubernetes-io-main-staging.netlify.app/docs/reference/glossary/?all=true#term-kubelet

@tamilselvan1102
Copy link
Contributor Author

tamilselvan1102 commented Apr 25, 2023

@mengjiao-liu
Preview pages:
Cloud Controller Manager: https://deploy-preview-40822--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/components/#cloud-controller-manager

Kubelet: https://deploy-preview-40822--kubernetes-io-main-staging.netlify.app/docs/concepts/overview/components/#kubelet

@tamilselvan1102 tamilselvan1102 force-pushed the k8s-doc-web-20230424 branch from 9f96927 to a68a1ab Compare May 2, 2023 06:38
@tamilselvan1102 tamilselvan1102 force-pushed the k8s-doc-web-20230424 branch from a68a1ab to ed1d546 Compare May 2, 2023 07:03
@dipesh-rawat
Copy link
Member

dipesh-rawat commented May 2, 2023

@tamilselvan1102 I see the Netlify build failed. Could you try to trigger the build again using:
git commit --amend --no-edit && git push --force-with-lease

@tamilselvan1102 tamilselvan1102 force-pushed the k8s-doc-web-20230424 branch from feb8f27 to 906e259 Compare May 2, 2023 14:00
@tamilselvan1102
Copy link
Contributor Author

tamilselvan1102 commented May 2, 2023

@tamilselvan1102 I see the Netlify build failed. Could you try to trigger the build again using: git commit --amend --no-edit && git push --force-with-lease

@tamilselvan1102 tamilselvan1102 deleted the k8s-doc-web-20230424 branch May 2, 2023 14:02
@tamilselvan1102
Copy link
Contributor Author

tamilselvan1102 commented May 2, 2023

Netlify build keep on failing so closed this and created new PR . Sorry for the inconvenient
#40931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sftim sftim Awaiting requested review from sftim

2 more reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mengjiao-liu mengjiao-liu mengjiao-liu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tamilselvan1102 @k8s-ci-robot @mengjiao-liu @dipesh-rawat