Skip to content

Conversation

@tamilselvan1102
Copy link
Contributor

@tamilselvan1102 tamilselvan1102 commented May 2, 2023

cloud-controller-manager and kubelet glossary files has been updated with corresponding links
Issue: #40820

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 866b67e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/650a85aef464f40008b2dcdb
😎 Deploy Preview https://deploy-preview-40931--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented May 7, 2023

/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2023
@sftim
Copy link
Contributor

sftim commented May 7, 2023

The build is failing:

9:37:11 AM: ERROR 2023/05/04 08:37:11 render of "section" failed: "/opt/build/repo/layouts/docs/list.html:25:11": execute of template failed: template: docs/list.html:25:11: executing "main" at <partial "section-index.html" .>: error calling partial: partial "section-index.html" timed out after 3m0s. This is most likely due to infinite recursion. If this is just a slow template, you can try to increase the 'timeout' config setting.
9:37:11 AM: ERROR 2023/05/04 08:37:11 render of "section" failed: "/opt/build/repo/layouts/docs/list.html:25:11": execute of template failed: template: docs/list.html:25:11: executing "main" at <partial "section-index.html" .>: error calling partial: partial "section-index.html" timed out after 3m0s. This is most likely due to infinite recursion. If this is just a slow template, you can try to increase the 'timeout' config setting.
9:37:11 AM: ERROR 2023/05/04 08:37:11 render of "section" failed: "/opt/build/repo/layouts/docs/list.html:25:11": execute of template failed: template: docs/list.html:25:11: executing "main" at <partial "section-index.html" .>: error calling partial: partial "section-index.html" timed out after 3m0s. This is most likely due to infinite recursion. If this is just a slow template, you can try to increase the 'timeout' config setting.
9:37:11 AM: ERROR 2023/05/04 08:37:11 render of "section" failed: "/opt/build/repo/layouts/docs/list.html:25:11": execute of template failed: template: docs/list.html:25:11: executing "main" at <partial "section-index.html" .>: error calling partial: partial "section-index.html" timed out after 3m0s. This is most likely due to infinite recursion. If this is just a slow template, you can try to increase the 'timeout' config setting.
9:37:11 AM: Error: Error building site: failed to render pages: render of "section" failed: "/opt/build/repo/layouts/docs/list.html:25:11": execute of template failed: template: docs/list.html:25:11: executing "main" at <partial "section-index.html" .>: error calling partial: partial "section-index.html" timed out after 3m0s. This is most likely due to infinite recursion. If this is just a slow template, you can try to increase the 'timeout' config setting.

It works OK on my (16 CPU) machine. Maybe we need a longer timeout. Not sure.

@kbhawkey
Copy link
Contributor

kbhawkey commented May 9, 2023

Hello @tamilselvan1102
Can you push another change. We need to have the changes deploy a preview before we can publish.
Thanks!

@tamilselvan1102
Copy link
Contributor Author

@kbhawkey

Can you push another change. We need to have the changes deploy a preview before we can publish. Thanks!

My intention to make url link for kubelet & Cloud Controller Manager and that was done in this commit.

What is your expectation?

@sftim
Copy link
Contributor

sftim commented May 9, 2023

I will trigger another Netlify build. We have bugs around our automated website build.

@tamilselvan1102
Copy link
Contributor Author

I will trigger another Netlify build. We have bugs around our automated website build.

Thank you

@dipesh-rawat
Copy link
Member

@tamilselvan1102 I see the Netlify build failed. Could you try to trigger the build again using:
git commit --amend --no-edit && git push --force-with-lease

@tamilselvan1102
Copy link
Contributor Author

@dipesh-rawat
triggered the commit

@reylejano
Copy link
Member

@tamilselvan1102 , can you retrigger the build with git commit --amend --no-edit && git push --force-with-lease

@tamilselvan1102
Copy link
Contributor Author

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

Preview Page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 2f2261c3015d81d992b2a8b2e443ac23f3e1c68a

@k8s-ci-robot k8s-ci-robot merged commit 2a4a506 into kubernetes:main Sep 23, 2023
dkarczmarski added a commit to dkarczmarski/kubernetes-website that referenced this pull request Mar 31, 2025
k8s-ci-robot added a commit that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants