Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename PodHasNetwork to PodReadyToStartContainers as part of rename #41744

Merged
merged 5 commits into from
Jul 25, 2023
Merged

rename PodHasNetwork to PodReadyToStartContainers as part of rename #41744

merged 5 commits into from
Jul 25, 2023

Conversation

kannon92
Copy link
Contributor

We renamed the PodHasNetwork condition to PodReadyToStartContainers condition in 1.28.

We want to keep the recent blog post up to date.

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jun 23, 2023
@k8s-ci-robot k8s-ci-robot requested review from onlydole and sftim June 23, 2023 13:45
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@sftim
Update content/en/blog/_posts/2022-09-14-pod-has-network-condition.md
6e1a413 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@netlify
Copy link

netlify bot commented Jul 24, 2023 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 20b5049
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/64beb3b03568e00008d7937f

@sftim
Update content/en/blog/_posts/2022-09-14-pod-has-network-condition.md
20b5049 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@kannon92 kannon92 requested review from sftim and tengqm July 24, 2023 21:51
@tengqm
Copy link
Contributor

tengqm commented Jul 25, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 593841710e94547e4ed03a6637f1e5e4c8a1bb16

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit db857c8 into kubernetes:dev-1.28 Jul 25, 2023
@kannon92 kannon92 mentioned this pull request Jul 26, 2023
Open
20 tasks
Rishit-dagli pushed a commit to Rishit-dagli/website that referenced this pull request Aug 12, 2023
@k8s-ci-robot @Rishit-dagli
Merge pull request kubernetes#41744 from kannon92/update-pod-ready-to…
80407af 
…-start-blog-post

rename PodHasNetwork to PodReadyToStartContainers as part of rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlydole onlydole Awaiting requested review from onlydole

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@kannon92 @tengqm @k8s-ci-robot @sftim