[KEP-3085] Add condition for sandbox creation (xposted from original issue)

[kannon92]

This is a repost of #3085 as we want to keep this up to date.

Enhancement Description

• One-line enhancement description (can be used as a release note): Surface pod conditions around completion of pod sandbox creation marked by successful network configuration for the pod.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/3085-pod-conditions-for-starting-completition-of-sandbox-creation
• Discussion Link: SIG Node Agenda
• Primary contact (assignee): @kannon92 (@ddebroy is original author)
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha1 release target (x.y): 1.25
  • Alpha2 release target (x.y): 1.28
  • Beta release target (x.y): 1.29-1.30
  • Stable release target (x.y):
• Alpha1 (1.25)
  • KEP (k/enhancements) update PR(s):
    • KEP-3085: Add KEP for Pod network ready condition #3087
    • KEP-3085: update kep with implementation details for alpha #4077
  • Code (k/k) update PR(s):
    • Introduce PodHasNetwork condition for pods kubernetes#111358
    • feat: rename PodHasNetwork to PodReadyToStartContainers kubernetes#117702
  • Docs (k/website) update PR(s): PodHasNetwork condition docs website#35704
• Alpha2 (1.28)
  • KEP (k/enhancements) update PR(s):
    • Update KEP with new name: PodReadyToStartContainers condition #3778
  • Code (k/k) update PR(s):
    • feat: rename PodHasNetwork to PodReadyToStartContainers kubernetes#117702
  • Docs (k/website) update PR(s):
    • rename PodHasNetwork to PodReadyToStartContainers as part of rename website#41744
    • rename PodHasNetwork to PodReadyToStartContainers website#40945
• Beta (1.29-1.30)
  • KEP (k/enhancements) update PR(s):
    • KEP-3085: promote to beta in 1.29 #4139
    • [KEP-3085] update kep to say its being worked on in 1.30 #4483
  • Code (k/k) update PR(s):
    • [KEP-3085] Promote PodReadyToStartContainers to beta in 1.29 kubernetes#119659
    • [KEP-3085]: check PodReadyToStartContainers condition after gracefulshutdown kubernetes#121044
    • [KEP - 3085] Add e2e test for PodReadyToStartContainerCondition when config map is created kubernetes#121321
  • Docs (k/website) update(s):
    • update docs to promote PodReadyToStartContainersCondition into beta website#43533
    • Add blog post to reflect state of PodReadyToStartContainersCondition website#43932

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kannon92]

/sig node

[kannon92]

Moved #3085 to this thread so I can keep it up-to-date with latest changes. It was a bit challenging to keep release team up to date so want to be able to update this.

[kannon92]

@Atharva-Shinde can you please add the same labels as the issue in #3085?

[Atharva-Shinde]

/stage alpha
/milestone v1.28

/label lead-opted-in
for v1.28 as per comment

[Atharva-Shinde]

@kannon92 please link the original issue in this issue description :)

[liggitt]

can this be categorized into a stage in the 1.28 project? the repost of the issue meant it was missing some metadata

[kannon92]

can this be categorized into a stage in the 1.28 project? the repost of the issue meant it was missing some metadata

@Atharva-Shinde are you able to help with this? I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

[Atharva-Shinde]

can this be categorized into a stage in the 1.28 project?

@liggitt I have updated the stage on the enhancements project board to alpha.

I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

I'm not sure if I understand you @kannon92, this issue already has a v1.28 milestone tag attached here and on the project board too.

[kannon92]

can this be categorized into a stage in the 1.28 project?

@liggitt I have updated the stage on the enhancements project board to alpha.

I see the issue is tracked in the enhancements 1.28 board but I don't see a v1.28 milestone.

I'm not sure if I understand you @kannon92, this issue already has a v1.28 milestone tag attached here and on the project board too.

I realize I was wrong. I thought I should see a label in the issue with v1.28 but I don't see that.

[npolshakova]

Hello 👋, 1.29 Enhancements Lead here.

If you wish to progress this enhancement in v1.29, please have the SIG lead opt-in your enhancement by adding the lead-opt-in and milestone v1.29 labels before the Production Readiness Review Freeze.

/remove-label lead-opted-in

[SergeyKanzhelev]

/milestone v1.29
/label lead-opted-in

as discussed at sig node meeting this week

[kannon92]

/assign

[kannon92]

I will not be able to work on this for 1.32 so I am moving it to removed from release.

If you are using this feature, please let us know!

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[kannon92]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kannon92]

/reopen

[k8s-ci-robot]

@kannon92: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kannon92]

@gjkim42 has found this useful for sidecars. kubernetes/kubernetes#128232

I didn't bring this up for stable as I wasn't sure if anyone is actually using this feature at the moment.

[gjkim42]

https://grep.app/search?q=PodReadyToStartContainers

I guess some of the others actually use it?
https://grep.app/search?q=PodReadyToStartContainers&filter[lang][0]=Go&filter[repo][0]=tektoncd/pipeline

Is there any other problem that we cannot promote this to GA?

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sreeram-venkitesh]

/reopen

CC @kannon92

[k8s-ci-robot]

@sreeram-venkitesh: Reopened this issue.

In response to this:

/reopen

CC @kannon92

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kannon92]

/remove-lifecycle rotten