Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post to reflect state of PodReadyToStartContainersCondition #43932

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add blog post to reflect state of PodReadyToStartContainersCondition #43932

merged 1 commit into from
Dec 13, 2023

Conversation

charles-chenzz
Copy link
Member

this PR add blog post to reflect the state of feature: podreadytostartcontainerscondition

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 14, 2023
@charles-chenzz charles-chenzz mentioned this pull request Nov 14, 2023
Merged
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f6f75d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/656e661ca405b400080db087
😎 Deploy Preview https://deploy-preview-43932--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dipesh-rawat
Copy link
Member

/retitle Add blog post to reflect state of PodReadyToStartContainersCondition

@k8s-ci-robot k8s-ci-robot changed the title add blog post to reflect state of podreadytostartcontainerscondition Add blog post to reflect state of PodReadyToStartContainersCondition Nov 14, 2023
@dipesh-rawat
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 14, 2023
@kannon92
Copy link
Contributor

Generally, you want to explain a bit more about what this feature is. And maybe to explain what users are seeing.

Most people are not aware of this feature so the blog brings attention to it.

@kannon92 kannon92 mentioned this pull request Nov 14, 2023
Open
20 tasks
@charles-chenzz
Copy link
Member Author

Generally, you want to explain a bit more about what this feature is. And maybe to explain what users are seeing.

Most people are not aware of this feature so the blog brings attention to it.

I'll try my best to rephrase

kannon92
kannon92 reviewed Nov 15, 2023
View reviewed changes
content/en/blog/_posts/2023-11-14-PodReadyToStartContainersCondition-in-beta.md Outdated


With Kubernetes 1.29 the PodReadyToStartContainersCondition functionality entered beta and is available by default.
A new kubelet-managed pod condition in the status field of a pod. The kubelet will use the PodHasNetwork condition to accurately surface the initialization state of a pod,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A new kubelet-managed pod condition in the status field of a pod. The kubelet will use the PodHasNetwork condition to accurately surface the initialization state of a pod,
A new kubelet-managed pod condition in the status field of a pod. The kubelet will use the PodReadyToStartContainers condition to accurately surface the initialization state of a pod,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style nit: condition names should be inside backticks. This helps people tell them apart from API kinds (which we write without backticks).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated Kevin's comment.

Style nit: condition names should be inside backticks. This helps people tell them apart from API kinds (which we write without backticks).

can you list me an example? I'm not quite getting this. sorry for my poor English

@krol3
Copy link
Contributor

krol3 commented Nov 15, 2023 •
edited
Loading

Hi @charles-chenzz! how are you? Here from the Communications Release Team 1.29, the deadline for the feature blog to be ready to review is this Friday, Nov 17th, the proposal publish date will be Dec 14th. cc: @a-mccarthy @kcmartin. It's related the feature blog about this KEP-4138

@kubernetes/sig-docs-blog-owners: Blog scheduled: Dec 14th, Publication Order Nro:2

@charles-chenzz
Copy link
Member Author

Hi @charles-chenzz! how are you? Here from the Communications Release Team 1.29, the deadline for the feature blog to be ready to review is this Friday, Nov 17th, the proposal publish date will be Dec 14th. cc: @a-mccarthy @kcmartin. It's related the feature blog about this kubernetes/enhancements#4138

I think we're already in the review process, no?

@sftim
Copy link
Contributor

sftim commented Nov 16, 2023

What we're asking is for you to get this PR to the point where you believe it's ready to merge.
(If you already believe that, please recheck the publication date and the source code path in light of the newly assigned publication date)

kannon92
kannon92 reviewed Nov 20, 2023
View reviewed changes
content/en/blog/_posts/2023-11-14-PodReadyToStartContainersCondition-in-beta.md Outdated

### How can I learn more?

Please check out the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link the KEP also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, maybe a sentence like the following:
For more detailed overview of the feature, please read KEP-3085.

Also maybe mention other blog posts around this feature ie https://kubernetes.io/blog/2022/09/14/pod-has-network-condition/

But maybe that is too much..

kannon92
kannon92 reviewed Nov 20, 2023
View reviewed changes
content/en/blog/_posts/2023-11-14-PodReadyToStartContainersCondition-in-beta.md Outdated
Therefore, there is a need for an improved mechanism to provide cluster administrators with a clear and
comprehensive view of pod sandbox creation completion and container readiness.

## What's the benefit?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can mention CSI creation in relation to volumes and configmaps.

I stumbled upon this feature because I was looking for a programmatic way to detect failures in mounting volumes from missing Secrets/ConfigMaps.

@charles-chenzz
Copy link
Member Author

updated to latest date

kannon92
kannon92 reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

nice work @charles-chenzz

I barely helped with this so I wouldn’t be upset if you removed me from authors.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
@sftim
Copy link
Contributor

sftim commented Dec 1, 2023

/approve

Please consider squashing this to 1 commit @charles-chenzz

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@charles-chenzz
Copy link
Member Author

squashed to one commit. can re-lgtm if you don't mind

sftim
sftim reviewed Dec 3, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry; we reviewed this before but actually I recommend some fixes. Please see the inline feedback.

/lgtm cancel

content/en/blog/_posts/2023-12-19-PodReadyToStartContainersCondition-in-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-19-PodReadyToStartContainersCondition-in-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-19-PodReadyToStartContainersCondition-in-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-19-PodReadyToStartContainersCondition-in-beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-19-PodReadyToStartContainersCondition-in-beta.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2023
@charles-chenzz
Copy link
Member Author

update as suggested

sftim
sftim previously requested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing to fix, please.

content/en/blog/_posts/2023-12-19-PodReadyToStartContainersCondition-in-beta.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2023
@sftim sftim dismissed their stale review December 5, 2023 00:33

Superseded

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@sftim
Copy link
Contributor

sftim commented Dec 5, 2023

🛑 Do not merge until Kubernetes v1.29 is released 🛑

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a09a04a43972fd38a38feed81c6c9befbf989581

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@reylejano
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit efe87b4 into kubernetes:main Dec 13, 2023
6 checks passed
@charles-chenzz charles-chenzz deleted the blog_post branch December 13, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ritikaa96 Ritikaa96 Ritikaa96 requested changes

@James-Quigley James-Quigley James-Quigley requested changes

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@kannon92 kannon92

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@charles-chenzz @dipesh-rawat @kannon92 @krol3 @sftim @k8s-ci-robot @reylejano @James-Quigley @Ritikaa96