Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename PodHasNetwork to PodReadyToStartContainers #40945

Merged
merged 6 commits into from
Jun 16, 2023
Merged

rename PodHasNetwork to PodReadyToStartContainers #40945

merged 6 commits into from
Jun 16, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented May 3, 2023

As part of the sandbox KEP there was a request to rename PodHasNetwork to PodReadyToStartContainers.

We have a PR for the code changes and we should update the website with the changes also.

Some questions:

Do we change the blog post on 1.25 for PodHasNetwork to use the new Conditions?

Are the feature toggle tables autogenerated? I did not change the references for that as it doesn't look to be human written.

PR: kubernetes/kubernetes#117702

@k8s-ci-robot k8s-ci-robot requested a review from mengjiao-liu May 3, 2023 13:11
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 3, 2023
@k8s-ci-robot k8s-ci-robot requested a review from shannonxtreme May 3, 2023 13:11
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 3, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented May 3, 2023

@ddebroy

@kannon92 kannon92 changed the base branch from main to dev-1.28 May 3, 2023 13:13
@kannon92
Copy link
Contributor Author

kannon92 commented May 3, 2023

/hold

We should get the code merged before updating the website.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@ddebroy
Copy link
Member

ddebroy commented May 3, 2023 •
edited
Loading

Do we change the blog post on 1.25 for PodHasNetwork to use the new Conditions?

I don't believe previous blog posts are changed based on updates in the most recent release. May be a new blog post clarifying the rename would help?

ddebroy
ddebroy reviewed May 3, 2023
View reviewed changes
Copy link
Member

@ddebroy ddebroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion - otherwise LGTM!

content/en/docs/concepts/workloads/pods/pod-lifecycle.md Show resolved Hide resolved
@kannon92 kannon92 mentioned this pull request May 5, 2023
Closed
10 tasks
kannon92 and others added 3 commits May 10, 2023 08:15
@kannon92 @tengqm
Update content/en/docs/reference/command-line-tools-reference/feature…
3e39afe 
…-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@kannon92 @tengqm
Update content/en/docs/reference/command-line-tools-reference/feature…
1c4669f 
…-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@kannon92 @tengqm
Update content/en/docs/reference/command-line-tools-reference/feature…
f0d5d0b 
…-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@tengqm
Copy link
Contributor

tengqm commented May 10, 2023

Thanks.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@tengqm
Copy link
Contributor

tengqm commented May 10, 2023

The hold is still effective because the upstream code is not yet in.
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 10, 2023
@sftim
Copy link
Contributor

sftim commented May 10, 2023

Are the feature toggle tables autogenerated? I did not change the references for that as it doesn't look to be human written.

Not yet. They need a manual update.

(Aside: if anyone wants to autogenerate them, I can show both my original approach, and how I'd now revise it)

@kannon92
Copy link
Contributor Author

Are the feature toggle tables autogenerated? I did not change the references for that as it doesn't look to be human written.

Not yet. They need a manual update.

(Aside: if anyone wants to autogenerate them, I can show both my original approach, and how I'd now revise it)

Thank you! Yea I updated those so now I know!

@kannon92
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2023
@kannon92
Copy link
Contributor Author

This is ready for approval as the code pr was just merged.

@kannon92 kannon92 requested review from tengqm, sftim and ddebroy June 16, 2023 21:09
dipesh-rawat
dipesh-rawat reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes to rename the feature gate look good and also, the upstream code as part of kubernetes/kubernetes#117702 is merged. Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19ad21cac3c0b5b0d84bd973d65df5b31e374c54

@k8s-ci-robot k8s-ci-robot merged commit 01c9dec into kubernetes:dev-1.28 Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 16, 2023
matthyx pushed a commit to matthyx/website that referenced this pull request Jul 4, 2023
@kannon92 @tengqm @matthyx
rename PodHasNetwork to PodReadyToStartContainers (kubernetes#40945)
416a882 
* rename PodHasNetwork to PodReadyToStartContainers

* add note for condition rename

* add feature gate removal

* Update content/en/docs/reference/command-line-tools-reference/feature-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
richabanker pushed a commit to richabanker/website that referenced this pull request Jul 23, 2023
@kannon92 @tengqm @richabanker
rename PodHasNetwork to PodReadyToStartContainers (kubernetes#40945)
f5b7be5 
* rename PodHasNetwork to PodReadyToStartContainers

* add note for condition rename

* add feature gate removal

* Update content/en/docs/reference/command-line-tools-reference/feature-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@kannon92 kannon92 mentioned this pull request Jul 26, 2023
Open
20 tasks
helayoty pushed a commit to helayoty/website that referenced this pull request Aug 7, 2023
@kannon92 @tengqm @helayoty
rename PodHasNetwork to PodReadyToStartContainers (kubernetes#40945)
486fcc4 
* rename PodHasNetwork to PodReadyToStartContainers

* add note for condition rename

* add feature gate removal

* Update content/en/docs/reference/command-line-tools-reference/feature-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
helayoty pushed a commit to helayoty/website that referenced this pull request Aug 7, 2023
@kannon92 @tengqm @helayoty
rename PodHasNetwork to PodReadyToStartContainers (kubernetes#40945)
a5a1668 
* rename PodHasNetwork to PodReadyToStartContainers

* add note for condition rename

* add feature gate removal

* Update content/en/docs/reference/command-line-tools-reference/feature-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

* Update content/en/docs/reference/command-line-tools-reference/feature-gates-removed.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>

---------

Co-authored-by: Qiming Teng <tengqm@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@mengjiao-liu mengjiao-liu Awaiting requested review from mengjiao-liu

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@tengqm tengqm Awaiting requested review from tengqm

@sftim sftim Awaiting requested review from sftim

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@kannon92 @ddebroy @tengqm @k8s-ci-robot @sftim @dipesh-rawat