Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stale feature state for device plugin integration with Topology Manager #41846

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jul 3, 2023

Retroactively fix the feature state:

  • device manager GA'd in 1.26
  • topology manager GA'd in 1.27 thus we can safely call the integration between topology and device managers GA in 1.27

Extracted from #41804 (comment)

Retroactively fix the feature state:
- device manager GA'd in 1.26
- topology manager GA'd in 1.27
thus we can safely call the integration between topology and device
managers GA in 1.27

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 3, 2023
@ffromani
Copy link
Contributor Author

ffromani commented Jul 3, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 3, 2023
@netlify
Copy link

netlify bot commented Jul 3, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit df62b9b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64a260726548f5000884f7de
😎 Deploy Preview https://deploy-preview-41846--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shubham82
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3b8700074c9026311adbf94a53e288466d5f4d35

@mengjiao-liu
Copy link
Member

/lgtm

@sftim
Copy link
Contributor

sftim commented Jul 3, 2023

/retitle Fix stale feature state for topology manager, and for device manager integration

@k8s-ci-robot k8s-ci-robot changed the title node: integration with topology manager is stable Fix stale feature state for topology manager, and for device manager integration Jul 3, 2023
@sftim
Copy link
Contributor

sftim commented Jul 3, 2023

Actually
/retitle Fix stale feature state for device plugin integration with Topology Manager

/approve

@k8s-ci-robot k8s-ci-robot changed the title Fix stale feature state for topology manager, and for device manager integration Fix stale feature state for device plugin integration with Topology Manager Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit aa86f39 into kubernetes:main Jul 3, 2023
@ffromani ffromani deleted the devmgr-topomgr-ga branch July 3, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants