-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: fix release state for podresources API #41804
node: fix release state for podresources API #41804
Conversation
Mark the API, needed to monitor the device plugins, as stable Signed-off-by: Francesco Romani <fromani@redhat.com>
content/en/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins.md
Outdated
Show resolved
Hide resolved
/sig node |
/cc @SergeyKanzhelev @swatisehgal |
6b9eb0d
to
3e0e88d
Compare
Thanks, @ffromani |
LGTM label has been added. Git tree hash: c191d71c11991bae6d8cdcf07c5f7542f239fbf4
|
this is the final piece to finalize kubernetes/enhancements#3743 which was mostly (but not completely) merged during the 1.27 cycle, slipped back to 1.28 and whose missing changes got merged at the very beginning of the 1.28 cycle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
from node perspective
/assign @annajung (per bot suggestion) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swatisehgal, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
followup to #41506 (review)
we fix the release state of the podresources API (related to device monitoring)
KEP: kubernetes/enhancements#606
enhancement: kubernetes/enhancements#3743