-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: graduate the podresources API endpoint to GA #41506
Conversation
/cc @ffromani |
thanks a ton! I planned to to this later! appreciated! |
Thanks @carlory, it looks good to me. |
LGTM label has been added. Git tree hash: 010afb917c1aa31aad2947eec682d8c4d6dd36ce
|
from my side I just need to doublecheck if we need to advertise the feature as GA elsewhere in the docs, and then LGTM |
/sig node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we also need to make any change to https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#monitoring-device-plugin-resources ?
we do. We need to change labels here and there (beta -> stable). I'll do a pass and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Since kubernetes/kubernetes#116525 was already merged.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Graduate the kubelet podresources endpoint to GA
KEP: kubernetes/enhancements#606
enhancement: kubernetes/enhancements#3743
reopen #39959 for 1.28