Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: graduate the podresources API endpoint to GA #41506

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

carlory
Copy link
Member

@carlory carlory commented Jun 6, 2023

Graduate the kubelet podresources endpoint to GA

KEP: kubernetes/enhancements#606
enhancement: kubernetes/enhancements#3743

reopen #39959 for 1.28

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 6, 2023 10:30
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 6, 2023
@carlory
Copy link
Member Author

carlory commented Jun 6, 2023

/cc @ffromani

@k8s-ci-robot k8s-ci-robot requested a review from ffromani June 6, 2023 10:32
@ffromani
Copy link
Contributor

ffromani commented Jun 6, 2023

/cc @ffromani

thanks a ton! I planned to to this later! appreciated!

@Shubham82
Copy link
Contributor

Thanks @carlory, it looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 010afb917c1aa31aad2947eec682d8c4d6dd36ce

@ffromani
Copy link
Contributor

ffromani commented Jun 6, 2023

from my side I just need to doublecheck if we need to advertise the feature as GA elsewhere in the docs, and then LGTM

@sftim
Copy link
Contributor

sftim commented Jun 19, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 19, 2023
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ffromani
Copy link
Contributor

ffromani commented Jun 19, 2023

Would we also need to make any change to https://kubernetes.io/docs/concepts/extend-kubernetes/compute-storage-net/device-plugins/#monitoring-device-plugin-resources ?

we do. We need to change labels here and there (beta -> stable). I'll do a pass and issue PRs review/comment later, we have plenty of time luckily

Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Since kubernetes/kubernetes#116525 was already merged.

@tengqm
Copy link
Contributor

tengqm commented Jun 24, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 79ac61b into kubernetes:dev-1.28 Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

7 participants