Support 3rd party device monitoring plugins

[dashpole]

Feature Description

1. As a cluster admin, I want container-level metrics for devices provided by device plugins.
2. As a device vendor, I want to be able to provide device-specific metrics without contributing to core kubernetes.

• One-line feature description (can be used as a release note): Support 3rd party device monitoring plugins

• Primary contact (assignee): @ffromani

• Responsible SIGs: sig-node

• Design proposal link (community repo): KEP: Support Device Monitoring community#2454

• KEP: 606-compute-device-assignment

• Link to e2e and/or unit tests: Coming Soon

• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @vikaschoudhary16 @jiayingz

• Approver (likely from SIG/area to which feature belongs): @derekwaynecarr

• Feature target (which target equals to which milestone):

  • Alpha release target (1.13)
  • Beta release target (1.15)
  • Stable release target (1.20)

• Stable

  • KEP (k/enhancements) update PR(s):
    • KEP-606: finalize podresources API GA graduation #3791
  • Code (k/k) update PR(s):
    • node: create podresources endpoint also on windows kubernetes#115133
  • Docs (k/website) update(s):
    • WIP: node: graduate the podresources API endpoint to GA website#39959

/kind feature
/sig node

[kacole2]

@dashpole this has been added to the 1.12 tracking sheet. Thank you

@justaugustus please add relevant tags to this issue

[justaugustus]

@kacole2 all set!

[vikaschoudhary16]

@dashpole looks like design proposal link should be this one: https://docs.google.com/document/d/1NYnqw-HDQ6Y3L_mk85Q3wkxDtGNWTxpsedsgw4NgWpg/edit

[dashpole]

Agreed, that makes more sense

[justaugustus]

/assign @dashpole

[zparnold]

Hey there! @dashpole I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[dashpole]

@zparnold here is the docs pr placeholder: kubernetes/website#9945

[zparnold]

Thank you @dashpole!

[justaugustus]

@dashpole --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[dashpole]

It can be removed from the milestone

[justaugustus]

Got it. Thanks for the update!

[kacole2]

Hi @dashpole
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. I can see that your original post says Alpha for 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to ping @kacole2 so it can be included in the 1.13 Enhancements Tracking Sheet if it's going to make it.

Thanks!

[kacole2]

/milestone v1.13
/tracked yes

[AishSundar]

@dashpole could you please let us know whats pending for this feature to go to Alpha in 1.13. Do you have a list of pending PRs or issues you can point us to. Thanks

[claurence]

@dashpole there has been no communication on the status. Are we confident this is going to make the v1.13 milestone? Enhancement freeze is tomorrow COB. If there is no communication or update on the PR, this is going to be pulled from the milestone as it doesn't fit with our "stability" theme. If there is no communication after COB tomorrow, an exception will be required to add it back to the milestone. Please let me know where we stand. Thanks!

[dashpole]

KEP: kubernetes/community#2454 should be merged soon, as it is approved by the required people. Once that happens, Ill open the implementation PR, and get working on docs. I still expect this to land in 1.13.

[Atharva-Shinde]

Hello @ffromani @dashpole 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting staying for stage stable for v1.28

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone:v1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would simply need to update the following:

• Get approval from the PRR authors.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[ffromani]

Hello @ffromani @dashpole wave, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting staying for stage stable for v1.28

Here's where this enhancement currently stands:

* [x]  KEP readme using the [latest template](https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template) has been merged into the k/enhancements repo.

* [x]  KEP status is marked as `implementable` for `latest-milestone:v1.28`

* [x]  KEP readme has a [updated detailed test plan section](https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md?plain=1#L257-L328) filled out

* [x]  KEP readme has up to date graduation criteria

* [ ]  KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would simply need to update the following:

* Get approval from the PRR authors.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment)
I think this work is completed, please let me know if there's anything missing. Thanks!

[Atharva-Shinde]

@ffromani Thanks for confirming! With all the requirements fulfilled, I will mark this enhancement as tracked for the Enhancements freeze.

[Rishit-dagli]

Hello @dashpole 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[ffromani]

Hello @dashpole 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi, I'm handling the GA graduation. Please find the relevant PR: kubernetes/website#41804
tracking here: #3743

[Atharva-Shinde]

Hey again @ffromani 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment)
I think this work is completed, please let me know if there's anything missing. Thanks!

As per your comment above I believe that there are no active PR/s remaining that needs to be merged in k/k. But still if there are any k/k related PR/s that we should be tracking for this KEP please link them in the issue description above.

Also please keep the issue description up-to-date with all the PR/s that are associated with this KEP.

As always, we are here to help if any questions come up. Thanks!

[ffromani]

Hey again @ffromani wave

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

* [x]  **All** the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.

* [x]  All code related PR/s are merged or are in merge-ready state ( i.e they have `approved` and `lgtm` labels applied) by the code freeze deadline. This includes any tests related PR/s too.

Hi @Atharva-Shinde , thanks for reaching out. The latest pending item for this work, which slipped in 1.28, was actually moving all the FGs to locked (kubernetes/kubernetes#116525). The PRR for GA stage was already passed: #3791 (comment)
I think this work is completed, please let me know if there's anything missing. Thanks!

As per your comment above I believe that there are no active PR/s remaining that needs to be merged in k/k. But still if there are any k/k related PR/s that we should be tracking for this KEP please link them in the issue description above.

Also please keep the issue description up-to-date with all the PR/s that are associated with this KEP.

As always, we are here to help if any questions come up. Thanks!

Hi @Atharva-Shinde , I'm writing this so I can confirm that all relevant PRs (KEP, code, docs) are merged and from my POV everything looks good for this enhancement. Because I don't have edit access to this (the original) issue, I'm keeping the state up to date in #3743 - the latter covers the GA graduation of this feature.

[Atharva-Shinde]

Hey @dashpole @ffromani 👋 Enhancements Lead here,

Hi @Atharva-Shinde , I'm writing this so I can confirm that all relevant PRs (KEP, code, docs) are merged and from my POV everything looks good for this enhancement. Because I don't have edit access to this (the original) issue, I'm keeping the state up to date in #3743 - the latter covers the GA graduation of this feature.

With all implementation PRs merged as per the issue description from this issue and issue number #3743, this enhancement is now tracked for v1.28 Code Freeze!
kubernetes/kubernetes#115133
kubernetes/kubernetes#116459
kubernetes/kubernetes#115926
kubernetes/kubernetes#116525

[npolshakova]

/remove-label lead-opted-in

[ffromani]

/close

mirroring the status reported in #3743, all work here is done, so I think we can close this issue.

[k8s-ci-robot]

@ffromani: Closing this issue.

In response to this:

/close

mirroring the status reported in #3743, all work here is done, so I think we can close this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.