-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docsy version to v0.7.2 #44015
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -1,7 +1,7 @@ | |||
[submodule "themes/docsy"] | |||
path = themes/docsy | |||
url = https://github.com/google/docsy.git | |||
branch = v0.2.0 | |||
branch = v0.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should bump the minor version one by one and try to review most of the pages to ensure the theme, stylings won't get broken accidentally instead of ignoring over the minor versions.
Some of the CSS styling tied with the theme if I am remembering correctly, direct upgrade will introduce more and more styling issues.
@sftim What is your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can just review the changes in here, https://github.com/google/docsy/releases and call it. (also there is some preview deployments that we can do the preview checks as well??)
IMO, there is no major version change, we can probably just move straight to the latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should bump the minor version one by one and try to review most of the pages to ensure the theme, stylings won't get broken accidentally instead of ignoring over the minor versions.
Yes, I'd do that.
IMO, there is no major version change, we can probably just move straight to the latest.
I'd support that if the major version was greater than or equal to 1. But, it isn't.
@MeenuyD Hi there – do you have a chance to look at the feedback left on this PR? I agree with several folks on this PR that the minor version should be bumped one by one. If you don't have the capacity, it is completely okay to close this PR and come back when you do – thanks! |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Updated the docsy version from v0.2.0 to v0.7.2
#44002