Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docsy version to v0.7.2 #44015

Closed
wants to merge 1 commit into from
Closed

Updated docsy version to v0.7.2 #44015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "themes/docsy"]
path = themes/docsy
url = https://github.com/google/docsy.git
branch = v0.2.0
branch = v0.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should bump the minor version one by one and try to review most of the pages to ensure the theme, stylings won't get broken accidentally instead of ignoring over the minor versions.

Some of the CSS styling tied with the theme if I am remembering correctly, direct upgrade will introduce more and more styling issues.

@sftim What is your opinion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can just review the changes in here, https://github.com/google/docsy/releases and call it. (also there is some preview deployments that we can do the preview checks as well??)

IMO, there is no major version change, we can probably just move straight to the latest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should bump the minor version one by one and try to review most of the pages to ensure the theme, stylings won't get broken accidentally instead of ignoring over the minor versions.

Yes, I'd do that.

IMO, there is no major version change, we can probably just move straight to the latest.

I'd support that if the major version was greater than or equal to 1. But, it isn't.

[submodule "api-ref-generator"]
path = api-ref-generator
url = https://github.com/kubernetes-sigs/reference-docs