Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Update content/ja/docs/contribute/localization.md #49016

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luna029
Copy link

@luna029 luna029 commented Dec 10, 2024

Description

Update content/ja/docs/contribute/localization.md
I have added the points that were pointed out to me when I was working on translation to the translation style guide.

I have one question, so I would like to ask the following.
I found the following page, but is it okay to merge everything into the 'main' branch without worrying about it when translating into Japanese?
https://kubernetes.io/docs/contribute/new-content/#choose-which-git-branch-to-use
https://kubernetes.io/docs/contribute/localization/#branch-strategy

Issue

#49014

Closes: #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bells17 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from b1gb4by December 10, 2024 14:17
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Dec 10, 2024
@k8s-ci-robot k8s-ci-robot requested a review from t-inu December 10, 2024 14:17
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
Copy link

netlify bot commented Dec 10, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e0c85d6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67584d800139120008f4e89f
😎 Deploy Preview https://deploy-preview-49016--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@b1gb4by
Copy link
Contributor

b1gb4by commented Dec 10, 2024

@luna029
The rules for translation are as described in the following link, so the policy of creating a PR for the main branch is fine.

https://kubernetes.io/ja/docs/contribute/localization/#create-pull-request

Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution,

This is a Japanese guideline that affects all contributors to k8s.io/ja, so I will provide comments in Japanese for the review.

Since this is a very sensitive change, it needs to be handled carefully.

Please note that our guidelines have been created through extensive discussions.
e.g., #44938

/hold

Comment on lines +69 to +70
- 例: Kubernetesクラスター
- カッコ`()`の前後にも半角スペースは不要
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 例: Kubernetesクラスター
- カッコ`()`の前後にも半角スペースは不要
- カッコ`()`の前後にも半角スペースは不要
- 例: Kubernetesクラスター

Comment on lines +71 to +72
- 英語の単語間の半角スペースは削除しない
- 例: Kubernetes API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 英語の単語間の半角スペースは削除しない
- 例: Kubernetes API

英語の単語間の半角スペースは削除しない

IMO: これは一般的なので、ここで明記する必要はないように感じました

Comment on lines +77 to +80
- 理解のしやすい表記に変更する
- 例: `Kubernetesセキュリティ`ではなく、`Kubernetesのセキュリティ`を使用する 
- 例: `ベースライン`ではなく、`基本的な`を使用する

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 理解のしやすい表記に変更する
- 例: `Kubernetesセキュリティ`ではなく、`Kubernetesのセキュリティ`を使用する 
- 例: `ベースライン`ではなく、`基本的な`を使用する

IMO: 「理解しやすい」は曖昧な - 主観的な指標なので、ガイドラインには含めたくないです。ガイドラインはシンプルで汎用的なルールを提供するのが目的なので、例の数も必要最小限が望ましいです。

Comment on lines +91 to +101
- そのままの表記を使用する単語リスト
- Kubernetes
- Pod
- Service
- Deployment
- Node
- Namespace
- etcd
- LoadBalancer


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- そのままの表記を使用する単語リスト
- Kubernetes
- Pod
- Service
- Deployment
- Node
- Namespace
- etcd
- LoadBalancer

Kubernetesのリソース名や技術用語などは、原則としてそのままの表記を使用します。 とシンプルなルールを提供しています。
この例はk8sのリソースの列挙で、ルールから判断できる内容なので、加筆する必要はないと思いました

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI: 具体的なリストがあるのはhelpfulかもしれない、ですが、リストのメンテナンスが困難なので、できるだけ具体的なリストを持たない様にした方が管理の都合上良い、というのも背景にあります

@@ -95,14 +112,25 @@ Kubernetesのリソース名や技術用語などは、原則としてそのま
カタカナ語に長音を付与するかどうかは、以下の原則に従ってください。

- -er、-or、-ar、-cy、-gyで終わる単語は長音を付与する
- 例: 「クラスター」「セレクター」「サイドカー」「ポリシー」「トポロジー」
- 例: 「クラスター」「セレクター」「サイドカー」「ポリシー」「トポロジー」「コントローラー」
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 例: 「クラスター」「セレクター」「サイドカー」「ポリシー」「トポロジー」「コントローラー」
- 例: 「クラスター」「セレクター」「サイドカー」「ポリシー」「トポロジー」

-er、-or、-ar、-cy、-gyで終わる単語は長音を付与する

のそれぞれに対応する例を一つずつ書いています。特別「コントローラー」を増やす必要はないように感じました

  • er: cluster
  • or: selector
  • ar: sidecar
  • cy: policy
  • gy: toppology

Comment on lines +123 to +133
### ヘッダーの翻訳 {#header}

ページのヘッダーについては、以下の原則に従ってください。

英語 | 翻訳有無
--------- | ---------
title: | タイトル(翻訳する)
description: | 説明文(翻訳する)
content_type: | content(翻訳しない)
weight: | 100(翻訳しない)

Copy link
Member

@Okabe-Junya Okabe-Junya Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### ヘッダーの翻訳 {#header}
ページのヘッダーについては、以下の原則に従ってください。
英語 | 翻訳有無
--------- | ---------
title: | タイトル(翻訳する)
description: | 説明文(翻訳する)
content_type: | content(翻訳しない)
weight: | 100(翻訳しない)

個人的にはわざわざ書く必要はない( k8s.io/ja の適当なページを見ればわかること)だと思いました。

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2024
@Okabe-Junya
Copy link
Member

/retitle [ja] Update content/ja/docs/contribute/localization.md

@k8s-ci-robot k8s-ci-robot changed the title [ja]content/ja/docs/contribute/localization.md を更新 #49014 [ja] Update content/ja/docs/contribute/localization.md Dec 10, 2024
@Okabe-Junya
Copy link
Member

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja]Update content/ja/docs/contribute/localization.md
5 participants