KEP-4205: update for alpha release in 1.33 #49895

haircommander · 2025-02-25T15:41:25Z

Description

Issue

Closes: #

netlify · 2025-02-25T15:41:45Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`f9ff985`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f3f6b5a3f15a00082e310e

netlify · 2025-02-25T15:51:11Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`f9ff985`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f3f6b56692c400084fcc3a
😎 Deploy Preview	https://deploy-preview-49895--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rayandas · 2025-03-25T05:59:28Z

Hello @haircommander 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th March 2025 18:00 PDT. Thank you!

roycaihw · 2025-03-25T22:49:51Z

Hi @rayandas, I've updated the PR with the documentation content. This PR is ready for review. PTAL. @haircommander Could you update the state of the PR from Draft to Ready for review?

haircommander · 2025-03-26T20:05:23Z

LGTM!

Urvashi0109 · 2025-04-03T11:43:57Z

Hello @roycaihw 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

kannon92 · 2025-04-03T14:06:33Z

content/en/docs/concepts/cluster-administration/system-metrics.md

+
+{{< feature-state for_k8s_version="v1.33" state="alpha" >}}
+
+As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)


Should we mention any requirements on kernel for this?

Good point! I added kernel version requirement to the docs.

kannon92 · 2025-04-03T14:07:31Z

/lgtm

One nit but it is not blocking.

https://github.com/kubernetes/website/pull/49895/files#r2027079949

Technical review is complete on this @Urvashi0109!

k8s-ci-robot · 2025-04-03T14:07:38Z

LGTM label has been added.

Details

Git tree hash: 28ea715784c8a3c0b231281ecebe0b27b028def8

roycaihw · 2025-04-03T21:06:20Z

@Princesso @RainbowMango Could you help review this PR? Thank you!

tengqm · 2025-04-04T08:10:31Z

content/en/docs/concepts/cluster-administration/system-metrics.md

+As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)
+ (PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names:


Please wrap these long lines as we do for other paragraphs.
See sembr.org for the suggested line breaking style.

Suggested change

As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)

(PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names:

As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel

[Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)(PSI)

for CPU, memory and I/O usage.

The information is collected at node, pod and container level.

The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names:

tengqm · 2025-04-04T08:11:06Z

content/en/docs/concepts/cluster-administration/system-metrics.md

+container_pressure_io_waiting_seconds_total
+```
+
+You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to use this feature. The information is also exposed in the [Summary API](/docs/reference/instrumentation/node-metrics#psi).


Suggested change

You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to use this feature. The information is also exposed in the [Summary API](/docs/reference/instrumentation/node-metrics#psi).

You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/)

to use this feature. The information is also exposed in the

[Summary API](/docs/reference/instrumentation/node-metrics#psi).

tengqm · 2025-04-04T08:11:37Z

content/en/docs/reference/command-line-tools-reference/feature-gates/KubeletPSI.md

+    defaultValue: false
+    fromVersion: "1.33"
+---
+Enable Kubelet to surface Pressure Stall Information (PSI) metrics in the Summary API and Prometheus metrics.


We don't write "Kubelet", we write "kubelet".

tengqm · 2025-04-04T08:16:12Z

content/en/docs/reference/instrumentation/node-metrics.md

+
+{{< feature-state for_k8s_version="v1.33" state="alpha" >}}
+
+As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html) (PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. See [Summary API](https://github.com/kubernetes/kubernetes/blob/ef838fcc3fa3b43c2e67b4e43d71b6720fc61898/staging/src/k8s.io/kubelet/pkg/apis/stats/v1alpha1/types.go#L281-L300) for detailed schema. You must enable the `KubeletPSI` [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) to use this feature. The information is also exposed in [Prometheus metrics](/docs/concepts/cluster-administration/system-metrics#psi-metrics).


Break the long "lines".

Avoid pointing users to the Go source code for the Summary API. We can add a config API reference for this.

Done. I switched the Go source code link with https://pkg.go.dev/k8s.io/kubelet/pkg/apis/stats/v1alpha1. PTAL

Add this: #50394

Thank you! Done.

rayandas · 2025-04-08T06:35:22Z

@kannon92 Could you pleas give another lgtm? The previous one was removed because of a new commit.
@tengqm The suggested changes were address. This could use another review. Thanks!

tengqm · 2025-04-08T09:24:42Z

/approve

k8s-ci-robot · 2025-04-08T09:24:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~content/en/docs/OWNERS~~ [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rayandas · 2025-04-08T14:34:43Z

Giving an lgtm as we're near to the Docs Freeze deadline. It was lgtm-ed before however it was removed because of a commit which addressed the Docs review suggestions.
/lgtm

k8s-ci-robot · 2025-04-08T14:34:51Z

LGTM label has been added.

Details

Git tree hash: 606c3d968671cc530395cdfea208967f3812b331

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2025

haircommander mentioned this pull request Feb 25, 2025

Support PSI based on cgroupv2 kubernetes/enhancements#4205

Open

25 tasks

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2025

roycaihw force-pushed the psi-1.33 branch from 9c1fe71 to d6d2b83 Compare March 25, 2025 22:41

k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2025

haircommander marked this pull request as ready for review March 26, 2025 20:04

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2025

k8s-ci-robot requested review from Princesso and RainbowMango March 26, 2025 20:04

haircommander changed the title ~~draft 4205 doc update~~ KEP-4205: update for alpha release in 1.33 Mar 26, 2025

kannon92 reviewed Apr 3, 2025

View reviewed changes

k8s-ci-robot assigned kannon92 Apr 3, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2025

roycaihw force-pushed the psi-1.33 branch from d6d2b83 to 5af320b Compare April 3, 2025 21:01

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2025

k8s-ci-robot requested a review from kannon92 April 3, 2025 21:01

tengqm reviewed Apr 4, 2025

View reviewed changes

roycaihw force-pushed the psi-1.33 branch from 5af320b to a1a0fb1 Compare April 4, 2025 22:23

Kubelet PSI metrics documentation

f9ff985

roycaihw force-pushed the psi-1.33 branch from a1a0fb1 to f9ff985 Compare April 7, 2025 16:00

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2025

k8s-ci-robot assigned rayandas Apr 8, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025

k8s-ci-robot merged commit dd4c0a0 into kubernetes:dev-1.33 Apr 8, 2025
6 checks passed

roycaihw mentioned this pull request Apr 8, 2025

Add cgroup v2 to PSI requirements #50439

Merged

roycaihw mentioned this pull request Jun 10, 2025

PSI-based node conditions kubernetes/enhancements#5394

Open

4 tasks


		{{< feature-state for_k8s_version="v1.33" state="alpha" >}}

		As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)

		As an alpha feature, Kubernetes lets you configure Kubelet to collect Linux kernel [Pressure Stall Information](https://docs.kernel.org/accounting/psi.html)
		(PSI) for CPU, memory and IO usage. The information is collected at node, pod and container level. The metrics are exposed at the `/metrics/cadvisor` endpoint with the following names:

KEP-4205: update for alpha release in 1.33 #49895

KEP-4205: update for alpha release in 1.33 #49895

Uh oh!

Conversation

haircommander commented Feb 25, 2025

Description

Issue

Uh oh!

netlify bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Uh oh!

netlify bot commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Pull request preview available for checking

Uh oh!

rayandas commented Mar 25, 2025

Uh oh!

roycaihw commented Mar 25, 2025

Uh oh!

haircommander commented Mar 26, 2025

Uh oh!

Urvashi0109 commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kannon92 commented Apr 3, 2025

Uh oh!

k8s-ci-robot commented Apr 3, 2025

Uh oh!

roycaihw commented Apr 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rayandas commented Apr 8, 2025

Uh oh!

tengqm commented Apr 8, 2025

Uh oh!

k8s-ci-robot commented Apr 8, 2025

Uh oh!

rayandas commented Apr 8, 2025

Uh oh!

k8s-ci-robot commented Apr 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

netlify bot commented Feb 25, 2025 •

edited

Loading

netlify bot commented Feb 25, 2025 •

edited

Loading

Urvashi0109 commented Apr 3, 2025 •

edited

Loading