Add documentation for TaintNodesByCondition #5352

gmarek · 2017-09-08T11:08:08Z

Documentation for TaintNodesByCondition alpha feature.

This change is

k8sio-netlify-preview-bot · 2017-09-08T11:09:49Z

Deploy preview ready!

Built with commit ac03dd9

https://deploy-preview-5352--kubernetes-io-vnext-staging.netlify.com

davidopp · 2017-09-08T20:55:00Z

docs/concepts/architecture/nodes.md

@@ -67,6 +67,8 @@ If the Status of the Ready condition is "Unknown" or "False" for longer than the

 In versions of Kubernetes prior to 1.5, the node controller would [force delete](/docs/concepts/workloads/pods/pod/#force-deletion-of-pods) these unreachable pods from the apiserver. However, in 1.5 and higher, the node controller does not force delete pods until it is confirmed that they have stopped running in the cluster. One can see these pods which may be running on an unreachable node as being in the "Terminating" or "Unknown" states. In cases where Kubernetes cannot deduce from the underlying infrastructure if a node has permanently left a cluster, the cluster administrator may need to delete the node object by hand.  Deleting the node object from Kubernetes causes all the Pod objects running on it to be deleted from the apiserver, freeing up their names.

+In version 1.8 a possibility to automatically create [taints](/docs/concepts/configuration/taint-and-toleration) representing Conditions was added as an alpha feature. Enabling it makes scheduler ignore Conditions when considering a Node, instead it looks at the taints and Pod's tolerations. This allows users to decide whether they want to keep old behavior and don't schedule their Pods on Nodes with some Conditions, or rather corresponding taints, or if they want to add a toleration and allow it. Note that because of small delay (usually <1s) between time when Condition is observed and Taint is created it's possible that enabling this feature will slightly increase number of Pods that are successfully scheduled but rejected by the Kubelet.


Please list what is the command-line flag to enable the feature, and which components you need to pass that command-line flag to.

davidopp · 2017-09-08T20:58:11Z

docs/concepts/configuration/taint-and-toleration.md

+
+## Taint Nodes by Condition
+
+In Kuberentes 1.8 we added an alpha feature that makes NodeController create Taints matching Node Conditions and in the same time disables Condition check in scheduler. This assures that Conditions doesn't have influence on what's scheduled on the Node and that user


I would say "In Kubernetes 1.8 we added an alpha feature that makes NodeController create taints corresponding to node conditions, and disables the condition check in the scheduler (instead the scheduler checks the taints). This assures that Conditions don't affect what's scheduled onto the node and the user can choose to ignore some of the node's problems (represented as Conditions) by adding appropriate pod tolerations."

BTW in the future please please please do not put each paragraph in a single line, it makes it hard to comment in Github.

steveperry-53 · 2017-09-08T22:19:30Z

@gmarek, I have some suggestions for the new text, and it would be easiest if I could do an edit pass. Can you check the Allow edits by maintainers check box in the right column? Thanks.

k82cn · 2017-09-09T01:50:15Z

docs/concepts/workloads/controllers/daemonset.md


 This ensures that when the `TaintBasedEvictions` alpha feature is enabled,
 they will not be evicted when there are node problems such as a network partition. (When the
 `TaintBasedEvictions` feature is not enabled, they are also not evicted in these scenarios, but
 due to hard-coded behavior of the NodeController rather than due to tolerations).

+ They also tolerate following `NoSchedule` taints:
+ - `node.kubernetes.io/memoryPressure`
+ - `node.kubernetes.io/diskPressure`


kubernetes/kubernetes#51246 proposed a new name of those taints, should we update them in 1.8.

maybe we can just fix line 106-107 instead of introducing a new list for user to merge in mind?

Those are completely different things and separate features which can be enabled separately. I think the danger of mixing them is bigger than inconvenience of having two separate lists.

oh really?
The code seems make no differentiation among them:
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/daemon_controller.go#L1147

yastij · 2017-09-11T09:14:16Z

docs/concepts/configuration/taint-and-toleration.md

@@ -249,9 +249,18 @@ admission controller](https://git.k8s.io/kubernetes/plugin/pkg/admission/default

  * `node.alpha.kubernetes.io/unreachable`
  * `node.alpha.kubernetes.io/notReady`
+
+This ensures that DaemonSet pods are never evicted due to these problems,
+which matches the behavior when this feature is disabled.


Maybe add that the admin can always add other tolerations for ds if he wants ?

There's a line about adding tolerations to arbitrary Pods. I can add explicit mention of DeamonSets, but I'm not sure where and how to phrase it.

I think expliciting it here should be just fine, maybe like #49784(comment) ?

steveperry-53 · 2017-09-11T20:57:28Z

@gmarek, See three recent commits for suggested edits.

And here are a few things in addition to the commits:

In nodes.md, aplpha -> alpha (my mistake).
In nodes.md, where it says "pass an additional feature gate flag", the API server -> to the API server.
In taint-and-toleration.md, builtin -> built-in.
In taint-and-toleration.md, deamons -> daemons.
in daemonsets.md, add a blank line after, "They also tolerate following NoSchedule taints:".

gmarek · 2017-09-12T07:24:20Z

Everything is fine. I'm as far from native speaker as possible and I'm not particularly attached to the text I write;)

steveperry-53 · 2017-09-12T16:48:51Z

@tengqm, @yastij, @davidop, @k82cn, Are all the technical issues resolved? If so, can one of you apporve. Thanks

@chenopis

* GC now supports non-core resources * Add two examples about how to analysis audits of kube-apiserver (#4264) * Deprecate system:nodes binding * [1.8] StatefulSet `initialized` annotation is now ignored. * inits the kubeadm upgrade docs addresses /issues/4689 * adds kubeadm upgrade cmd to ToC addresses /issues/4689 * add workload placement docs * ScaleIO - document udpate for 1.8 * Add documentation on storageClass.mountOptions and PV.mountOptions (#5254) * Add documentation on storageClass.mountOptions and PV.mountOptions * convert notes into callouts * Add docs for CustomResource validation add info about supported fields * advanced audit beta features (#5300) * Update job workload doc with backoff failure policy (#5319) Add to the Jobs documentation how to use the new backoffLimit field that limit the number of Pod failure before considering the Job as failed. * Documented additional AWS Service annotations (#4864) * Add device plugin doc under concepts/cluster-administration. (#5261) * Add device plugin doc under concepts/cluster-administration. * Update device-plugins.md * Update device-plugins.md Add meta description. Fix typo. Change bare metal deployment to manual deployment. * Update device-plugins.md Fix typo again. * Update page.version. (#5341) * Add documentation on storageClass.reclaimPolicy (#5171) * [Advanced audit] use new herf for audit-api (#5349) This tag contains all the changes in v1beta1 version. Update it now. * Added documentation around creating the InitializerConfiguration for the persistent volume label controller in the cloud-controller-manager (#5255) * Documentation for kubectl plugins (#5294) * Documentation for kubectl plugins * Update kubectl-plugins.md * Update kubectl-plugins.md * Updated CPU manager docs to match implementation. (#5332) * Noted limitation of alpha static cpumanager. * Updated CPU manager docs to match implementation. - Removed references to CPU pressure node condition and evictions. - Added note about new --cpu-manager-reconcile-period flag. - Added note about node allocatable requirements for static policy. - Noted limitation of alpha static cpumanager. * Move cpu-manager task link to rsc mgmt section. * init containers annotation removed in 1.8 (#5390) * Add documentation for TaintNodesByCondition (#5352) * Add documentation for TaintNodesByCondition * Update nodes.md * Update taint-and-toleration.md * Update daemonset.md * Update nodes.md * Update taint-and-toleration.md * Update daemonset.md * Fix deployments (#5421) * Document extended resources and OIR deprecation. (#5399) * Document extended resources and OIR deprecation. * Updated extended resources doc per reviews. * reverts extra spacing in _data/tasks.yml * addresses `kubeadm upgrade` review comments Feedback from @chenopis, @luxas, and @steveperry-53 addressed with this commit * HugePages documentation (#5419) * Update cpu-management-policies.md (#5407) Fixed the bad link. Modified "cpu" to "CPU". Added more 'yaml' as supplement. * Update RBAC docs for v1 (#5445) * Add user docs for pod priority and preemption (#5328) * Add user docs for pod priority and preemption * Update pod-priority-preemption.md * More updates * Update docs/admin/kubeadm.md for 1.8 (#5440) - Made a couple of minor wording changes (not strictly 1.8 related). - Did some reformatting (not strictly 1.8 related). - Updated references to the default token TTL (was infinite, now 24 hours). - Documented the new `--discovery-token-ca-cert-hash` and `--discovery-token-unsafe-skip-ca-verification` flags for `kubeadm join`. - Added references to the new `--discovery-token-ca-cert-hash` flag in all the default examples. - Added a new _Security model_ section that describes the security tradeoffs of the various discovery modes. - Documented the new `--groups` flag for `kubeadm token create`. - Added a note of caution under _Automating kubeadm_ that references the _Security model_ section. - Updated the component version table to drop 1.6 and add 1.8. - Update `_data/reference.yml` to try to get the sidebar fixed up and more consistent with `kubefed`. * Update StatefulSet Basics for 1.8 release (#5398) * addresses `kubeadm upgrade` review comments 2nd iteration review comments by @luxas * adds kubelet upgrade section to kubeadm upgrade * Fix a bulleted list on docs/admin/kubeadm.md. (#5458) I updated this doc yesterday and I was absolutely sure I fixed this, but I just saw that this commit got lost somehow. This was introduced recently in #5440. * Clarify the API to check for device plugins * Moving Flexvolume to separate out-of-tree section * addresses `kubeadm upgrade` review comments CC: @luxas * fixes kubeadm upgrade index * Update Stackdriver Logging documentation (#5495) * Re-update WordPress and MySQL PV doc to use apps/v1beta2 APIs (#5526) * Update statefulset concepts doc to use apps/v1beta2 APIs (#5420) * add document on kubectl's behavior regarding initializers (#5505) * Update docs/admin/kubeadm.md to cover self-hosting in 1.8. (#5497) This is a new beta feature in 1.8. * Update kubectl patch doc to use apps/v1beta2 APIs (#5422) * [1.8] Update "Run Applications" tasks to apps/v1beta2. (#5525) * Update replicated stateful application task for 1.8. * Update single instance stateful app task for 1.8. * Update stateless app task for 1.8. * Update kubectl patch task for 1.8. * fix the link of persistent storage (#5515) * update the admission-controllers.md index.md what-is-kubernetes.md link * fix the link of persistent storage * Add quota support for local ephemeral storage (#5493) * Add quota support for local ephemeral storage update the doc to this alpha feature * Update resource-quotas.md * Updated Deployments concepts doc (#5491) * Updated Deployments concepts doc * Addressed comments * Addressed more comments * Modify allocatable storage to ephemeral-storage (#5490) Update the doc to use ephemeral-storage instead of storage * Revamped concepts doc for ReplicaSet (#5463) * Revamped concepts doc for ReplicaSet * Minor changes to call out specific versions for selector defaulting and immutability * Addressed doc review comments * Remove petset documentations (#5395) * Update docs to use batch/v1beta1 cronjobs (#5475) * add federation job doc (#5485) * add federation job doc * Update job.md Edits for clarity and consistency * Update job.md Fixed a typo * update DaemonSet concept for 1.8 release (#5397) * update DaemonSet concept for 1.8 release * Update daemonset.md Fix typo. than -> then * Update bootstrap tokens doc for 1.8. (#5479) * Update bootstrap tokens doc for 1.8. This has some changes I missed when I was updating the main kubeadm documention: - Bootstrap tokens are now beta, not alpha (kubernetes/enhancements#130) - The apiserver flag to enable the authenticator changedin 1.8 (kubernetes/kubernetes#51198) - Added `auth-extra-groups` documentaion (kubernetes/kubernetes#50933) - Updated the _Token Management with `kubeadm`_ section to link to the main kubeadm docs, since it was just duplicated information. * Update bootstrap-tokens.md * Updated the Cassandra tutorial to use apps/v1beta2 (#5548) * add docs for AllowPrivilegeEscalation (#5448) Signed-off-by: Jess Frazelle <acidburn@microsoft.com> * Add local ephemeral storage alpha feature in managing compute resource (#5522) * Add local ephemeral storage alpha feature in managing compute resource Since 1.8, we add the local ephemeral storage alpha feature as one resource type to manage. Add this feature into the doc. * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Update manage-compute-resources-container.md * Added documentation for Metrics Server (#5560) * authorization: improve authorization debugging docs (#5549) * Document mount propagation (#5544) * Update /docs/setup/independent/create-cluster-kubeadm.md for 1.8. (#5524) This introduction needed a couple of small tweaks to cover the `--discovery-token-ca-cert-hash` flag added in kubernetes/kubernetes#49520 and some version bumps. * Add task doc for alpha dynamic kubelet configuration (#5523) * Fix input/output of selfsubjectaccess review (#5593) * Add docs for implementing resize (#5528) * Add docs for implementing resize * Update admission-controllers.md * Added link to PVC section * minor typo fixes * Update NetworkPolicy concept guide with egress and CIDR changes (#5529) * update zookeeper tutorial for 1.8 release * add doc for hostpath type (#5503) * Federated Hpa feature doc (#5487) * Federated Hpa feature doc * Federated Hpa feature doc review fixes * Update hpa.md * Update hpa.md * update cloud controller manager docs for v1.8 * Update cronjob with defaults information (#5556) * Kubernetes 1.8 reference docs (#5632) * Kubernetes 1.8 reference docs * Kubectl reference docs for 1.8 * Update side bar with 1.8 kubectl and api ref docs links * remove petset.md * update on state of HostAlias in 1.8 with hostNetwork Pod support (#5644) * Fix cron job deletion section (#5655) * update imported docs (#5656) * Add documentation for certificate rotation. (#5639) * Link to using kubeadm page * fix the command output fix the command output * fix typo in api/resources reference: "Worloads" * Add documentation for certificate rotation. * Create TOC entry for cloud controller manager. (#5662) * Updates for new versions of API types * Followup 5655: fix link to garbage collection (#5666) * Temporarily redirect resources-reference to api-reference. (#5668) * Update config for 1.8 release. (#5661) * Update config for 1.8 release. * Address reviewer comments. * Switch references in HPA docs from alpha to beta (#5671) The HPA docs still referenced the alpha version. This switches them to talk about v2beta1, which is the appropriate version for Kubernetes 1.8 * Deprecate openstack heat (#5670) * Fix typo in pod preset conflict example Move container port definition to the correct line. * Highlight openstack-heat provider deprecation The openstack-heat provider for kube-up is being deprecated and will be removed in a future release. * Temporarily fix broken links by redirecting. (#5672) * Fix broken links. (#5675) * Fix render of code block (#5674) * Fix broken links. (#5677) * Add a small note about auto-bootstrapped CSR ClusterRoles (#5660) * Update kubeadm install doc for v1.8 (#5676) * add draft workloads api content for 1.8 (#5650) * add draft workloads api content for 1.8 * edits per review, add tables, for 1.8 workloads api doc * fix typo * Minor fixes to kubeadm 1.8 upgrade guide. (#5678) - The kubelet upgrade instructions should be done on every host, not just worker nodes. - We should just upgrade all packages, instead of calling out kubelet specifically. This will also upgrade kubectl, kubeadm, and kubernetes-cni, if installed. - Draining nodes should also ignore daemonsets, and master errors can be ignored. - Make sure that the new kubeadm download is chmoded correctly. - Add a step to run `kubeadm version` to verify after downloading. - Manually approve new kubelet CSRs if rotation is enabled (known issue). * Release 1.8 (#5680) * Fix versions for 1.8 API ref docs * Updates for 1.8 kubectl reference docs * Kubeadm /docs/admin/kubeadm.md cleanup, editing. (#5681) * Update docs/admin/kubeadm.md (mostly 1.8 related). This is Fabrizio's work, which I'm committing along with my edits (in a commit on top of this). * A few of my own edits to clarify and clean up some Markdown.

gmarek assigned davidopp and k82cn Sep 8, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2017

davidopp reviewed Sep 8, 2017

View reviewed changes

steveperry-53 added the Docs Review: Open Issues label Sep 8, 2017

k82cn reviewed Sep 9, 2017

View reviewed changes

davidopp mentioned this pull request Sep 9, 2017

NodeController should add NoSchedule taints and we should get rid of getNodeConditionPredicate() kubernetes/kubernetes#42001

Closed

7 tasks

yastij reviewed Sep 11, 2017

View reviewed changes

gmarek force-pushed the taints branch from 51ffed7 to c6ea618 Compare September 11, 2017 09:18

Add documentation for TaintNodesByCondition

268411f

gmarek force-pushed the taints branch from c6ea618 to 268411f Compare September 11, 2017 10:14

steveperry-53 added 3 commits September 11, 2017 13:35

Update nodes.md

7e150d6

Update taint-and-toleration.md

9e97bea

Update daemonset.md

eeafda3

steveperry-53 added 3 commits September 12, 2017 09:40

Update nodes.md

670944e

Update taint-and-toleration.md

1a28e20

Update daemonset.md

ac03dd9

steveperry-53 added Docs LGTM and removed Docs Review: Open Issues labels Sep 12, 2017

steveperry-53 added the Tech Review: Open Issues label Sep 12, 2017

tengqm approved these changes Sep 12, 2017

View reviewed changes

steveperry-53 added Tech Review LGTM and removed Tech Review: Open Issues labels Sep 12, 2017

steveperry-53 merged commit 83509af into kubernetes:release-1.8 Sep 12, 2017

steveperry-53 added this to the 1.8 milestone Sep 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add documentation for TaintNodesByCondition #5352

Add documentation for TaintNodesByCondition #5352

gmarek commented Sep 8, 2017 •

edited by k8s-reviewable

Loading

k8sio-netlify-preview-bot commented Sep 8, 2017 •

edited

Loading

davidopp Sep 8, 2017

gmarek Sep 11, 2017

davidopp Sep 8, 2017

gmarek Sep 11, 2017

steveperry-53 commented Sep 8, 2017

k82cn Sep 9, 2017

tengqm Sep 10, 2017

gmarek Sep 11, 2017

tengqm Sep 11, 2017

yastij Sep 11, 2017 •

edited

Loading

gmarek Sep 11, 2017

yastij Sep 11, 2017 •

edited

Loading

steveperry-53 commented Sep 11, 2017 •

edited

Loading

gmarek commented Sep 12, 2017

steveperry-53 commented Sep 12, 2017

		@@ -67,6 +67,8 @@ If the Status of the Ready condition is "Unknown" or "False" for longer than the

		In versions of Kubernetes prior to 1.5, the node controller would [force delete](/docs/concepts/workloads/pods/pod/#force-deletion-of-pods) these unreachable pods from the apiserver. However, in 1.5 and higher, the node controller does not force delete pods until it is confirmed that they have stopped running in the cluster. One can see these pods which may be running on an unreachable node as being in the "Terminating" or "Unknown" states. In cases where Kubernetes cannot deduce from the underlying infrastructure if a node has permanently left a cluster, the cluster administrator may need to delete the node object by hand. Deleting the node object from Kubernetes causes all the Pod objects running on it to be deleted from the apiserver, freeing up their names.

		In version 1.8 a possibility to automatically create [taints](/docs/concepts/configuration/taint-and-toleration) representing Conditions was added as an alpha feature. Enabling it makes scheduler ignore Conditions when considering a Node, instead it looks at the taints and Pod's tolerations. This allows users to decide whether they want to keep old behavior and don't schedule their Pods on Nodes with some Conditions, or rather corresponding taints, or if they want to add a toleration and allow it. Note that because of small delay (usually <1s) between time when Condition is observed and Taint is created it's possible that enabling this feature will slightly increase number of Pods that are successfully scheduled but rejected by the Kubelet.


		## Taint Nodes by Condition

		In Kuberentes 1.8 we added an alpha feature that makes NodeController create Taints matching Node Conditions and in the same time disables Condition check in scheduler. This assures that Conditions doesn't have influence on what's scheduled on the Node and that user

Add documentation for TaintNodesByCondition #5352

Add documentation for TaintNodesByCondition #5352

Conversation

gmarek commented Sep 8, 2017 • edited by k8s-reviewable Loading

k8sio-netlify-preview-bot commented Sep 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveperry-53 commented Sep 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yastij Sep 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yastij Sep 11, 2017 • edited Loading

Choose a reason for hiding this comment

steveperry-53 commented Sep 11, 2017 • edited Loading

gmarek commented Sep 12, 2017

steveperry-53 commented Sep 12, 2017

gmarek commented Sep 8, 2017 •

edited by k8s-reviewable

Loading

k8sio-netlify-preview-bot commented Sep 8, 2017 •

edited

Loading

yastij Sep 11, 2017 •

edited

Loading

yastij Sep 11, 2017 •

edited

Loading

steveperry-53 commented Sep 11, 2017 •

edited

Loading