fix admission plugins orders #6900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix admission plugins orders, MutatingAdmissionWebhook should be ahead of ValidatingAdmissionWebhook. see https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/options/admission.go#L69
k8s-ci-robot
added
cncf-cla: yes
|
/assign @tengqm |
|
Deploy preview ready! Built with commit 1ad787a https://deploy-preview-6900--kubernetes-io-master-staging.netlify.com |
tengqm
approved these changes
Jan 9, 2018
There was a problem hiding this comment.
According to the source code, there are comments like this:
// This list is mix of mutating admission plugins and validating
// admission plugins. The apiserver always runs the validating ones
// after all the mutating ones, so their relative order in this list
// doesn't matter.
So, if the code works as designed, the order should not matter. However, moving mutating ahead of validating sounds a better recommendation.
|
@tengqm That's what i mean to, we should not mislead users. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
chenopis
added a commit
that referenced
this pull request
Jan 12, 2018
…henopis-user-journeys * 'master' of https://github.com/kubernetes/website: fix admission plugins orders (#6900) link to other terms (#6625) Fix See Also links. (#6948) --experimental-nvidia-gpus error (#6527) Add HA guide for kubeadm (#6458) remove duplicated and conflicted TOC instrument fix deadlink Clarify the token webhook posts the TokenReview object Update federation.md Update create-cluster-kubeadm.md Add note about viewing changes locally. (#6936) Create page that lists supported doc versions. (#6882) Document how to generate reference pages. (#6366) Update networking.md to list ACI CNI plugin (#6367) Update kubeadm-init.md (#6932) fix typo in doc kubeadm-alpha dulplicated sentences Update certificates.md Replace all kube-ui with kubernetes dashboard Add openstack internal load balancer option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix admission plugins orders, MutatingAdmissionWebhook should be ahead of ValidatingAdmissionWebhook.
see https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/options/admission.go#L69
This change is