Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix admission plugins orders and update explanation #6958

Merged

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Jan 14, 2018

Seems #6900 forgot to update the explanation, which makes confusion.

/cc @hzxuzhonghu
/assign @steveperry-53


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6bdde19

https://deploy-preview-6958--kubernetes-io-master-staging.netlify.com

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2018
@zhangxiaoyu-zidif
Copy link
Contributor

ping @hzxuzhonghu

@hzxuzhonghu
Copy link
Member

/lgtm

@zhangxiaoyu-zidif zhangxiaoyu-zidif merged commit b66117c into kubernetes:master Jan 16, 2018
@dixudx dixudx deleted the doc_admission_plugin_order branch January 16, 2018 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants