Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change 1 Hours Time range typo #1001

Closed
Sherlock113 opened this issue Jul 29, 2020 · 2 comments · Fixed by #2276
Closed

Cannot change 1 Hours Time range typo #1001

Sherlock113 opened this issue Jul 29, 2020 · 2 comments · Fixed by #2276
Assignees
@leoendless
Labels
area/console good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/low
Milestone
3.0.0

Comments

@Sherlock113
Copy link
Contributor

"1 Hours" should be "1 Hour". This cannot be changed directly in the locales file. I guess the key needs to be different for plural and singular forms.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Custom Monitoring Dashboards.
  2. Click Create
  3. Enter a name to create a dashboard
  4. In the drop-down menu, you can find the "1 Hours" typo

截屏2020-07-29上午10 05 03
@Sherlock113 Sherlock113 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 29, 2020
@rayzhou2017 rayzhou2017 added this to the 3.0.0 milestone Jul 29, 2020
@harrisonliu5
Copy link
Contributor

/good-first-issue

@ks-ci-bot
Copy link
Collaborator

@harrisonliu5:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 21, 2021
@live77 live77 mentioned this issue Sep 22, 2021
Merged
ks-ci-bot added a commit that referenced this issue Oct 13, 2021
@ks-ci-bot
Merge pull request #2276 from live77/fix/1_hours_typo
c25fefd 
fix: Cannot change 1 Hours Time range typo #1001
harrisonliu5 pushed a commit that referenced this issue Oct 17, 2023
@weili520
fix: No termination seconds in multi project (#1001)
943e49c 
Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
@yazhouio yazhouio mentioned this issue Oct 18, 2023
Merged
ks-ci-bot pushed a commit that referenced this issue Oct 18, 2023
@yazhouio @weili520
fix: No termination seconds in multi project (#1001) (#4207)
970fd81 
Signed-off-by: TheYoungManLi <cjl@kubesphere.io>
Co-authored-by: cjl <33231138+weili520@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leoendless leoendless

Labels
area/console good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/low
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

fix: Cannot change 1 Hours Time range typo #1001
5 participants
@leoendless @harrisonliu5 @rayzhou2017 @ks-ci-bot @Sherlock113