-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot change 1 Hours Time range typo #1001 #2276
Conversation
Hi @live77. Thanks for your PR. I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @leoendless @harrisonliu5 @Sherlock113 |
@live77: GitHub didn't allow me to assign the following users: Sherlock113. Note that only kubesphere members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Patrick-LuoYu |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @live77 thanks for helping on this issue. I guess you probably need to pay attention on the following label do-not-merge/release-note-label-needed
That means you need to provide a release note.
The following comment is needed:
/lgtm |
LGTM label has been added. Git tree hash: a94ccbe41780399f25606b3d3e5dae5d36a0ea4c
|
@harrisonliu5 This is a bug on the custom monitoring dashboard creation page (Custom Monitoring > Create > Next). Please take a look. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harrisonliu5, live77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1001
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.:
Fixed 1 hours -> 1 hour