Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot change 1 Hours Time range typo #1001 #2276

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: Cannot change 1 Hours Time range typo #1001 #2276

merged 1 commit into from
Oct 13, 2021

Conversation

live77
Copy link
Contributor

@live77 live77 commented Sep 22, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1001

Special notes for reviewers:

Does this PR introduced a user-facing change?

fix: Cannot change 1 Hours Time range typo

Additional documentation, usage docs, etc.:


Fixed 1 hours -> 1 hour
截屏2021-09-22 下午4 59 30

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Sep 22, 2021
@ks-ci-bot
Copy link
Collaborator

Hi @live77. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@live77
Copy link
Contributor Author

live77 commented Sep 24, 2021

/assign @leoendless @harrisonliu5 @Sherlock113

@ks-ci-bot
Copy link
Collaborator

@live77: GitHub didn't allow me to assign the following users: Sherlock113.

Note that only kubesphere members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @leoendless @harrisonliu5 @Sherlock113

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harrisonliu5
Copy link
Contributor

/assign @Patrick-LuoYu

@zheng1
Copy link
Member

zheng1 commented Sep 27, 2021

/ok-to-test

Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @live77 thanks for helping on this issue. I guess you probably need to pay attention on the following label do-not-merge/release-note-label-needed

That means you need to provide a release note.

The following comment is needed:

image

@patrickluoyu
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a94ccbe41780399f25606b3d3e5dae5d36a0ea4c

@patrickluoyu
Copy link
Contributor

@harrisonliu5 This is a bug on the custom monitoring dashboard creation page (Custom Monitoring > Create > Next). Please take a look.

@harrisonliu5
Copy link
Contributor

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, live77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note and removed do-not-merge/release-note-label-needed labels Oct 13, 2021
@ks-ci-bot ks-ci-bot merged commit c25fefd into kubesphere:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change 1 Hours Time range typo
7 participants