-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Notification condition filter custom tag value validation rules. #2832
fix: Notification condition filter custom tag value validation rules. #2832
Conversation
Signed-off-by: xuliwenwenwen <liwenxu@yunify.com>
/assign @weili520 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harrisonliu5, xuliwenwenwen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-3.2 |
@harrisonliu5: once the present PR merges, I will cherry-pick it on top of release-3.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 83eb1aca216db45e190dd547c912af7a36721e01
|
@harrisonliu5: new pull request created: #2836 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: xuliwenwenwen liwenxu@yunify.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes ##2816
Special notes for reviewers:
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: