Apply monitoring linter #1771
Merged
Apply monitoring linter #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
assafad
force-pushed
the
monitoring-linters
branch
3 times, most recently
from
094830a to
ffb36a3
Compare
Apply monitoringlinter, which is designed to enforce kubevirt/community#219 by ensuring that monitoring-related practices are implemented within the pkg/monitoring directory using operator-observability methods. Signed-off-by: assafad <aadmi@redhat.com>
assafad
force-pushed
the
monitoring-linters
branch
from
ffb36a3 to
d869fd1
Compare
|
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
|
Thanks /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oshoval The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Apply monitoringlinter that was implemented in kubevirt/monitoring#221, and was designed to enforce kubevirt/community#219.
This linter ensures that all monitoring-related practices are implemented within the
pkg/monitoringdirectory using operator-observability methods. It verifies that all metrics, alerts and recording rules registrations are centralized in this directory, and restricts the direct use of Prometheus registration methods.Example for a message reported by the linter:
Fixes https://issues.redhat.com/browse/CNV-36763
Other PRs references: kubevirt/hyperconverged-cluster-operator#2827, kubevirt/kubevirt#11454, kubevirt/ssp-operator#932
Release note: