Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply monitoring linter #1771

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Apply monitoring linter #1771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ GITHUB_RELEASE ?= $(BIN_DIR)/github-release

CONTROLLER_GEN ?= $(BIN_DIR)/controller-gen

MONITORING_LINTER ?= $(BIN_DIR)/monitoringlinter

GO := $(GOBIN)/go

$(GO):
Expand Down Expand Up @@ -214,6 +216,9 @@ generate-doc:
lint-metrics:
./hack/prom_metric_linter.sh --operator-name="kubevirt" --sub-operator-name="cnao"

lint-monitoring:
GOBIN=$$(pwd)/build/_output/bin/ $(GO) install -mod=mod github.com/kubevirt/monitoring/monitoringlinter/cmd/monitoringlinter@e2be790
$(MONITORING_LINTER) ./...

.PHONY: \
$(E2E_SUITES) \
Expand Down Expand Up @@ -248,5 +253,6 @@ lint-metrics:
prom-rules-verify \
release \
update-workflows-branches \
statify-components
statify-components \
lint-monitoring

1 change: 1 addition & 0 deletions automation/check-patch.unit-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ main() {
make check
verify_metrics_docs_updated
make lint-metrics
make lint-monitoring
make docker-build
}

Expand Down
Loading