Skip to content

Commit

Permalink
API: Use new token generation SSP API (#3087)
Browse files Browse the repository at this point in the history
The token generation API was stabilized in the SSP,
and feature gate was removed:
kubevirt/ssp-operator#1018

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
  • Loading branch information
akrejcir authored Oct 17, 2024
1 parent cf24cf1 commit ff9b71e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 3 additions & 1 deletion controllers/operands/ssp.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ func NewSSP(hc *hcov1beta1.HyperConverged, opts ...string) (*sspv1beta2.SSP, []h
}

if hc.Spec.FeatureGates.DeployVMConsoleProxy != nil {
spec.FeatureGates.DeployVmConsoleProxy = *hc.Spec.FeatureGates.DeployVMConsoleProxy
spec.TokenGenerationService = &sspv1beta2.TokenGenerationService{
Enabled: *hc.Spec.FeatureGates.DeployVMConsoleProxy,
}
}

// Disable common-instancetypes deployment by SSP from 4.16, now handled by virt-operator
Expand Down
3 changes: 2 additions & 1 deletion controllers/operands/ssp_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,8 @@ var _ = Describe("SSP Operands", func() {
expectedResource, _, err := NewSSP(hco)
Expect(err).ToNot(HaveOccurred())

Expect(expectedResource.Spec.FeatureGates.DeployVmConsoleProxy).To(BeTrue())
Expect(expectedResource.Spec.TokenGenerationService).ToNot(BeNil())
Expect(expectedResource.Spec.TokenGenerationService.Enabled).To(BeTrue())
})

It("should create with deployCommonInstancetypes feature gate disabled", func() {
Expand Down
3 changes: 0 additions & 3 deletions docs/cluster-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,6 @@ the [dataImportCronTemplates field](#configure-custom-golden-images), even if th
Set the `deployVmConsoleProxy` feature gate to true to allow SSP operator to deploy its resources. SSP operator will
deploy a proxy that provides an access to the VNC console of a KubeVirt Virtual Machine (VM).

**Note**: Once `deployVmConsoleProxy` is set to true, SSP operator will not delete deployed resources if `deployVmConsoleProxy` is
reverted back to false.

**Default**: `false`

### deployKubeSecondaryDNS Feature Gate
Expand Down

0 comments on commit ff9b71e

Please sign in to comment.