-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add a config option for vm-console-proxy and deprecate the feature gate #1018
Conversation
- Deprecated the feature gate for vm-console-proxy. It is now ignored. - Added a new field .spec.tokenGenerationService to configure if vm-console-proxy should be enabled or not. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I only thought that pinging 3 reviewers was enough. It wasn't my intention to not mention you. Good idea to mention people that originally wrote the code that I've changed. I will do that in future PRs. |
/retest |
@codingben Please add the lgtm tag when you are done with your review. |
Usually in kubevirt/kubevirt we're waiting to get |
We need both, |
/lgtm |
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 This commit removes the same feature gate from HCO, and adds a new field in the .spec to enable this feature. Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
The token generation API was stabilized in the SSP, and feature gate was removed: kubevirt/ssp-operator#1018 Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
What this PR does / why we need it:
These changes are in this PR:
vm-console-proxy
. It is now ignored..spec.tokenGenerationService
to configure ifvm-console-proxy
should be enabled or not.Which issue(s) this PR fixes:
Jira: https://issues.redhat.com/browse/CNV-45064
Release note: