Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround to trigger upgrade #1323

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented May 5, 2021

Restart OLM pods (olm-operator and catalog-operator) just after patching the subscription to the new channel contains v100.0.0 to trigger OLM upgrade process.

Temporary workaround until root cause will be identified and fixed.

Release note:

NONE

@orenc1 orenc1 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2021
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels May 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link
Collaborator

coveralls commented May 5, 2021

Pull Request Test Coverage Report for Build 1303655222

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.208%

Totals Coverage Status
Change from base Build 1287422147: 0.0%
Covered Lines: 3392
Relevant Lines: 4973

💛 - Coveralls

@orenc1
Copy link
Collaborator Author

orenc1 commented Oct 3, 2021

/retest

@nunnatsa
Copy link
Collaborator

nunnatsa commented Oct 4, 2021

/override-bot

@orenc1 orenc1 changed the title [do not merge] Blank PR to test CI stability Temporary workaround to trigger upgrade Oct 4, 2021
@orenc1 orenc1 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2021
Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2021
@hco-bot
Copy link
Collaborator

hco-bot commented Oct 4, 2021

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 4, 2021

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -150,6 +150,10 @@ HCO_SUBSCRIPTION=$(${CMD} get subscription -n ${HCO_NAMESPACE} -o name)
OLD_INSTALL_PLAN=$(oc -n "${HCO_NAMESPACE}" get "${HCO_SUBSCRIPTION}" -o jsonpath='{.status.installplan.name}')
${CMD} patch ${HCO_SUBSCRIPTION} -n ${HCO_NAMESPACE} -p "{\"spec\": {\"channel\": \"${TARGET_CHANNEL}\"}}" --type merge

# TEMP HACK TO UNLOCK UPGRADE
sleep 15
${CMD} delete -n openshift-operator-lifecycle-manager "$(oc get pod -n openshift-operator-lifecycle-manager -l app=olm-operator -o name)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${CMD} delete -n openshift-operator-lifecycle-manager "$(oc get pod -n openshift-operator-lifecycle-manager -l app=olm-operator -o name)"
${CMD} delete -n openshift-operator-lifecycle-manager "$(${CMD} get pod -n openshift-operator-lifecycle-manager -l app=olm-operator -o name)"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.
used for loop instead to avoid duplicated lines

# TEMP HACK TO UNLOCK UPGRADE
sleep 15
${CMD} delete -n openshift-operator-lifecycle-manager "$(oc get pod -n openshift-operator-lifecycle-manager -l app=olm-operator -o name)"
${CMD} delete -n openshift-operator-lifecycle-manager "$(oc get pod -n openshift-operator-lifecycle-manager -l app=catalog-operator -o name)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
${CMD} delete -n openshift-operator-lifecycle-manager "$(oc get pod -n openshift-operator-lifecycle-manager -l app=catalog-operator -o name)"
${CMD} delete -n openshift-operator-lifecycle-manager "$(${CMD} get pod -n openshift-operator-lifecycle-manager -l app=catalog-operator -o name)"

…upgrade

Signed-off-by: orenc1 <ocohen@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Collaborator

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 4, 2021

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure, ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 4, 2021

@orenc1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-hco-e2e-image-index-azure 9330e99b3f5ea76a765eac1daff1709c290f3de6 link /test okd-hco-e2e-image-index-azure
ci/prow/hco-e2e-upgrade-aws 9330e99b3f5ea76a765eac1daff1709c290f3de6 link /test hco-e2e-upgrade-aws
ci/prow/okd-hco-e2e-upgrade-index-gcp 1fdf254 link true /test okd-hco-e2e-upgrade-index-gcp
ci/prow/hco-e2e-image-index-gcp 1fdf254 link true /test hco-e2e-image-index-gcp
ci/prow/hco-e2e-image-index-azure 1fdf254 link true /test hco-e2e-image-index-azure
ci/prow/hco-e2e-kv-smoke-gcp 1fdf254 link true /test hco-e2e-kv-smoke-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tiraboschi
Copy link
Member

/override-bot

@hco-bot
Copy link
Collaborator

hco-bot commented Oct 4, 2021

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

1 similar comment
@hco-bot
Copy link
Collaborator

hco-bot commented Oct 4, 2021

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

@orenc1
Copy link
Collaborator Author

orenc1 commented Oct 4, 2021

/override ci/prow/hco-e2e-kv-smoke-gcp

@orenc1
Copy link
Collaborator Author

orenc1 commented Oct 4, 2021

checking if openshift-ci bot is alive

/shrug

@orenc1 orenc1 merged commit c56994d into kubevirt:main Oct 4, 2021
@orenc1 orenc1 deleted the blank_pr branch October 4, 2021 16:26
@kubevirt-bot
Copy link
Contributor

@hco-bot: hco-bot unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

@hco-bot: hco-bot unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Contributor

@orenc1: Overrode contexts on behalf of orenc1: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi
Copy link
Member

/cherry-pick release-1.5

@kubevirt-bot
Copy link
Contributor

@tiraboschi: new pull request created: #1552

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiraboschi tiraboschi mentioned this pull request Oct 5, 2021
11 tasks
hco-bot pushed a commit to tiraboschi/hyperconverged-cluster-operator that referenced this pull request Dec 29, 2021
Revert an hack on upgrade lanes introduced in kubevirt#1323
to bypass a possible upgrade bug on the OLM side.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
kubevirt-bot pushed a commit that referenced this pull request Dec 29, 2021
Revert an hack on upgrade lanes introduced in #1323
to bypass a possible upgrade bug on the OLM side.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants