Revert an hack on upgrade lanes #1557

tiraboschi · 2021-10-05T10:26:36Z

Revert an hack on upgrade lanes introduced in #1323
to bypass a possible upgrade bug on the OLM side.

Signed-off-by: Simone Tiraboschi stirabos@redhat.com

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

NONE

coveralls · 2021-10-05T10:30:19Z

Pull Request Test Coverage Report for Build 1634103018

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.612%

Totals
Change from base Build 1633522825:	0.0%
Covered Lines:	3717
Relevant Lines:	5264

💛 - Coveralls

hco-bot · 2021-10-05T11:48:26Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-10-05T11:48:34Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2021-10-05T11:53:49Z

We would be able to revert the workaround once operator-framework/operator-lifecycle-manager#2382 will make its way to OLM downstream and be consumed by OCP-CI

hco-bot · 2021-10-05T13:30:06Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-10-05T13:30:09Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-10-07T05:55:40Z

/retest

Checking if the OLM fix was merged.

orenc1 · 2021-10-07T06:34:58Z

/retest

Checking if the OLM fix was merged.

This is the PR that syncs OLM downstream with its upstream counterpart:
openshift/operator-framework-olm#196
Once it merges, we can assume the next OCP CI build will include the fix.

tiraboschi · 2021-10-07T11:03:44Z

/retest

tiraboschi · 2021-10-09T09:20:14Z

/retest

tiraboschi · 2021-10-11T06:53:44Z

/retest

tiraboschi · 2021-10-25T09:33:32Z

/rebase

hco-bot · 2021-10-25T11:07:33Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-10-25T11:07:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-10-25T12:48:18Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-10-25T12:48:21Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-10-26T05:53:45Z

/retest

orenc1 · 2021-11-02T14:59:04Z

https://bugzilla.redhat.com/show_bug.cgi?id=2002276 is in QA
/retest

orenc1 · 2021-11-03T07:50:58Z

looks like now OLM bug resolved, but now failing on

 Not all the running VMs got upgraded

/retest

hco-bot · 2021-11-03T13:53:02Z

hco-e2e-image-index-aws, hco-e2e-image-index-azure lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-11-03T13:53:27Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws, hco-e2e-image-index-azure lanes succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-11-03T14:08:29Z

okd-hco-e2e-image-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-aws

hco-bot · 2021-11-21T17:08:34Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2021-11-21T17:08:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa · 2021-11-21T19:18:49Z

/retest

nunnatsa · 2021-12-01T10:25:29Z

/retest

tiraboschi · 2021-12-16T10:31:36Z

/rebase

orenc1 · 2021-12-29T13:07:17Z

/rebase

Revert an hack on upgrade lanes introduced in kubevirt#1323 to bypass a possible upgrade bug on the OLM side. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

sonarcloud · 2021-12-29T13:10:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2021-12-29T14:29:58Z

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2021-12-29T14:30:02Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-index-azure

In response to this:

hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure
hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-29T14:40:26Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

kubevirt-bot · 2021-12-29T14:40:30Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-azure

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2021-12-29T15:47:41Z

/retest

hco-bot · 2021-12-29T16:28:00Z

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

kubevirt-bot · 2021-12-29T16:28:03Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-gcp

In response to this:

hco-e2e-kv-smoke-azure lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2021-12-29T17:32:58Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2021-12-29T17:33:01Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

orenc1 · 2021-12-29T17:39:12Z

/retest

hco-bot · 2021-12-29T19:09:39Z

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

kubevirt-bot · 2021-12-29T19:09:42Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-sno-azure

In response to this:

hco-e2e-upgrade-prev-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-12-29T19:16:28Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-image-index-gcp	`2bc26b0`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-image-index-sno-aws	`2bc26b0`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-upgrade-index-azure	`2bc26b0`	link	true	`/test hco-e2e-upgrade-index-azure`
ci/prow/hco-e2e-upgrade-index-sno-azure	`2bc26b0`	link	false	`/test hco-e2e-upgrade-index-sno-azure`
ci/prow/hco-e2e-kv-smoke-gcp	`2bc26b0`	link	true	`/test hco-e2e-kv-smoke-gcp`
ci/prow/okd-hco-e2e-upgrade-index-aws	`2bc26b0`	link	true	`/test okd-hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-upgrade-prev-index-sno-azure	`2bc26b0`	link	false	`/test hco-e2e-upgrade-prev-index-sno-azure`
ci/prow/hco-e2e-upgrade-prev-index-azure	`2bc26b0`	link	true	`/test hco-e2e-upgrade-prev-index-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2021-12-29T19:22:40Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2021-12-29T19:22:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

/approve

kubevirt-bot · 2021-12-29T19:33:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi requested review from orenc1 and nunnatsa October 5, 2021 10:26

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 5, 2021

kubevirt-bot requested a review from sradco October 5, 2021 10:26

kubevirt-bot added the size/XS label Oct 5, 2021

tiraboschi force-pushed the revert_upgrade_hack branch from eb06c70 to 4b7f973 Compare October 25, 2021 09:51

tiraboschi force-pushed the revert_upgrade_hack branch from 4b7f973 to 79aa4de Compare November 3, 2021 12:33

Revert an hack on upgrade lanes

2bc26b0

Revert an hack on upgrade lanes introduced in kubevirt#1323 to bypass a possible upgrade bug on the OLM side. Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

hco-bot force-pushed the revert_upgrade_hack branch from b91aa26 to 2bc26b0 Compare December 29, 2021 13:09

nunnatsa approved these changes Dec 29, 2021

View reviewed changes

kubevirt-bot assigned nunnatsa Dec 29, 2021

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2021

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2021

kubevirt-bot merged commit d50504f into kubevirt:main Dec 29, 2021

Revert an hack on upgrade lanes #1557

Revert an hack on upgrade lanes #1557

Conversation

tiraboschi commented Oct 5, 2021

coveralls commented Oct 5, 2021 • edited Loading

Pull Request Test Coverage Report for Build 1634103018

💛 - Coveralls

hco-bot commented Oct 5, 2021

kubevirt-bot commented Oct 5, 2021

orenc1 commented Oct 5, 2021

hco-bot commented Oct 5, 2021

kubevirt-bot commented Oct 5, 2021

nunnatsa commented Oct 7, 2021

orenc1 commented Oct 7, 2021

tiraboschi commented Oct 7, 2021

tiraboschi commented Oct 9, 2021

tiraboschi commented Oct 11, 2021

tiraboschi commented Oct 25, 2021

hco-bot commented Oct 25, 2021

kubevirt-bot commented Oct 25, 2021

hco-bot commented Oct 25, 2021

kubevirt-bot commented Oct 25, 2021

nunnatsa commented Oct 26, 2021

orenc1 commented Nov 2, 2021

orenc1 commented Nov 3, 2021

hco-bot commented Nov 3, 2021

kubevirt-bot commented Nov 3, 2021

hco-bot commented Nov 3, 2021

hco-bot commented Nov 21, 2021

kubevirt-bot commented Nov 21, 2021

nunnatsa commented Nov 21, 2021

nunnatsa commented Dec 1, 2021

tiraboschi commented Dec 16, 2021

orenc1 commented Dec 29, 2021

sonarcloud bot commented Dec 29, 2021

hco-bot commented Dec 29, 2021

kubevirt-bot commented Dec 29, 2021

hco-bot commented Dec 29, 2021

kubevirt-bot commented Dec 29, 2021

orenc1 commented Dec 29, 2021

hco-bot commented Dec 29, 2021

kubevirt-bot commented Dec 29, 2021

hco-bot commented Dec 29, 2021

kubevirt-bot commented Dec 29, 2021

orenc1 commented Dec 29, 2021

hco-bot commented Dec 29, 2021

kubevirt-bot commented Dec 29, 2021

openshift-ci bot commented Dec 29, 2021

hco-bot commented Dec 29, 2021

kubevirt-bot commented Dec 29, 2021

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Dec 29, 2021

coveralls commented Oct 5, 2021 •

edited

Loading