Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors #2382

Merged
merged 1 commit into from
Sep 30, 2021
Merged

pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors #2382

merged 1 commit into from
Sep 30, 2021

Conversation

timflannagan
Copy link
Contributor

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive

@timflannagan
pkg/controller: Test commit
a42ce02 
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan changed the title pkg/controller: Test commit pkg/controller: Migrate to using a read lock instead of a readwrite lock when checking for any namespace caching errors Sep 30, 2021
@exdx
Copy link
Member

exdx commented Sep 30, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
dinhxuanvu
dinhxuanvu approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 396b546 into operator-framework:master Sep 30, 2021
@orenc1 orenc1 mentioned this pull request Oct 5, 2021
Merged
11 tasks
@timflannagan timflannagan mentioned this pull request Oct 6, 2021
Open
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@benluddy benluddy Awaiting requested review from benluddy

Assignees

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timflannagan @exdx @dinhxuanvu @openshift-merge-robot