Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with user-defined labels in priorityClass #3085

Merged
merged 1 commit into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. Fix bug with user-defined labels in priorityClass

    HCO already supports user-defined labels in priorityClass, but if
    another change is done to the priorityClass, either a change in a
    required label, or a change in the spec fields, the user-defined labels
    are deleted. This is also happens if the other modofication is done in
    different request.
    
    This PR fixes this issue, and makes sure that user-defined labels are
    stay in place on update of the priorityClass. As part of the fix, HCO
    now does not remove and re-create the priorityClass, if only label were
    changed, but updates it. As result, the update_priority_class was
    removed as it is not relevant anymore.
    
    Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
    nunnatsa committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    7da9ab0 View commit details
    Browse the repository at this point in the history